RE: [PATCH 1/6 v3] omap: musb: Adding hwmod data for ti81xx
Hi, On Mon, Oct 10, 2011 at 10:40:55AM +0530, Gupta, Ajay Kumar wrote: Hi, On Mon, Sep 26, 2011 at 03:21:07PM +0530, Gupta, Ajay Kumar wrote: To: linux-omap@vger.kernel.org Cc: linux-...@vger.kernel.org; Balbi, Felipe; t...@atomide.com; B, Ravi; Cousson, Benoit; Gupta, Ajay Kumar Subject: [PATCH 1/6 v3] omap: musb: Adding hwmod data for ti81xx Felipe, I am planning to send patch 1/6 along with next revision of ti81xx hwmod baseport patch from Hemant so that all hwmod data gets reviewed at one place. So now only rest 5 (2/6 to 6/6) patches needs to be queued for usb. I hope this will be fine with you. Let me know if you want me to post Same 5 patches separately. I guess it's better to queue them separately. I will only take whatever lies in drivers/usb/musb Ok fine so usb hwmod patch will come from Hemant in his hwmod baseport Series. I will resubmit the one patch fixing your comment. ok cool, tks. For you platform_data stuff (if you have any), you can add a header to include/linux/platform_data/musb-dsps.h I need to access struct omap_musb_board_data and so would add #include plat/usb.h in new file drivers/usb/musb/musb_dsps.h. Any comment ? Ajay Or something similar. -- balbi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/6 v3] omap: musb: Adding hwmod data for ti81xx
Hi, On Tue, Oct 11, 2011 at 02:13:07PM +0530, Gupta, Ajay Kumar wrote: Hi, On Mon, Oct 10, 2011 at 10:40:55AM +0530, Gupta, Ajay Kumar wrote: Hi, On Mon, Sep 26, 2011 at 03:21:07PM +0530, Gupta, Ajay Kumar wrote: To: linux-omap@vger.kernel.org Cc: linux-...@vger.kernel.org; Balbi, Felipe; t...@atomide.com; B, Ravi; Cousson, Benoit; Gupta, Ajay Kumar Subject: [PATCH 1/6 v3] omap: musb: Adding hwmod data for ti81xx Felipe, I am planning to send patch 1/6 along with next revision of ti81xx hwmod baseport patch from Hemant so that all hwmod data gets reviewed at one place. So now only rest 5 (2/6 to 6/6) patches needs to be queued for usb. I hope this will be fine with you. Let me know if you want me to post Same 5 patches separately. I guess it's better to queue them separately. I will only take whatever lies in drivers/usb/musb Ok fine so usb hwmod patch will come from Hemant in his hwmod baseport Series. I will resubmit the one patch fixing your comment. ok cool, tks. For you platform_data stuff (if you have any), you can add a header to include/linux/platform_data/musb-dsps.h I need to access struct omap_musb_board_data and so would add #include plat/usb.h in new file drivers/usb/musb/musb_dsps.h. Any comment ? It would be nice to move that platform_data from plat to linux/platform_data -- balbi signature.asc Description: Digital signature
RE: [PATCH 1/6 v3] omap: musb: Adding hwmod data for ti81xx
Hi,
On Tue, Oct 11, 2011 at 02:13:07PM +0530, Gupta, Ajay Kumar wrote:
Hi,
On Mon, Oct 10, 2011 at 10:40:55AM +0530, Gupta, Ajay Kumar wrote:
Hi,
On Mon, Sep 26, 2011 at 03:21:07PM +0530, Gupta, Ajay Kumar
wrote:
To: linux-omap@vger.kernel.org
Cc: linux-...@vger.kernel.org; Balbi, Felipe;
t...@atomide.com; B, Ravi; Cousson, Benoit; Gupta, Ajay
Kumar
Subject: [PATCH 1/6 v3] omap: musb: Adding hwmod data for
ti81xx
Felipe,
I am planning to send patch 1/6 along with next revision of
ti81xx hwmod baseport patch from Hemant so that all hwmod data
gets reviewed at one place.
So now only rest 5 (2/6 to 6/6) patches needs to be queued for
usb.
I hope this will be fine with you. Let me know if you want me
to post Same 5 patches separately.
I guess it's better to queue them separately. I will only take
whatever lies in drivers/usb/musb
Ok fine so usb hwmod patch will come from Hemant in his hwmod
baseport Series. I will resubmit the one patch fixing your
comment.
ok cool, tks.
For you platform_data stuff (if you have any), you can add a header
to include/linux/platform_data/musb-dsps.h
I need to access struct omap_musb_board_data and so would add
#include plat/usb.h in new file drivers/usb/musb/musb_dsps.h.
Any comment ?
It would be nice to move that platform_data from plat to
linux/platform_data
Yes, correct. But that would need change at below files.
arch/arm/mach-omap2/board-4430sdp.c:static struct omap_musb_board_data
musb_board_data = {
arch/arm/mach-omap2/board-am3517evm.c:static struct omap_musb_board_data
musb_board_data = {
arch/arm/mach-omap2/board-omap3evm.c:static struct omap_musb_board_data
musb_board_data = {
arch/arm/mach-omap2/board-rx51.c:static struct omap_musb_board_data
musb_board_data = {
arch/arm/mach-omap2/board-omap4panda.c:static struct omap_musb_board_data
musb_board_data = {
arch/arm/mach-omap2/board-ti8168evm.c:static struct omap_musb_board_data
musb_board_data = {
arch/arm/mach-omap2/board-omap4pcm049.c:static struct omap_musb_board_data
musb_board_data = {
arch/arm/mach-omap2/usb-musb.c:static void usb_musb_mux_init(struct
omap_musb_board_data *board_data)
arch/arm/mach-omap2/board-ti8148evm.c:static struct omap_musb_board_data
musb_board_data = {
arch/arm/mach-omap2/board-am335xevm.c:static struct omap_musb_board_data
musb_board_data = {
arch/arm/mach-omap2/board-ti8148evm.c.orig:static struct omap_musb_board_data
musb_board_data = {
arch/arm/mach-omap2/board-omap3evm.c.orig:static struct omap_musb_board_data
musb_board_data = {
drivers/usb/musb/am35x.c:
drivers/usb/musb/musb_dsps.c
drivers/usb/musb/omap2430.c:
I think this can be done in a separate patch and let the ti81xx 6/6
Patch to remain same.
The separate patch will replace #include plat/usb.h to
#include platform_data/usb.h
Ajay
--
balbi
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/6 v3] omap: musb: Adding hwmod data for ti81xx
Hi,
On Tue, Oct 11, 2011 at 03:07:46PM +0530, Gupta, Ajay Kumar wrote:
Hi,
On Tue, Oct 11, 2011 at 02:13:07PM +0530, Gupta, Ajay Kumar wrote:
Hi,
On Mon, Oct 10, 2011 at 10:40:55AM +0530, Gupta, Ajay Kumar wrote:
Hi,
On Mon, Sep 26, 2011 at 03:21:07PM +0530, Gupta, Ajay Kumar
wrote:
To: linux-omap@vger.kernel.org
Cc: linux-...@vger.kernel.org; Balbi, Felipe;
t...@atomide.com; B, Ravi; Cousson, Benoit; Gupta, Ajay
Kumar
Subject: [PATCH 1/6 v3] omap: musb: Adding hwmod data for
ti81xx
Felipe,
I am planning to send patch 1/6 along with next revision of
ti81xx hwmod baseport patch from Hemant so that all hwmod data
gets reviewed at one place.
So now only rest 5 (2/6 to 6/6) patches needs to be queued for
usb.
I hope this will be fine with you. Let me know if you want me
to post Same 5 patches separately.
I guess it's better to queue them separately. I will only take
whatever lies in drivers/usb/musb
Ok fine so usb hwmod patch will come from Hemant in his hwmod
baseport Series. I will resubmit the one patch fixing your
comment.
ok cool, tks.
For you platform_data stuff (if you have any), you can add a header
to include/linux/platform_data/musb-dsps.h
I need to access struct omap_musb_board_data and so would add
#include plat/usb.h in new file drivers/usb/musb/musb_dsps.h.
Any comment ?
It would be nice to move that platform_data from plat to
linux/platform_data
Yes, correct. But that would need change at below files.
arch/arm/mach-omap2/board-4430sdp.c:static struct omap_musb_board_data
musb_board_data = {
arch/arm/mach-omap2/board-am3517evm.c:static struct omap_musb_board_data
musb_board_data = {
arch/arm/mach-omap2/board-omap3evm.c:static struct omap_musb_board_data
musb_board_data = {
arch/arm/mach-omap2/board-rx51.c:static struct omap_musb_board_data
musb_board_data = {
arch/arm/mach-omap2/board-omap4panda.c:static struct omap_musb_board_data
musb_board_data = {
arch/arm/mach-omap2/board-ti8168evm.c:static struct omap_musb_board_data
musb_board_data = {
arch/arm/mach-omap2/board-omap4pcm049.c:static struct omap_musb_board_data
musb_board_data = {
arch/arm/mach-omap2/usb-musb.c:static void usb_musb_mux_init(struct
omap_musb_board_data *board_data)
arch/arm/mach-omap2/board-ti8148evm.c:static struct omap_musb_board_data
musb_board_data = {
arch/arm/mach-omap2/board-am335xevm.c:static struct omap_musb_board_data
musb_board_data = {
arch/arm/mach-omap2/board-ti8148evm.c.orig:static struct omap_musb_board_data
musb_board_data = {
arch/arm/mach-omap2/board-omap3evm.c.orig:static struct omap_musb_board_data
musb_board_data = {
drivers/usb/musb/am35x.c:
drivers/usb/musb/musb_dsps.c
drivers/usb/musb/omap2430.c:
I think this can be done in a separate patch and let the ti81xx 6/6
Patch to remain same.
The separate patch will replace #include plat/usb.h to
#include platform_data/usb.h
cool, that can be done with a sed script ;-)
--
balbi
signature.asc
Description: Digital signature
RE: [PATCH 1/6 v3] omap: musb: Adding hwmod data for ti81xx
Hi,
On Tue, Oct 11, 2011 at 02:13:07PM +0530, Gupta, Ajay Kumar wrote:
Hi,
On Mon, Oct 10, 2011 at 10:40:55AM +0530, Gupta, Ajay Kumar
wrote:
Hi,
On Mon, Sep 26, 2011 at 03:21:07PM +0530, Gupta, Ajay Kumar
wrote:
To: linux-omap@vger.kernel.org
Cc: linux-...@vger.kernel.org; Balbi, Felipe;
t...@atomide.com; B, Ravi; Cousson, Benoit; Gupta, Ajay
Kumar
Subject: [PATCH 1/6 v3] omap: musb: Adding hwmod data
for ti81xx
Felipe,
I am planning to send patch 1/6 along with next revision
of ti81xx hwmod baseport patch from Hemant so that all
hwmod data gets reviewed at one place.
So now only rest 5 (2/6 to 6/6) patches needs to be queued
for
usb.
I hope this will be fine with you. Let me know if you want
me to post Same 5 patches separately.
I guess it's better to queue them separately. I will only
take whatever lies in drivers/usb/musb
Ok fine so usb hwmod patch will come from Hemant in his hwmod
baseport Series. I will resubmit the one patch fixing your
comment.
ok cool, tks.
For you platform_data stuff (if you have any), you can add a
header to include/linux/platform_data/musb-dsps.h
I need to access struct omap_musb_board_data and so would add
#include plat/usb.h in new file drivers/usb/musb/musb_dsps.h.
Any comment ?
It would be nice to move that platform_data from plat to
linux/platform_data
Yes, correct. But that would need change at below files.
arch/arm/mach-omap2/board-4430sdp.c:static struct omap_musb_board_data
musb_board_data = { arch/arm/mach-omap2/board-am3517evm.c:static
struct omap_musb_board_data musb_board_data = {
arch/arm/mach-omap2/board-omap3evm.c:static struct
omap_musb_board_data musb_board_data = {
arch/arm/mach-omap2/board-rx51.c:static struct omap_musb_board_data
musb_board_data = { arch/arm/mach-omap2/board-omap4panda.c:static
struct omap_musb_board_data musb_board_data = {
arch/arm/mach-omap2/board-ti8168evm.c:static struct
omap_musb_board_data musb_board_data = {
arch/arm/mach-omap2/board-omap4pcm049.c:static struct
omap_musb_board_data musb_board_data = {
arch/arm/mach-omap2/usb-musb.c:static void usb_musb_mux_init(struct
omap_musb_board_data *board_data)
arch/arm/mach-omap2/board-ti8148evm.c:static struct
omap_musb_board_data musb_board_data = {
arch/arm/mach-omap2/board-am335xevm.c:static struct
omap_musb_board_data musb_board_data = {
arch/arm/mach-omap2/board-ti8148evm.c.orig:static struct
omap_musb_board_data musb_board_data = {
arch/arm/mach-omap2/board-omap3evm.c.orig:static struct
omap_musb_board_data musb_board_data = {
drivers/usb/musb/am35x.c:
drivers/usb/musb/musb_dsps.c
drivers/usb/musb/omap2430.c:
I think this can be done in a separate patch and let the ti81xx 6/6
Patch to remain same.
The separate patch will replace #include plat/usb.h to #include
platform_data/usb.h
cool, that can be done with a sed script ;-)
Ok fine then I will send the refreshed 5 patch set for ti81xx and 3 patch set
for am335x correcting your comments.
Thanks,
Ajay
--
balbi
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/6 v3] omap: musb: Adding hwmod data for ti81xx
Hi, On Mon, Sep 26, 2011 at 03:21:07PM +0530, Gupta, Ajay Kumar wrote: To: linux-omap@vger.kernel.org Cc: linux-...@vger.kernel.org; Balbi, Felipe; t...@atomide.com; B, Ravi; Cousson, Benoit; Gupta, Ajay Kumar Subject: [PATCH 1/6 v3] omap: musb: Adding hwmod data for ti81xx Felipe, I am planning to send patch 1/6 along with next revision of ti81xx hwmod baseport patch from Hemant so that all hwmod data gets reviewed at one place. So now only rest 5 (2/6 to 6/6) patches needs to be queued for usb. I hope this will be fine with you. Let me know if you want me to post Same 5 patches separately. I guess it's better to queue them separately. I will only take whatever lies in drivers/usb/musb Ok fine so usb hwmod patch will come from Hemant in his hwmod baseport Series. I will resubmit the one patch fixing your comment. Thanks, Ajay -- balbi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/6 v3] omap: musb: Adding hwmod data for ti81xx
Hi, On Mon, Oct 10, 2011 at 10:40:55AM +0530, Gupta, Ajay Kumar wrote: Hi, On Mon, Sep 26, 2011 at 03:21:07PM +0530, Gupta, Ajay Kumar wrote: To: linux-omap@vger.kernel.org Cc: linux-...@vger.kernel.org; Balbi, Felipe; t...@atomide.com; B, Ravi; Cousson, Benoit; Gupta, Ajay Kumar Subject: [PATCH 1/6 v3] omap: musb: Adding hwmod data for ti81xx Felipe, I am planning to send patch 1/6 along with next revision of ti81xx hwmod baseport patch from Hemant so that all hwmod data gets reviewed at one place. So now only rest 5 (2/6 to 6/6) patches needs to be queued for usb. I hope this will be fine with you. Let me know if you want me to post Same 5 patches separately. I guess it's better to queue them separately. I will only take whatever lies in drivers/usb/musb Ok fine so usb hwmod patch will come from Hemant in his hwmod baseport Series. I will resubmit the one patch fixing your comment. ok cool, tks. For you platform_data stuff (if you have any), you can add a header to include/linux/platform_data/musb-dsps.h Or something similar. -- balbi signature.asc Description: Digital signature
Re: [PATCH 1/6 v3] omap: musb: Adding hwmod data for ti81xx
Hi, On Mon, Sep 26, 2011 at 03:21:07PM +0530, Gupta, Ajay Kumar wrote: To: linux-omap@vger.kernel.org Cc: linux-...@vger.kernel.org; Balbi, Felipe; t...@atomide.com; B, Ravi; Cousson, Benoit; Gupta, Ajay Kumar Subject: [PATCH 1/6 v3] omap: musb: Adding hwmod data for ti81xx Felipe, I am planning to send patch 1/6 along with next revision of ti81xx hwmod baseport patch from Hemant so that all hwmod data gets reviewed at one place. So now only rest 5 (2/6 to 6/6) patches needs to be queued for usb. I hope this will be fine with you. Let me know if you want me to post Same 5 patches separately. I guess it's better to queue them separately. I will only take whatever lies in drivers/usb/musb -- balbi signature.asc Description: Digital signature
RE: [PATCH 1/6 v3] omap: musb: Adding hwmod data for ti81xx
Hi, To: linux-omap@vger.kernel.org Cc: linux-...@vger.kernel.org; Balbi, Felipe; t...@atomide.com; B, Ravi; Cousson, Benoit; Gupta, Ajay Kumar Subject: [PATCH 1/6 v3] omap: musb: Adding hwmod data for ti81xx Felipe, I am planning to send patch 1/6 along with next revision of ti81xx hwmod baseport patch from Hemant so that all hwmod data gets reviewed at one place. So now only rest 5 (2/6 to 6/6) patches needs to be queued for usb. I hope this will be fine with you. Let me know if you want me to post Same 5 patches separately. Ajay From: Ravi Babu ravib...@ti.com [...] -- 1.6.2.4 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/6 v3] omap: musb: Adding hwmod data for ti81xx
From: Ravi Babu ravib...@ti.com
The usb subsystem (usbss) in ti81xx has two musb interfaces. There are three
irqs and three address spaces for usbss, musb0 and musb1 respectively. Created
one hwmod with three irq and memory resources.
Cc: Benoit Cousson b-cous...@ti.com
Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com
Signed-off-by: Ravi Babu ravib...@ti.com
Acked-by: Keshava Munegowda keshava_mgo...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 74
1 files changed, 74 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
index e73a4c6..e960d70 100644
--- a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
@@ -194,6 +194,7 @@ static struct omap_hwmod ti81xx_timer4_hwmod;
static struct omap_hwmod ti81xx_timer5_hwmod;
static struct omap_hwmod ti81xx_timer6_hwmod;
static struct omap_hwmod ti81xx_timer7_hwmod;
+static struct omap_hwmod ti81xx_usbss_hwmod;
/* L4 SLOW - TIMER1 interface */
static struct omap_hwmod_addr_space ti81xx_timer1_addr_space[] = {
@@ -650,6 +651,78 @@ static struct omap_hwmod ti81xx_timer7_hwmod = {
.omap_chip = OMAP_CHIP_INIT(CHIP_IS_TI816X | CHIP_IS_TI814X)
};
+/* L3 SLOW - USBSS interface */
+static struct omap_hwmod_addr_space ti81xx_usbss_addr_space[] = {
+ {
+ .name = usbss,
+ .pa_start = 0x4740,
+ .pa_end = 0x4740 + SZ_4K - 1,
+ .flags = ADDR_TYPE_RT
+ },
+ {
+ .name = musb0,
+ .pa_start = 0x47401000,
+ .pa_end = 0x47401000 + SZ_2K - 1,
+ .flags = ADDR_TYPE_RT
+ },
+ {
+ .name = musb1,
+ .pa_start = 0x47401800,
+ .pa_end = 0x47401800 + SZ_2K - 1,
+ .flags = ADDR_TYPE_RT
+ },
+ {
+ },
+};
+
+static struct omap_hwmod_class_sysconfig ti81xx_usbhsotg_sysc = {
+ .rev_offs = 0x0,
+ .sysc_offs = 0x10,
+ .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_SOFTRESET),
+ .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART),
+ .sysc_fields= omap_hwmod_sysc_type2,
+};
+
+static struct omap_hwmod_class ti81xx_usbotg_class = {
+ .name = usbotg,
+ .sysc = ti81xx_usbhsotg_sysc,
+};
+
+static struct omap_hwmod_irq_info ti81xx_usbss_mpu_irqs[] = {
+ { .name = usbss-irq, .irq = 17, },
+ { .name = musb0-irq, .irq = 18, },
+ { .name = musb1-irq, .irq = 19, },
+ { .irq = -1, },
+};
+
+static struct omap_hwmod_ocp_if ti81xx_l3_slow__usbss = {
+ .master = ti81xx_l3_slow_hwmod,
+ .slave = ti81xx_usbss_hwmod,
+ .clk= usbotg_ick,
+ .addr = ti81xx_usbss_addr_space,
+ .user = OCP_USER_MPU,
+ .flags = OCPIF_SWSUP_IDLE,
+};
+
+static struct omap_hwmod_ocp_if *ti81xx_usbss_slaves[] = {
+ ti81xx_l3_slow__usbss,
+};
+
+static struct omap_hwmod ti81xx_usbss_hwmod = {
+ .name = usb_otg_hs,
+ .mpu_irqs = ti81xx_usbss_mpu_irqs,
+ .main_clk = usbotg_ick,
+ .clkdm_name = default_usb_clkdm,
+ .prcm = {
+ .omap4 = {
+ .clkctrl_offs = TI816X_CM_DEFAULT_USB_CLKCTRL_OFFSET,
+ },
+ },
+ .slaves = ti81xx_usbss_slaves,
+ .slaves_cnt = ARRAY_SIZE(ti81xx_usbss_slaves),
+ .class = ti81xx_usbotg_class,
+ .omap_chip = OMAP_CHIP_INIT(CHIP_IS_TI816X | CHIP_IS_TI814X)
+};
static __initdata struct omap_hwmod *ti81xx_hwmods[] = {
ti81xx_l3_fast_hwmod,
@@ -668,6 +741,7 @@ static __initdata struct omap_hwmod *ti81xx_hwmods[] = {
ti81xx_timer5_hwmod,
ti81xx_timer6_hwmod,
ti81xx_timer7_hwmod,
+ ti81xx_usbss_hwmod,
NULL,
};
--
1.6.2.4
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
