Re: [PATCH 3/5] gpio: omap: add a GPIO_OMAP option instead of using ARCH_OMAP

2014-04-10 Thread Santosh Shilimkar
On Sunday 06 April 2014 10:58 AM, Javier Martinez Canillas wrote:
 The ARCH_OMAP config option was used to built the GPIO OMAP
 driver but this is not consistent with the rest of the GPIO
 drivers that have their own Kconfig option.
 
 Also, this make it harder to add dependencies or reverse
 dependencies (i.e: select) since that would mean touching the
 sub-arch config option.
 
 So is better to add a boolean Kconfig option for this driver
 that defaults to true if ARCH_OMAP is enabled.
 
 Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
 ---
Acked-by: Santosh Shilimkar santosh.shilim...@ti.com


--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 3/5] gpio: omap: add a GPIO_OMAP option instead of using ARCH_OMAP

2014-04-06 Thread Javier Martinez Canillas
The ARCH_OMAP config option was used to built the GPIO OMAP
driver but this is not consistent with the rest of the GPIO
drivers that have their own Kconfig option.

Also, this make it harder to add dependencies or reverse
dependencies (i.e: select) since that would mean touching the
sub-arch config option.

So is better to add a boolean Kconfig option for this driver
that defaults to true if ARCH_OMAP is enabled.

Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
 drivers/gpio/Kconfig  | 7 +++
 drivers/gpio/Makefile | 2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 92d8e9a..bfe5cf0 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -243,6 +243,13 @@ config GPIO_OCTEON
  Say yes here to support the on-chip GPIO lines on the OCTEON
  family of SOCs.
 
+config GPIO_OMAP
+   bool TI OMAP GPIO support
+   default y if ARCH_OMAP
+   depends on ARM  ARCH_OMAP
+   help
+ Say yes here to enable GPIO support for TI OMAP SoCs.
+
 config GPIO_PL061
bool PrimeCell PL061 GPIO support
depends on ARM_AMBA
diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
index 6309aff..d10f6a9 100644
--- a/drivers/gpio/Makefile
+++ b/drivers/gpio/Makefile
@@ -58,7 +58,7 @@ obj-$(CONFIG_GPIO_MVEBU)+= gpio-mvebu.o
 obj-$(CONFIG_GPIO_MXC) += gpio-mxc.o
 obj-$(CONFIG_GPIO_MXS) += gpio-mxs.o
 obj-$(CONFIG_GPIO_OCTEON)  += gpio-octeon.o
-obj-$(CONFIG_ARCH_OMAP)+= gpio-omap.o
+obj-$(CONFIG_GPIO_OMAP)+= gpio-omap.o
 obj-$(CONFIG_GPIO_PCA953X) += gpio-pca953x.o
 obj-$(CONFIG_GPIO_PCF857X) += gpio-pcf857x.o
 obj-$(CONFIG_GPIO_PCH) += gpio-pch.o
-- 
1.9.0

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html