Re: [PATCH 7/7] OMAPDSS: HDMI: hot plug detect fix
On Thu, 2012-03-08 at 07:29 -0800, Greg KH wrote: On Thu, Mar 08, 2012 at 09:35:13AM +0200, Tomi Valkeinen wrote: On Wed, 2012-03-07 at 12:01 -0800, Greg KH wrote: On Thu, Mar 01, 2012 at 02:26:35PM +0200, Tomi Valkeinen wrote: From: Rob Clark r...@ti.com The OMAPDSS: HDMI: PHY burnout fix commit switched the HDMI driver over to using a GPIO for plug detect. Unfortunately the -detect() method was not also updated, causing HDMI to no longer work for the omapdrm driver (because it would actually check if a connection was detected before attempting to enable display). Signed-off-by: Rob Clark r...@ti.com Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com You forgot to tell me what the git commit id is for this patch (it's ca888a7958b3d808e4efd08ceff88913f4212c69, right?) Yes, that's the one. It wasn't in Linus's tree yet, only in fbdev tree, so I wasn't sure what the commit id is. Then you should not have sent it to me, as if I were to take it then, I could not have :( Oh, ok. I thought the patch-must-be-in-mainline-rule was not a totally strict one, so I decided to include it in this case as the patch was a rather trivial one and already in the fbdev tree (I mentioned it in the intro mail). I guess I got lucky and the patch got into mainline before you took the patches. And why isn't this needed for the 3.0 kernel as well? The detect() function is not present in 3.0, so there was nothing to break. Ok, so everything I've queued up is all that is needed, right? Yes, looks correct. Thanks! Tomi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 7/7] OMAPDSS: HDMI: hot plug detect fix
On Thu, Mar 08, 2012 at 09:35:13AM +0200, Tomi Valkeinen wrote: On Wed, 2012-03-07 at 12:01 -0800, Greg KH wrote: On Thu, Mar 01, 2012 at 02:26:35PM +0200, Tomi Valkeinen wrote: From: Rob Clark r...@ti.com The OMAPDSS: HDMI: PHY burnout fix commit switched the HDMI driver over to using a GPIO for plug detect. Unfortunately the -detect() method was not also updated, causing HDMI to no longer work for the omapdrm driver (because it would actually check if a connection was detected before attempting to enable display). Signed-off-by: Rob Clark r...@ti.com Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com You forgot to tell me what the git commit id is for this patch (it's ca888a7958b3d808e4efd08ceff88913f4212c69, right?) Yes, that's the one. It wasn't in Linus's tree yet, only in fbdev tree, so I wasn't sure what the commit id is. Then you should not have sent it to me, as if I were to take it then, I could not have :( And why isn't this needed for the 3.0 kernel as well? The detect() function is not present in 3.0, so there was nothing to break. Ok, so everything I've queued up is all that is needed, right? greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 7/7] OMAPDSS: HDMI: hot plug detect fix
On Thu, Mar 01, 2012 at 02:26:35PM +0200, Tomi Valkeinen wrote: From: Rob Clark r...@ti.com The OMAPDSS: HDMI: PHY burnout fix commit switched the HDMI driver over to using a GPIO for plug detect. Unfortunately the -detect() method was not also updated, causing HDMI to no longer work for the omapdrm driver (because it would actually check if a connection was detected before attempting to enable display). Signed-off-by: Rob Clark r...@ti.com Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com You forgot to tell me what the git commit id is for this patch (it's ca888a7958b3d808e4efd08ceff88913f4212c69, right?) And why isn't this needed for the 3.0 kernel as well? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 7/7] OMAPDSS: HDMI: hot plug detect fix
On Wed, 2012-03-07 at 12:01 -0800, Greg KH wrote: On Thu, Mar 01, 2012 at 02:26:35PM +0200, Tomi Valkeinen wrote: From: Rob Clark r...@ti.com The OMAPDSS: HDMI: PHY burnout fix commit switched the HDMI driver over to using a GPIO for plug detect. Unfortunately the -detect() method was not also updated, causing HDMI to no longer work for the omapdrm driver (because it would actually check if a connection was detected before attempting to enable display). Signed-off-by: Rob Clark r...@ti.com Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com You forgot to tell me what the git commit id is for this patch (it's ca888a7958b3d808e4efd08ceff88913f4212c69, right?) Yes, that's the one. It wasn't in Linus's tree yet, only in fbdev tree, so I wasn't sure what the commit id is. And why isn't this needed for the 3.0 kernel as well? The detect() function is not present in 3.0, so there was nothing to break. Tomi signature.asc Description: This is a digitally signed message part
[PATCH 7/7] OMAPDSS: HDMI: hot plug detect fix
From: Rob Clark r...@ti.com
The OMAPDSS: HDMI: PHY burnout fix commit switched the HDMI driver
over to using a GPIO for plug detect. Unfortunately the -detect()
method was not also updated, causing HDMI to no longer work for the
omapdrm driver (because it would actually check if a connection was
detected before attempting to enable display).
Signed-off-by: Rob Clark r...@ti.com
Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
---
drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c |9 +
1 files changed, 1 insertions(+), 8 deletions(-)
diff --git a/drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c
b/drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c
index 3683404..aad48a1 100644
--- a/drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c
+++ b/drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c
@@ -479,14 +479,7 @@ int ti_hdmi_4xxx_read_edid(struct hdmi_ip_data *ip_data,
bool ti_hdmi_4xxx_detect(struct hdmi_ip_data *ip_data)
{
- int r;
-
- void __iomem *base = hdmi_core_sys_base(ip_data);
-
- /* HPD */
- r = REG_GET(base, HDMI_CORE_SYS_SYS_STAT, 1, 1);
-
- return r == 1;
+ return gpio_get_value(ip_data-hpd_gpio);
}
static void hdmi_core_init(struct hdmi_core_video_config *video_cfg,
--
1.7.4.1
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
