Re: [PATCH RFC 08/26] dmaengine: omap-dma: consolidate setup of CCR
Hi Russell,
On Thursday 02 January 2014 08:40 PM, Russell King wrote:
Consolidate the setup of the channel control register. Prepare the
basic value in the preparation of the DMA descriptor, and write it into
the register upon descriptor execution.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/dma/omap-dma.c | 133 ---
1 files changed, 45 insertions(+), 88 deletions(-)
diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c
index 98928f7209f6..796f882da03c 100644
--- a/drivers/dma/omap-dma.c
+++ b/drivers/dma/omap-dma.c
@@ -58,8 +58,7 @@ struct omap_desc {
int16_t fi; /* for OMAP_DMA_SYNC_PACKET */
uint8_t es; /* OMAP_DMA_DATA_TYPE_xxx */
- uint8_t sync_mode; /* OMAP_DMA_SYNC_xxx */
- uint8_t sync_type; /* OMAP_DMA_xxx_SYNC* */
+ uint32_t ccr; /* CCR value */
uint16_t cicr; /* CICR value */
uint32_t csdp; /* CSDP value */
@@ -228,7 +227,6 @@ static void omap_dma_start_desc(struct omap_chan *c)
{
struct virt_dma_desc *vd = vchan_next_desc(c-vc);
struct omap_desc *d;
- uint32_t val;
if (!vd) {
c-desc = NULL;
@@ -240,23 +238,15 @@ static void omap_dma_start_desc(struct omap_chan *c)
c-desc = d = to_omap_dma_desc(vd-tx);
c-sgidx = 0;
- if (d-dir == DMA_DEV_TO_MEM) {
- val = c-plat-dma_read(CCR, c-dma_ch);
- val = ~(0x03 14 | 0x03 12);
- val |= OMAP_DMA_AMODE_POST_INC 14;
- val |= OMAP_DMA_AMODE_CONSTANT 12;
- c-plat-dma_write(val, CCR, c-dma_ch);
+ c-plat-dma_write(d-ccr, CCR, c-dma_ch);
+ if (dma_omap1())
+ c-plat-dma_write(d-ccr 16, CCR2, c-dma_ch);
+ if (d-dir == DMA_DEV_TO_MEM) {
c-plat-dma_write(d-dev_addr, CSSA, c-dma_ch);
c-plat-dma_write(0, CSEI, c-dma_ch);
c-plat-dma_write(d-fi, CSFI, c-dma_ch);
} else {
- val = c-plat-dma_read(CCR, c-dma_ch);
- val = ~(0x03 12 | 0x03 14);
- val |= OMAP_DMA_AMODE_CONSTANT 14;
- val |= OMAP_DMA_AMODE_POST_INC 12;
- c-plat-dma_write(val, CCR, c-dma_ch);
-
c-plat-dma_write(d-dev_addr, CDSA, c-dma_ch);
c-plat-dma_write(0, CDEI, c-dma_ch);
c-plat-dma_write(d-fi, CDFI, c-dma_ch);
@@ -264,47 +254,6 @@ static void omap_dma_start_desc(struct omap_chan *c)
c-plat-dma_write(d-csdp, CSDP, c-dma_ch);
- if (dma_omap1()) {
- val = c-plat-dma_read(CCR, c-dma_ch);
- val = ~(1 5);
- if (d-sync_mode == OMAP_DMA_SYNC_FRAME)
- val |= 1 5;
- c-plat-dma_write(val, CCR, c-dma_ch);
-
- val = c-plat-dma_read(CCR2, c-dma_ch);
- val = ~(1 2);
- if (d-sync_mode == OMAP_DMA_SYNC_BLOCK)
- val |= 1 2;
- c-plat-dma_write(val, CCR2, c-dma_ch);
- }
-
- if (dma_omap2plus() c-dma_sig) {
- val = c-plat-dma_read(CCR, c-dma_ch);
-
- /* DMA_SYNCHRO_CONTROL_UPPER depends on the channel number */
- val = ~(1 24 | 1 23 | 3 19 | 1 18 | 1 5 | 0x1f);
- val |= (c-dma_sig ~0x1f) 14;
- val |= c-dma_sig 0x1f;
-
- if (d-sync_mode OMAP_DMA_SYNC_FRAME)
- val |= 1 5;
-
- if (d-sync_mode OMAP_DMA_SYNC_BLOCK)
- val |= 1 18;
-
- switch (d-sync_type) {
- case OMAP_DMA_DST_SYNC_PREFETCH:/* dest synch */
- val |= 1 23; /* Prefetch */
- break;
- case 0:
- break;
- default:
- val |= 1 24; /* source synch */
- break;
- }
- c-plat-dma_write(val, CCR, c-dma_ch);
- }
-
omap_dma_start_sg(c, d, 0);
}
@@ -543,19 +492,17 @@ static struct dma_async_tx_descriptor
*omap_dma_prep_slave_sg(
struct scatterlist *sgent;
struct omap_desc *d;
dma_addr_t dev_addr;
- unsigned i, j = 0, es, en, frame_bytes, sync_type;
+ unsigned i, j = 0, es, en, frame_bytes;
u32 burst;
if (dir == DMA_DEV_TO_MEM) {
dev_addr = c-cfg.src_addr;
dev_width = c-cfg.src_addr_width;
burst = c-cfg.src_maxburst;
- sync_type = OMAP_DMA_SRC_SYNC;
} else if (dir == DMA_MEM_TO_DEV) {
dev_addr = c-cfg.dst_addr;
dev_width = c-cfg.dst_addr_width;
burst = c-cfg.dst_maxburst;
- sync_type = OMAP_DMA_DST_SYNC;
} else {
dev_err(chan-device-dev, %s: bad direction?\n, __func__);
return NULL;
@@ -584,12 +531,20 @@
Re: [PATCH RFC 08/26] dmaengine: omap-dma: consolidate setup of CCR
On Wed, Jan 22, 2014 at 06:25:57PM +0530, Sricharan R wrote:
Setting up of DMA_DST_SYNC_PREFETCH is missing after this ?
I'm not looking for the DMA engine driver to be a 100% reimplementation
of the legacy driver. Rather than supporting the entire set of features
which the legacy driver did, and have many of them simply not used, the
approach I'm taking here is to only support what is necessary for the
drivers we have in mainline - and what fits the DMA engine interfaces.
There is no point inventing new DMA engine interfaces for features for
which we have no users in mainline kernel - to try to do that will be
quite rightfully thrown out by the DMA engine maintainers.
Here's the total number of references/definitions of DMA_DST_SYNC_PREFETCH
in the mainline kernel:
arch/arm/plat-omap/dma.c: if (src_or_dst_synch ==
OMAP_DMA_DST_SYNC_PREFETCH) {
include/linux/omap-dma.h:#define OMAP_DMA_DST_SYNC_PREFETCH 0x02
Hence, this feature is unused at present.
--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was up to 13.2Mbit.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RFC 08/26] dmaengine: omap-dma: consolidate setup of CCR
On Wednesday 22 January 2014 09:19 AM, Russell King - ARM Linux wrote:
On Wed, Jan 22, 2014 at 06:25:57PM +0530, Sricharan R wrote:
Setting up of DMA_DST_SYNC_PREFETCH is missing after this ?
I'm not looking for the DMA engine driver to be a 100% reimplementation
of the legacy driver. Rather than supporting the entire set of features
which the legacy driver did, and have many of them simply not used, the
approach I'm taking here is to only support what is necessary for the
drivers we have in mainline - and what fits the DMA engine interfaces.
+1 on the approach.
There is no point inventing new DMA engine interfaces for features for
which we have no users in mainline kernel - to try to do that will be
quite rightfully thrown out by the DMA engine maintainers.
Here's the total number of references/definitions of DMA_DST_SYNC_PREFETCH
in the mainline kernel:
arch/arm/plat-omap/dma.c: if (src_or_dst_synch ==
OMAP_DMA_DST_SYNC_PREFETCH) {
include/linux/omap-dma.h:#define OMAP_DMA_DST_SYNC_PREFETCH 0x02
Hence, this feature is unused at present.
I thought the crypto was using the prefetch feature but it isn't.
Regards,
Santosh
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RFC 08/26] dmaengine: omap-dma: consolidate setup of CCR
On Mon, Jan 13, 2014 at 11:12:27PM +, Russell King - ARM Linux wrote: On Mon, Jan 13, 2014 at 02:14:26PM -0800, Tony Lindgren wrote: * Russell King rmk+ker...@arm.linux.org.uk [140102 07:17]: Consolidate the setup of the channel control register. Prepare the basic value in the preparation of the DMA descriptor, and write it into the register upon descriptor execution. FYI, this patch seems to be the one that causes the DMA timeout with device 55 error for omap1. Okay, looks like I've missed some bit of muxing for DMA signals or something. I've yet to find any information on this in the OMAP5912 docs, so I guess I'm going to have to do this not only blind, but also without hardware. GAH. Do you know which of the OMAP1 variants your device is? Is it OMAP15xx or OMAP16xx? It looks like OMAP15xx is easy to fix for this as it hasn't got the additional multiplexer on the DMA request signals. -- FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad. Estimate before purchase was up to 13.2Mbit. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RFC 08/26] dmaengine: omap-dma: consolidate setup of CCR
* Russell King - ARM Linux li...@arm.linux.org.uk [140114 05:41]: On Mon, Jan 13, 2014 at 11:12:27PM +, Russell King - ARM Linux wrote: On Mon, Jan 13, 2014 at 02:14:26PM -0800, Tony Lindgren wrote: * Russell King rmk+ker...@arm.linux.org.uk [140102 07:17]: Consolidate the setup of the channel control register. Prepare the basic value in the preparation of the DMA descriptor, and write it into the register upon descriptor execution. FYI, this patch seems to be the one that causes the DMA timeout with device 55 error for omap1. Okay, looks like I've missed some bit of muxing for DMA signals or something. I've yet to find any information on this in the OMAP5912 docs, so I guess I'm going to have to do this not only blind, but also without hardware. GAH. Do you know which of the OMAP1 variants your device is? Is it OMAP15xx or OMAP16xx? It looks like OMAP15xx is easy to fix for this as it hasn't got the additional multiplexer on the DMA request signals. This was with Nokia 770, which is 1710. Should be pretty much the same from SoC point of view as 5912 on OSK. Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RFC 08/26] dmaengine: omap-dma: consolidate setup of CCR
* Russell King rmk+ker...@arm.linux.org.uk [140102 07:17]: Consolidate the setup of the channel control register. Prepare the basic value in the preparation of the DMA descriptor, and write it into the register upon descriptor execution. FYI, this patch seems to be the one that causes the DMA timeout with device 55 error for omap1. Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RFC 08/26] dmaengine: omap-dma: consolidate setup of CCR
On Mon, Jan 13, 2014 at 02:14:26PM -0800, Tony Lindgren wrote: * Russell King rmk+ker...@arm.linux.org.uk [140102 07:17]: Consolidate the setup of the channel control register. Prepare the basic value in the preparation of the DMA descriptor, and write it into the register upon descriptor execution. FYI, this patch seems to be the one that causes the DMA timeout with device 55 error for omap1. Okay, looks like I've missed some bit of muxing for DMA signals or something. I've yet to find any information on this in the OMAP5912 docs, so I guess I'm going to have to do this not only blind, but also without hardware. GAH. -- FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad. Estimate before purchase was up to 13.2Mbit. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH RFC 08/26] dmaengine: omap-dma: consolidate setup of CCR
Consolidate the setup of the channel control register. Prepare the
basic value in the preparation of the DMA descriptor, and write it into
the register upon descriptor execution.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/dma/omap-dma.c | 133 ---
1 files changed, 45 insertions(+), 88 deletions(-)
diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c
index 98928f7209f6..796f882da03c 100644
--- a/drivers/dma/omap-dma.c
+++ b/drivers/dma/omap-dma.c
@@ -58,8 +58,7 @@ struct omap_desc {
int16_t fi; /* for OMAP_DMA_SYNC_PACKET */
uint8_t es; /* OMAP_DMA_DATA_TYPE_xxx */
- uint8_t sync_mode; /* OMAP_DMA_SYNC_xxx */
- uint8_t sync_type; /* OMAP_DMA_xxx_SYNC* */
+ uint32_t ccr; /* CCR value */
uint16_t cicr; /* CICR value */
uint32_t csdp; /* CSDP value */
@@ -228,7 +227,6 @@ static void omap_dma_start_desc(struct omap_chan *c)
{
struct virt_dma_desc *vd = vchan_next_desc(c-vc);
struct omap_desc *d;
- uint32_t val;
if (!vd) {
c-desc = NULL;
@@ -240,23 +238,15 @@ static void omap_dma_start_desc(struct omap_chan *c)
c-desc = d = to_omap_dma_desc(vd-tx);
c-sgidx = 0;
- if (d-dir == DMA_DEV_TO_MEM) {
- val = c-plat-dma_read(CCR, c-dma_ch);
- val = ~(0x03 14 | 0x03 12);
- val |= OMAP_DMA_AMODE_POST_INC 14;
- val |= OMAP_DMA_AMODE_CONSTANT 12;
- c-plat-dma_write(val, CCR, c-dma_ch);
+ c-plat-dma_write(d-ccr, CCR, c-dma_ch);
+ if (dma_omap1())
+ c-plat-dma_write(d-ccr 16, CCR2, c-dma_ch);
+ if (d-dir == DMA_DEV_TO_MEM) {
c-plat-dma_write(d-dev_addr, CSSA, c-dma_ch);
c-plat-dma_write(0, CSEI, c-dma_ch);
c-plat-dma_write(d-fi, CSFI, c-dma_ch);
} else {
- val = c-plat-dma_read(CCR, c-dma_ch);
- val = ~(0x03 12 | 0x03 14);
- val |= OMAP_DMA_AMODE_CONSTANT 14;
- val |= OMAP_DMA_AMODE_POST_INC 12;
- c-plat-dma_write(val, CCR, c-dma_ch);
-
c-plat-dma_write(d-dev_addr, CDSA, c-dma_ch);
c-plat-dma_write(0, CDEI, c-dma_ch);
c-plat-dma_write(d-fi, CDFI, c-dma_ch);
@@ -264,47 +254,6 @@ static void omap_dma_start_desc(struct omap_chan *c)
c-plat-dma_write(d-csdp, CSDP, c-dma_ch);
- if (dma_omap1()) {
- val = c-plat-dma_read(CCR, c-dma_ch);
- val = ~(1 5);
- if (d-sync_mode == OMAP_DMA_SYNC_FRAME)
- val |= 1 5;
- c-plat-dma_write(val, CCR, c-dma_ch);
-
- val = c-plat-dma_read(CCR2, c-dma_ch);
- val = ~(1 2);
- if (d-sync_mode == OMAP_DMA_SYNC_BLOCK)
- val |= 1 2;
- c-plat-dma_write(val, CCR2, c-dma_ch);
- }
-
- if (dma_omap2plus() c-dma_sig) {
- val = c-plat-dma_read(CCR, c-dma_ch);
-
- /* DMA_SYNCHRO_CONTROL_UPPER depends on the channel number */
- val = ~(1 24 | 1 23 | 3 19 | 1 18 | 1 5 | 0x1f);
- val |= (c-dma_sig ~0x1f) 14;
- val |= c-dma_sig 0x1f;
-
- if (d-sync_mode OMAP_DMA_SYNC_FRAME)
- val |= 1 5;
-
- if (d-sync_mode OMAP_DMA_SYNC_BLOCK)
- val |= 1 18;
-
- switch (d-sync_type) {
- case OMAP_DMA_DST_SYNC_PREFETCH:/* dest synch */
- val |= 1 23; /* Prefetch */
- break;
- case 0:
- break;
- default:
- val |= 1 24; /* source synch */
- break;
- }
- c-plat-dma_write(val, CCR, c-dma_ch);
- }
-
omap_dma_start_sg(c, d, 0);
}
@@ -543,19 +492,17 @@ static struct dma_async_tx_descriptor
*omap_dma_prep_slave_sg(
struct scatterlist *sgent;
struct omap_desc *d;
dma_addr_t dev_addr;
- unsigned i, j = 0, es, en, frame_bytes, sync_type;
+ unsigned i, j = 0, es, en, frame_bytes;
u32 burst;
if (dir == DMA_DEV_TO_MEM) {
dev_addr = c-cfg.src_addr;
dev_width = c-cfg.src_addr_width;
burst = c-cfg.src_maxburst;
- sync_type = OMAP_DMA_SRC_SYNC;
} else if (dir == DMA_MEM_TO_DEV) {
dev_addr = c-cfg.dst_addr;
dev_width = c-cfg.dst_addr_width;
burst = c-cfg.dst_maxburst;
- sync_type = OMAP_DMA_DST_SYNC;
} else {
dev_err(chan-device-dev, %s: bad direction?\n, __func__);
return NULL;
@@ -584,12 +531,20 @@ static struct
