Re: [PATCH V2 0/3] OMAPDSS: DISPC: Enable predecimation for DMA and VRFB

2012-03-27 Thread Tomi Valkeinen
On Wed, 2012-03-21 at 15:21 +0530, Chandrabhanu Mahapatra wrote:
 Hi everyone,
 the following patch set directs to enable predecimation for DMA and VRFB
 which consists of two pacthes.
 
 The first patch is based on code written by Lajos Molnar la...@ti.com in
 Android Kernel, which updates the code with predecimation logic thereby
 increasing the downscaling ability of the DISPC module.
 In version 2 patch description has been modified include reason for maximum
 predecimation limit of 16.

You should have the version changes separately, so that they are easy to
see. For example, a bullet list after the intro text. And you miss to
mention that this patch set adds a new patch to the series.

 Tomi



signature.asc
Description: This is a digitally signed message part


[PATCH V2 0/3] OMAPDSS: DISPC: Enable predecimation for DMA and VRFB

2012-03-21 Thread Chandrabhanu Mahapatra
Hi everyone,
the following patch set directs to enable predecimation for DMA and VRFB
which consists of two pacthes.

The first patch is based on code written by Lajos Molnar la...@ti.com in
Android Kernel, which updates the code with predecimation logic thereby
increasing the downscaling ability of the DISPC module.
In version 2 patch description has been modified include reason for maximum
predecimation limit of 16.

The second patch is based on code written by Ville Syrjälä
ville.syrj...@nokia.com which aims to avoid synclost errors occurring
in OMAP3 due to some undocumented horizontal position and timing related
limitations which I faced during testing of the previous patch.
In version 2 the pcd factor has been replaced lclk / pclk to support HDMI and
tv output as pointed out by Ville Syrjälä.

The third patch corrects the usage of dispc fclk in scaling checks by
replacing it with dispc_core_clk as per suggestions of Ville Syrjälä.

I have tested these patches successfully on OMAP2, OMAP3 AND OMAP4 on the
mainline kernel v3.3. Horizontal and vertical predecimation worked fine
but skewed images were seen on OMAP2 and OMAP3 on HDMI tv during horizontal
predecimation which will be addressed in the future patches.

All your comments and suggestions are welcome.

Regards,
Chandrabhanu

Chandrabhanu Mahapatra (3):
  OMAPDSS: DISPC: Enable predecimation
  OMAPDSS: DISPC: Handle synclost errors in OMAP3
  OMAPDSS: DISPC: Correct DISPC functional clock usage

 drivers/video/omap2/dss/dispc.c |  360 +++
 1 files changed, 254 insertions(+), 106 deletions(-)

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html