Re: [PATCH v2 01/10] ARM: OMAP2+: add needs_vmmc to hsmmc_info

2013-06-12 Thread Tony Lindgren 
* Balaji T K balaj...@ti.com [130606 12:20]:
 Add needs_vmmc and needs_vmmc_aux to indicate whether regulator is
 applicable so that omap_hsmmc can handle deferred probe error
 properly for regulators.
 Remove the assumption that vmmc_aux regulator to be available only if vmmc is
 present. Platforms can have fixed-always-ON regulator for vmmc and/or vmmc_aux
 in such cases regulator needed not be specified in board file.

Looks good to me, I suggest you resend this again a bit later once the
other changes are merged so we can avoid a dependency between 
arch/arm/mach-omap2
and MMC changes.

Regards,

Tony
 
 Signed-off-by: Balaji T K balaj...@ti.com
 ---
  arch/arm/mach-omap2/board-2430sdp.c  |1 +
  arch/arm/mach-omap2/board-3430sdp.c  |3 +++
  arch/arm/mach-omap2/board-cm-t35.c   |2 ++
  arch/arm/mach-omap2/board-devkit8000.c   |1 +
  arch/arm/mach-omap2/board-igep0020.c |3 +++
  arch/arm/mach-omap2/board-ldp.c  |1 +
  arch/arm/mach-omap2/board-omap3beagle.c  |2 ++
  arch/arm/mach-omap2/board-omap3evm.c |3 +++
  arch/arm/mach-omap2/board-omap3logic.c   |1 +
  arch/arm/mach-omap2/board-omap3pandora.c |3 +++
  arch/arm/mach-omap2/board-omap3stalker.c |2 ++
  arch/arm/mach-omap2/board-omap3touchbook.c   |2 ++
  arch/arm/mach-omap2/board-overo.c|1 +
  arch/arm/mach-omap2/board-rm680.c|1 +
  arch/arm/mach-omap2/board-rx51-peripherals.c |3 +++
  arch/arm/mach-omap2/board-zoom-peripherals.c |4 
  arch/arm/mach-omap2/hsmmc.c  |2 ++
  arch/arm/mach-omap2/hsmmc.h  |2 ++
  include/linux/platform_data/mmc-omap.h   |2 ++
  19 files changed, 39 insertions(+), 0 deletions(-)
 
 diff --git a/arch/arm/mach-omap2/board-2430sdp.c 
 b/arch/arm/mach-omap2/board-2430sdp.c
 index 244d8a5..eba8593 100644
 --- a/arch/arm/mach-omap2/board-2430sdp.c
 +++ b/arch/arm/mach-omap2/board-2430sdp.c
 @@ -211,6 +211,7 @@ static struct omap2_hsmmc_info mmc[] __initdata = {
   .gpio_cd= -EINVAL,
   .gpio_wp= -EINVAL,
   .ext_clock  = 1,
 + .needs_vmmc = 1,
   },
   {}  /* Terminator */
  };
 diff --git a/arch/arm/mach-omap2/board-3430sdp.c 
 b/arch/arm/mach-omap2/board-3430sdp.c
 index 23b004a..9438c54 100644
 --- a/arch/arm/mach-omap2/board-3430sdp.c
 +++ b/arch/arm/mach-omap2/board-3430sdp.c
 @@ -184,12 +184,15 @@ static struct omap2_hsmmc_info mmc[] = {
   .caps   = MMC_CAP_4_BIT_DATA | MMC_CAP_8_BIT_DATA,
   .gpio_wp= 4,
   .deferred   = true,
 + .needs_vmmc = 1,
 + .needs_vmmc_aux = 1,
   },
   {
   .mmc= 2,
   .caps   = MMC_CAP_4_BIT_DATA | MMC_CAP_8_BIT_DATA,
   .gpio_wp= 7,
   .deferred   = true,
 + .needs_vmmc = 1,
   },
   {}  /* Terminator */
  };
 diff --git a/arch/arm/mach-omap2/board-cm-t35.c 
 b/arch/arm/mach-omap2/board-cm-t35.c
 index ee6218c..207ea13 100644
 --- a/arch/arm/mach-omap2/board-cm-t35.c
 +++ b/arch/arm/mach-omap2/board-cm-t35.c
 @@ -364,6 +364,8 @@ static struct omap2_hsmmc_info mmc[] = {
   .gpio_cd= -EINVAL,
   .gpio_wp= -EINVAL,
   .deferred   = true,
 + .needs_vmmc = 1,
 + .needs_vmmc_aux = 1,
   },
   {
   .mmc= 2,
 diff --git a/arch/arm/mach-omap2/board-devkit8000.c 
 b/arch/arm/mach-omap2/board-devkit8000.c
 index 5764205..63fd8827 100644
 --- a/arch/arm/mach-omap2/board-devkit8000.c
 +++ b/arch/arm/mach-omap2/board-devkit8000.c
 @@ -99,6 +99,7 @@ static struct omap2_hsmmc_info mmc[] = {
   .caps   = MMC_CAP_4_BIT_DATA | MMC_CAP_8_BIT_DATA,
   .gpio_wp= 29,
   .deferred   = true,
 + .needs_vmmc = 1,
   },
   {}  /* Terminator */
  };
 diff --git a/arch/arm/mach-omap2/board-igep0020.c 
 b/arch/arm/mach-omap2/board-igep0020.c
 index b54562d..a2a8a80 100644
 --- a/arch/arm/mach-omap2/board-igep0020.c
 +++ b/arch/arm/mach-omap2/board-igep0020.c
 @@ -284,6 +284,7 @@ static struct omap2_hsmmc_info mmc[] = {
   .gpio_cd= -EINVAL,
   .gpio_wp= -EINVAL,
   .deferred   = true,
 + .needs_vmmc = 1,
   },
  #if defined(CONFIG_LIBERTAS_SDIO) || defined(CONFIG_LIBERTAS_SDIO_MODULE)
   {
 @@ -291,6 +292,8 @@ static struct omap2_hsmmc_info mmc[] = {
   .caps   = MMC_CAP_4_BIT_DATA,
   .gpio_cd= -EINVAL,
   .gpio_wp= -EINVAL,
 + .needs_vmmc = 1,
 + .needs_vmmc_aux = 1,
   },
  #endif
   {}  /* Terminator */
 diff --git a/arch/arm/mach-omap2/board-ldp.c

Re: [PATCH v2 01/10] ARM: OMAP2+: add needs_vmmc to hsmmc_info

2013-06-12 Thread Balaji T K 

On Wednesday 12 June 2013 07:54 PM, Tony Lindgren wrote:

* Balaji T K balaj...@ti.com [130606 12:20]:

Add needs_vmmc and needs_vmmc_aux to indicate whether regulator is
applicable so that omap_hsmmc can handle deferred probe error
properly for regulators.
Remove the assumption that vmmc_aux regulator to be available only if vmmc is
present. Platforms can have fixed-always-ON regulator for vmmc and/or vmmc_aux
in such cases regulator needed not be specified in board file.


Looks good to me, I suggest you resend this again a bit later once the
other changes are merged so we can avoid a dependency between 
arch/arm/mach-omap2
and MMC changes.



Ok, will separate the board changes and send the rest via mmc tree


Regards,

Tony


Signed-off-by: Balaji T K balaj...@ti.com
---
  arch/arm/mach-omap2/board-2430sdp.c  |1 +
  arch/arm/mach-omap2/board-3430sdp.c  |3 +++
  arch/arm/mach-omap2/board-cm-t35.c   |2 ++
  arch/arm/mach-omap2/board-devkit8000.c   |1 +
  arch/arm/mach-omap2/board-igep0020.c |3 +++
  arch/arm/mach-omap2/board-ldp.c  |1 +
  arch/arm/mach-omap2/board-omap3beagle.c  |2 ++
  arch/arm/mach-omap2/board-omap3evm.c |3 +++
  arch/arm/mach-omap2/board-omap3logic.c   |1 +
  arch/arm/mach-omap2/board-omap3pandora.c |3 +++
  arch/arm/mach-omap2/board-omap3stalker.c |2 ++
  arch/arm/mach-omap2/board-omap3touchbook.c   |2 ++
  arch/arm/mach-omap2/board-overo.c|1 +
  arch/arm/mach-omap2/board-rm680.c|1 +
  arch/arm/mach-omap2/board-rx51-peripherals.c |3 +++
  arch/arm/mach-omap2/board-zoom-peripherals.c |4 
  arch/arm/mach-omap2/hsmmc.c  |2 ++
  arch/arm/mach-omap2/hsmmc.h  |2 ++
  include/linux/platform_data/mmc-omap.h   |2 ++
  19 files changed, 39 insertions(+), 0 deletions(-)


--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 01/10] ARM: OMAP2+: add needs_vmmc to hsmmc_info

2013-06-06 Thread Balaji T K 
Add needs_vmmc and needs_vmmc_aux to indicate whether regulator is
applicable so that omap_hsmmc can handle deferred probe error
properly for regulators.
Remove the assumption that vmmc_aux regulator to be available only if vmmc is
present. Platforms can have fixed-always-ON regulator for vmmc and/or vmmc_aux
in such cases regulator needed not be specified in board file.

Signed-off-by: Balaji T K balaj...@ti.com
---
 arch/arm/mach-omap2/board-2430sdp.c  |1 +
 arch/arm/mach-omap2/board-3430sdp.c  |3 +++
 arch/arm/mach-omap2/board-cm-t35.c   |2 ++
 arch/arm/mach-omap2/board-devkit8000.c   |1 +
 arch/arm/mach-omap2/board-igep0020.c |3 +++
 arch/arm/mach-omap2/board-ldp.c  |1 +
 arch/arm/mach-omap2/board-omap3beagle.c  |2 ++
 arch/arm/mach-omap2/board-omap3evm.c |3 +++
 arch/arm/mach-omap2/board-omap3logic.c   |1 +
 arch/arm/mach-omap2/board-omap3pandora.c |3 +++
 arch/arm/mach-omap2/board-omap3stalker.c |2 ++
 arch/arm/mach-omap2/board-omap3touchbook.c   |2 ++
 arch/arm/mach-omap2/board-overo.c|1 +
 arch/arm/mach-omap2/board-rm680.c|1 +
 arch/arm/mach-omap2/board-rx51-peripherals.c |3 +++
 arch/arm/mach-omap2/board-zoom-peripherals.c |4 
 arch/arm/mach-omap2/hsmmc.c  |2 ++
 arch/arm/mach-omap2/hsmmc.h  |2 ++
 include/linux/platform_data/mmc-omap.h   |2 ++
 19 files changed, 39 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/board-2430sdp.c 
b/arch/arm/mach-omap2/board-2430sdp.c
index 244d8a5..eba8593 100644
--- a/arch/arm/mach-omap2/board-2430sdp.c
+++ b/arch/arm/mach-omap2/board-2430sdp.c
@@ -211,6 +211,7 @@ static struct omap2_hsmmc_info mmc[] __initdata = {
.gpio_cd= -EINVAL,
.gpio_wp= -EINVAL,
.ext_clock  = 1,
+   .needs_vmmc = 1,
},
{}  /* Terminator */
 };
diff --git a/arch/arm/mach-omap2/board-3430sdp.c 
b/arch/arm/mach-omap2/board-3430sdp.c
index 23b004a..9438c54 100644
--- a/arch/arm/mach-omap2/board-3430sdp.c
+++ b/arch/arm/mach-omap2/board-3430sdp.c
@@ -184,12 +184,15 @@ static struct omap2_hsmmc_info mmc[] = {
.caps   = MMC_CAP_4_BIT_DATA | MMC_CAP_8_BIT_DATA,
.gpio_wp= 4,
.deferred   = true,
+   .needs_vmmc = 1,
+   .needs_vmmc_aux = 1,
},
{
.mmc= 2,
.caps   = MMC_CAP_4_BIT_DATA | MMC_CAP_8_BIT_DATA,
.gpio_wp= 7,
.deferred   = true,
+   .needs_vmmc = 1,
},
{}  /* Terminator */
 };
diff --git a/arch/arm/mach-omap2/board-cm-t35.c 
b/arch/arm/mach-omap2/board-cm-t35.c
index ee6218c..207ea13 100644
--- a/arch/arm/mach-omap2/board-cm-t35.c
+++ b/arch/arm/mach-omap2/board-cm-t35.c
@@ -364,6 +364,8 @@ static struct omap2_hsmmc_info mmc[] = {
.gpio_cd= -EINVAL,
.gpio_wp= -EINVAL,
.deferred   = true,
+   .needs_vmmc = 1,
+   .needs_vmmc_aux = 1,
},
{
.mmc= 2,
diff --git a/arch/arm/mach-omap2/board-devkit8000.c 
b/arch/arm/mach-omap2/board-devkit8000.c
index 5764205..63fd8827 100644
--- a/arch/arm/mach-omap2/board-devkit8000.c
+++ b/arch/arm/mach-omap2/board-devkit8000.c
@@ -99,6 +99,7 @@ static struct omap2_hsmmc_info mmc[] = {
.caps   = MMC_CAP_4_BIT_DATA | MMC_CAP_8_BIT_DATA,
.gpio_wp= 29,
.deferred   = true,
+   .needs_vmmc = 1,
},
{}  /* Terminator */
 };
diff --git a/arch/arm/mach-omap2/board-igep0020.c 
b/arch/arm/mach-omap2/board-igep0020.c
index b54562d..a2a8a80 100644
--- a/arch/arm/mach-omap2/board-igep0020.c
+++ b/arch/arm/mach-omap2/board-igep0020.c
@@ -284,6 +284,7 @@ static struct omap2_hsmmc_info mmc[] = {
.gpio_cd= -EINVAL,
.gpio_wp= -EINVAL,
.deferred   = true,
+   .needs_vmmc = 1,
},
 #if defined(CONFIG_LIBERTAS_SDIO) || defined(CONFIG_LIBERTAS_SDIO_MODULE)
{
@@ -291,6 +292,8 @@ static struct omap2_hsmmc_info mmc[] = {
.caps   = MMC_CAP_4_BIT_DATA,
.gpio_cd= -EINVAL,
.gpio_wp= -EINVAL,
+   .needs_vmmc = 1,
+   .needs_vmmc_aux = 1,
},
 #endif
{}  /* Terminator */
diff --git a/arch/arm/mach-omap2/board-ldp.c b/arch/arm/mach-omap2/board-ldp.c
index d0d17bc..62c1a2d 100644
--- a/arch/arm/mach-omap2/board-ldp.c
+++ b/arch/arm/mach-omap2/board-ldp.c
@@ -315,6 +315,7 @@ static struct omap2_hsmmc_info mmc[] __initdata = {
.caps   =