Re: [PATCH v3] OMAP: NAND: Fix static declaration warning

[Artem Bityutskiy]

On Wed, 2010-10-06 at 03:26 +0530, G, Manjunath Kondaiah wrote:
 This patch fixes sparse warning for static declaration of variable use_dma
 
 drivers/mtd/nand/omap2.c:114:11: warning: symbol 'use_dma' was not declared. 
 Should it be static?
 
 Signed-off-by: G, Manjunath Kondaiah manj...@ti.com
 Cc: linux-arm-ker...@lists.infradead.org
 Cc: linux-...@lists.infradead.org
 Cc: Tony Lindgren t...@atomide.com
 Cc: Nishanth Menon n...@ti.com

I've pushed this patch to my l2-mtd-2.6.git.

-- 
Best Regards,
Artem Bityutskiy (Битюцкий Артём)

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3] OMAP: NAND: Fix static declaration warning

[Vimal Singh]

On Wed, Oct 6, 2010 at 3:26 AM, G, Manjunath Kondaiah manj...@ti.com wrote:
 This patch fixes sparse warning for static declaration of variable use_dma

 drivers/mtd/nand/omap2.c:114:11: warning: symbol 'use_dma' was not declared. 
 Should it be static?

 Signed-off-by: G, Manjunath Kondaiah manj...@ti.com
 Cc: linux-arm-ker...@lists.infradead.org
 Cc: linux-...@lists.infradead.org
 Cc: Tony Lindgren t...@atomide.com
 Cc: Nishanth Menon n...@ti.com
 ---
 Changes since v1:
  - no logical changes, patch seperated from series based Tony's suggestion.

  drivers/mtd/nand/omap2.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

 diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
 index 133d515..439e80d 100644
 --- a/drivers/mtd/nand/omap2.c
 +++ b/drivers/mtd/nand/omap2.c
 @@ -111,11 +111,11 @@ static int use_dma = 1;
  module_param(use_dma, bool, 0);
  MODULE_PARM_DESC(use_dma, enable/disable use of DMA);
  #else
 -const int use_dma;
 +static const int use_dma;
  #endif
  #else
  const int use_prefetch;
 -const int use_dma;
 +static const int use_dma;

I did not understand, why did it not pointed same error for 'const int
use_prefetch'?

-- 
Regards,
Vimal Singh
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v3] OMAP: NAND: Fix static declaration warning

[G, Manjunath Kondaiah]

This patch fixes sparse warning for static declaration of variable use_dma

drivers/mtd/nand/omap2.c:114:11: warning: symbol 'use_dma' was not declared. 
Should it be static?

Signed-off-by: G, Manjunath Kondaiah manj...@ti.com
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-...@lists.infradead.org
Cc: Tony Lindgren t...@atomide.com
Cc: Nishanth Menon n...@ti.com
---
Changes since v1:
 - no logical changes, patch seperated from series based Tony's suggestion.

 drivers/mtd/nand/omap2.c |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index 133d515..439e80d 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -111,11 +111,11 @@ static int use_dma = 1;
 module_param(use_dma, bool, 0);
 MODULE_PARM_DESC(use_dma, enable/disable use of DMA);
 #else
-const int use_dma;
+static const int use_dma;
 #endif
 #else
 const int use_prefetch;
-const int use_dma;
+static const int use_dma;
 #endif
 
 struct omap_nand_info {
-- 
1.7.0.4

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html