[PATCH v3 02/13] gpio/omap: fix wakeup_en register update in _set_gpio_wakeup()

2012-03-07 Thread Tarun Kanti DebBarma
There are two ways through which wakeup_en register can be programmed
using gpiolib APIs as shown below. It is seen that in the second case
in _set_gpio_wakeup(), even though bank-suspend_wakeup is updated
correctly, its value is not programmed in wakeup_en register. Fix this.

chip.irq_set_type()-gpio_irq_type()-_set_gpio_triggering()-set_gpio_trigger()
chip.irq_set_wake()-gpio_wake_enable()-_set_gpio_wakeup()

Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com
---
 drivers/gpio/gpio-omap.c |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index c9369d2..895df7f 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -504,6 +504,7 @@ static int _set_gpio_wakeup(struct gpio_bank *bank, int 
gpio, int enable)
else
bank-suspend_wakeup = ~gpio_bit;
 
+   __raw_writel(bank-suspend_wakeup, bank-base + bank-regs-wkup_en);
spin_unlock_irqrestore(bank-lock, flags);
 
return 0;
-- 
1.7.0.4

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v3 02/13] gpio/omap: fix wakeup_en register update in _set_gpio_wakeup()

2012-03-07 Thread Santosh Shilimkar
On Wednesday 07 March 2012 12:15 PM, Tarun Kanti DebBarma wrote:
 There are two ways through which wakeup_en register can be programmed
 using gpiolib APIs as shown below. It is seen that in the second case
 in _set_gpio_wakeup(), even though bank-suspend_wakeup is updated
 correctly, its value is not programmed in wakeup_en register. Fix this.
 
 chip.irq_set_type()-gpio_irq_type()-_set_gpio_triggering()-set_gpio_trigger()
 chip.irq_set_wake()-gpio_wake_enable()-_set_gpio_wakeup()
 
 Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com
 ---
Looks good.
Reviewed-by: Santosh Shilimkar santosh.shilim...@ti.com

Regards
Santosh
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html