Re: [PATCH v4 0/5] Adding MMC Support on OMAP4430 SDP
- Original Message - From: Tony Lindgren t...@atomide.com To: kishore kadiyala kishore.kadiy...@ti.com Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; madhu...@ti.com; jarkko.lavi...@nokia.com; r...@arm.linux.org.uk; p...@pwsan.com; santosh.shilim...@ti.com Sent: Thursday, May 20, 2010 6:28 AM Subject: Re: [PATCH v4 0/5] Adding MMC Support on OMAP4430 SDP * kishore kadiyala kishore.kadiy...@ti.com [100519 08:39]: FYI, the MMC on omap4 is not quite there yet at least on my board. It mostly detects the card with omap_4430sdp_defconfig, but fails always unless CONFIG_RTC_DRV_TWL92330=y.. This is without CONFIG_SMP as it oopses. Hope you are referring CONFIG_RTC_DRV_TWL92330 to omap3_defconfig and not to omap_4430sdp_defconfig. Sorry I meant CONFIG_RTC_DRV_TWL4030 in the omap_4430sdp_defconfig. If you take that out, MMC is never detected. Even disabling CONFIG_RTC_DRV_TWL4030 in omap_4430sdp_defconfig, card gets detected always on booting up. With omap_4430sdp_defconfig , I've tested on 4430SDP and Blaze and always Cards on MMC1 MMC2 gets detected once bootedup. Are you able to actually mount root on the MMC with let's say current linux-omap master branch? Yes I booted with file system mounted on card present on MMC1, and I can see cards getting detected properly and also filesystem gettting mounted. Here are the boot logs with CONFIG_RTC_DRV_TWL4030 disabled and filesystem on ext2 partition of card present on MMC1 http://pastebin.mozilla.org/726228 Regards, Kishore Also MMC is never detected with omap3_defconfig. With omap3_defconfig + disabling CONFIG_OMAP_RESET_CLOCKS, I've tested on 4430SDP and Blaze and always Cards on MMC1 MMC2 gets detected on bootup. That should be fixed so CONFIG_OMAP_RESET_CLOCKS works. Otherwise we're relying on some random clocks being enabled. I've piled all these patches into linux-omap master branch for easy testing. Let me know if I missed some patch. Following is the commit ID :1674c0ceabfb7726246989874bb4da7bcb55ea89 used on LO master branch for testing. All the patches were merged. OK, thanks for checking that. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v4 0/5] Adding MMC Support on OMAP4430 SDP
-Original Message- From: Tony Lindgren [mailto:t...@atomide.com] Sent: Tuesday, May 18, 2010 7:09 PM To: kishore kadiyala Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; madhu...@ti.com; jarkko.lavi...@nokia.com; r...@arm.linux.org.uk; p...@pwsan.com; santosh.shilim...@ti.com Subject: Re: [PATCH v4 0/5] Adding MMC Support on OMAP4430 SDP * Tony Lindgren t...@atomide.com [100517 19:45]: Hi, * kishore kadiyala kishore.kadiy...@ti.com [100515 11:15]: Adding MMC1 and MMC2 controllers support for OMAP4 V4: - Rebased to for_next branch[LO]. - The first 3 patches [1,2,3] in the series are Minimal set of changes with which MMC1/MMC2 works [No card detect for MMC1]on OMAP4 but with dependencies on following patches [Not in for_next branch] [1] I2c patches a)https://patchwork.kernel.org/patch/98937/ b)https://patchwork.kernel.org/patch/98936/ c)https://patchwork.kernel.org/patch/98939/ d)https://patchwork.kernel.org/patch/79735/ I've taken the updated versions of the I2C patches, and fixed them not to break omap3_defconfig. [2] Regulator pacth a)https://patchwork.kernel.org/patch/94054/ [3] hsmmc-clk patch a)https://patchwork.kernel.org/patch/96821/ I've picked up these too. - The patches 4,5 adds card detect feature for MMC1 I only took 1 - 3 out of the MMC patches, it's too late to start changing the other stuff. I've reposted the whole series for a quick review. FYI, the MMC on omap4 is not quite there yet at least on my board. It mostly detects the card with omap_4430sdp_defconfig, but fails always unless CONFIG_RTC_DRV_TWL92330=y.. This is without CONFIG_SMP as it oopses. I did try the omap_4430sdp_defconfig on the master branch. On my SDP the MMC cards were detected fine without any dependency on CONFIG_RTC_DRV_TWL92330. Regards, Madhu Also MMC is never detected with omap3_defconfig. Santosh Kishore, maybe take a look at that, otherwise it looks like we still don't have a very usable support for omap4. I've piled all these patches into linux-omap master branch for easy testing. Let me know if I missed some patch. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 0/5] Adding MMC Support on OMAP4430 SDP
- Original Message - From: Tony Lindgren t...@atomide.com To: kishore kadiyala kishore.kadiy...@ti.com Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; madhu...@ti.com; jarkko.lavi...@nokia.com; r...@arm.linux.org.uk; p...@pwsan.com; santosh.shilim...@ti.com Sent: Wednesday, May 19, 2010 5:39 AM Subject: Re: [PATCH v4 0/5] Adding MMC Support on OMAP4430 SDP * Tony Lindgren t...@atomide.com [100517 19:45]: Hi, * kishore kadiyala kishore.kadiy...@ti.com [100515 11:15]: Adding MMC1 and MMC2 controllers support for OMAP4 V4: - Rebased to for_next branch[LO]. - The first 3 patches [1,2,3] in the series are Minimal set of changes with which MMC1/MMC2 works [No card detect for MMC1]on OMAP4 but with dependencies on following patches [Not in for_next branch] [1] I2c patches a)https://patchwork.kernel.org/patch/98937/ b)https://patchwork.kernel.org/patch/98936/ c)https://patchwork.kernel.org/patch/98939/ d)https://patchwork.kernel.org/patch/79735/ I've taken the updated versions of the I2C patches, and fixed them not to break omap3_defconfig. [2] Regulator pacth a)https://patchwork.kernel.org/patch/94054/ [3] hsmmc-clk patch a)https://patchwork.kernel.org/patch/96821/ I've picked up these too. - The patches 4,5 adds card detect feature for MMC1 I only took 1 - 3 out of the MMC patches, it's too late to start changing the other stuff. I've reposted the whole series for a quick review. FYI, the MMC on omap4 is not quite there yet at least on my board. It mostly detects the card with omap_4430sdp_defconfig, but fails always unless CONFIG_RTC_DRV_TWL92330=y.. This is without CONFIG_SMP as it oopses. Hope you are referring CONFIG_RTC_DRV_TWL92330 to omap3_defconfig and not to omap_4430sdp_defconfig. With omap_4430sdp_defconfig , I've tested on 4430SDP and Blaze and always Cards on MMC1 MMC2 gets detected once bootedup. Also MMC is never detected with omap3_defconfig. With omap3_defconfig + disabling CONFIG_OMAP_RESET_CLOCKS, I've tested on 4430SDP and Blaze and always Cards on MMC1 MMC2 gets detected on bootup. Santosh Kishore, maybe take a look at that, otherwise it looks like we still don't have a very usable support for omap4. I've piled all these patches into linux-omap master branch for easy testing. Let me know if I missed some patch. Following is the commit ID :1674c0ceabfb7726246989874bb4da7bcb55ea89 used on LO master branch for testing. All the patches were merged. Regards, Kishore Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 0/5] Adding MMC Support on OMAP4430 SDP
* kishore kadiyala kishore.kadiy...@ti.com [100519 08:39]: FYI, the MMC on omap4 is not quite there yet at least on my board. It mostly detects the card with omap_4430sdp_defconfig, but fails always unless CONFIG_RTC_DRV_TWL92330=y.. This is without CONFIG_SMP as it oopses. Hope you are referring CONFIG_RTC_DRV_TWL92330 to omap3_defconfig and not to omap_4430sdp_defconfig. Sorry I meant CONFIG_RTC_DRV_TWL4030 in the omap_4430sdp_defconfig. If you take that out, MMC is never detected. With omap_4430sdp_defconfig , I've tested on 4430SDP and Blaze and always Cards on MMC1 MMC2 gets detected once bootedup. Are you able to actually mount root on the MMC with let's say current linux-omap master branch? Also MMC is never detected with omap3_defconfig. With omap3_defconfig + disabling CONFIG_OMAP_RESET_CLOCKS, I've tested on 4430SDP and Blaze and always Cards on MMC1 MMC2 gets detected on bootup. That should be fixed so CONFIG_OMAP_RESET_CLOCKS works. Otherwise we're relying on some random clocks being enabled. I've piled all these patches into linux-omap master branch for easy testing. Let me know if I missed some patch. Following is the commit ID :1674c0ceabfb7726246989874bb4da7bcb55ea89 used on LO master branch for testing. All the patches were merged. OK, thanks for checking that. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v4 0/5] Adding MMC Support on OMAP4430 SDP
-Original Message- From: Tony Lindgren [mailto:t...@atomide.com] Sent: Thursday, May 20, 2010 6:28 AM To: Kadiyala, Kishore Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; Chikkature Rajashekar, Madhusudhan; jarkko.lavi...@nokia.com; r...@arm.linux.org.uk; p...@pwsan.com; Shilimkar, Santosh Subject: Re: [PATCH v4 0/5] Adding MMC Support on OMAP4430 SDP * kishore kadiyala kishore.kadiy...@ti.com [100519 08:39]: FYI, the MMC on omap4 is not quite there yet at least on my board. It mostly detects the card with omap_4430sdp_defconfig, but fails always unless CONFIG_RTC_DRV_TWL92330=y.. This is without CONFIG_SMP as it oopses. Hope you are referring CONFIG_RTC_DRV_TWL92330 to omap3_defconfig and not to omap_4430sdp_defconfig. Sorry I meant CONFIG_RTC_DRV_TWL4030 in the omap_4430sdp_defconfig. If you take that out, MMC is never detected. With omap_4430sdp_defconfig , I've tested on 4430SDP and Blaze and always Cards on MMC1 MMC2 gets detected once bootedup. Are you able to actually mount root on the MMC with let's say current linux-omap master branch? Also MMC is never detected with omap3_defconfig. With omap3_defconfig + disabling CONFIG_OMAP_RESET_CLOCKS, I've tested on 4430SDP and Blaze and always Cards on MMC1 MMC2 gets detected on bootup. That should be fixed so CONFIG_OMAP_RESET_CLOCKS works. Otherwise we're relying on some random clocks being enabled. The fix for this is already in Paul's queue now. https://patchwork.kernel.org/patch/101094/ Regards, Santosh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 0/5] Adding MMC Support on OMAP4430 SDP
* Tony Lindgren t...@atomide.com [100517 19:45]: Hi, * kishore kadiyala kishore.kadiy...@ti.com [100515 11:15]: Adding MMC1 and MMC2 controllers support for OMAP4 V4: - Rebased to for_next branch[LO]. - The first 3 patches [1,2,3] in the series are Minimal set of changes with which MMC1/MMC2 works [No card detect for MMC1]on OMAP4 but with dependencies on following patches [Not in for_next branch] [1] I2c patches a)https://patchwork.kernel.org/patch/98937/ b)https://patchwork.kernel.org/patch/98936/ c)https://patchwork.kernel.org/patch/98939/ d)https://patchwork.kernel.org/patch/79735/ I've taken the updated versions of the I2C patches, and fixed them not to break omap3_defconfig. [2] Regulator pacth a)https://patchwork.kernel.org/patch/94054/ [3] hsmmc-clk patch a)https://patchwork.kernel.org/patch/96821/ I've picked up these too. - The patches 4,5 adds card detect feature for MMC1 I only took 1 - 3 out of the MMC patches, it's too late to start changing the other stuff. I've reposted the whole series for a quick review. FYI, the MMC on omap4 is not quite there yet at least on my board. It mostly detects the card with omap_4430sdp_defconfig, but fails always unless CONFIG_RTC_DRV_TWL92330=y.. This is without CONFIG_SMP as it oopses. Also MMC is never detected with omap3_defconfig. Santosh Kishore, maybe take a look at that, otherwise it looks like we still don't have a very usable support for omap4. I've piled all these patches into linux-omap master branch for easy testing. Let me know if I missed some patch. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 0/5] Adding MMC Support on OMAP4430 SDP
Hi, * kishore kadiyala kishore.kadiy...@ti.com [100515 11:15]: Adding MMC1 and MMC2 controllers support for OMAP4 V4: - Rebased to for_next branch[LO]. - The first 3 patches [1,2,3] in the series are Minimal set of changes with which MMC1/MMC2 works [No card detect for MMC1]on OMAP4 but with dependencies on following patches [Not in for_next branch] [1] I2c patches a)https://patchwork.kernel.org/patch/98937/ b)https://patchwork.kernel.org/patch/98936/ c)https://patchwork.kernel.org/patch/98939/ d)https://patchwork.kernel.org/patch/79735/ I've taken the updated versions of the I2C patches, and fixed them not to break omap3_defconfig. [2] Regulator pacth a)https://patchwork.kernel.org/patch/94054/ [3] hsmmc-clk patch a)https://patchwork.kernel.org/patch/96821/ I've picked up these too. - The patches 4,5 adds card detect feature for MMC1 I only took 1 - 3 out of the MMC patches, it's too late to start changing the other stuff. I've reposted the whole series for a quick review. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v4 0/5] Adding MMC Support on OMAP4430 SDP
Adding MMC1 and MMC2 controllers support for OMAP4 V4: - Rebased to for_next branch[LO]. - The first 3 patches [1,2,3] in the series are Minimal set of changes with which MMC1/MMC2 works [No card detect for MMC1]on OMAP4 but with dependencies on following patches [Not in for_next branch] [1] I2c patches a)https://patchwork.kernel.org/patch/98937/ b)https://patchwork.kernel.org/patch/98936/ c)https://patchwork.kernel.org/patch/98939/ d)https://patchwork.kernel.org/patch/79735/ [2] Regulator pacth a)https://patchwork.kernel.org/patch/94054/ [3] hsmmc-clk patch a)https://patchwork.kernel.org/patch/96821/ - The patches 4,5 adds card detect feature for MMC1 - Tested on both OMAP4430 SDP and OMAP3430 SDP [Also with omap_hsmmc.c as Kernel Module]. - Compile tested for rest of omap3 boards using omap3_defconfig. Could any one test on other boards V3: http://www.mail-archive.com/linux-...@vger.kernel.org/msg01908.html V2: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg27612.html V1: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg26858.html Kishore Kadiyala (5): OMAP4 HSMMC :Adding hsmmc support to board file OMAP4 HSMMC :Adding PBIAS Configuration for MMC1 Controller OMAP4 HSMMC :Enable HSMMC support OMAP HSMMC :Adding a flag to determine the card detect type OMAP4 HSMMC :Adding card detect support for MMC1 Controller arch/arm/configs/omap_4430sdp_defconfig | 19 +- arch/arm/mach-omap2/Makefile |3 +- arch/arm/mach-omap2/board-2430sdp.c |2 + arch/arm/mach-omap2/board-3430sdp.c |3 + arch/arm/mach-omap2/board-4430sdp.c | 64 +++-- arch/arm/mach-omap2/board-cm-t35.c |3 + arch/arm/mach-omap2/board-devkit8000.c |2 + arch/arm/mach-omap2/board-igep0020.c |3 + arch/arm/mach-omap2/board-ldp.c |2 + arch/arm/mach-omap2/board-omap3beagle.c |2 + arch/arm/mach-omap2/board-omap3evm.c |2 + arch/arm/mach-omap2/board-omap3pandora.c |4 + arch/arm/mach-omap2/board-omap3touchbook.c |2 + arch/arm/mach-omap2/board-overo.c|3 + arch/arm/mach-omap2/board-rx51-peripherals.c |3 + arch/arm/mach-omap2/board-zoom-peripherals.c |3 + arch/arm/mach-omap2/hsmmc.c | 98 +++--- arch/arm/mach-omap2/hsmmc.h |1 + arch/arm/plat-omap/include/plat/control.h| 20 + arch/arm/plat-omap/include/plat/mmc.h|5 ++ drivers/mfd/twl6030-irq.c| 23 ++ drivers/mmc/host/omap_hsmmc.c| 31 +++-- include/linux/i2c/twl.h | 47 23 files changed, 322 insertions(+), 23 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
