Re: [RFC/RFT PATCH 0/7] gpio: omap: rework and fixes

2015-06-01 Thread Linus Walleij
On Fri, May 22, 2015 at 9:03 PM, Tony Lindgren t...@atomide.com wrote:
 * Grygorii Strashko grygorii.stras...@linaro.org [150522 07:37]:

 Patches 1-5 seem to work for me, patch 6 does not.
 So for patches 1-5, please feel free to add:

 Tested-by: Tony Lindgren t...@atomide.com

OK I take this as an excuse to apply patches 1-5 with
Tony's test tag.

The maintainers can cheer in if they want, I will
anyway take the OMAP maintainers test tag as
a good quality indication.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [RFC/RFT PATCH 0/7] gpio: omap: rework and fixes

2015-06-01 Thread santosh shilimkar

On 6/1/2015 6:15 AM, Linus Walleij wrote:

On Fri, May 22, 2015 at 9:03 PM, Tony Lindgren t...@atomide.com wrote:

* Grygorii Strashko grygorii.stras...@linaro.org [150522 07:37]:



Patches 1-5 seem to work for me, patch 6 does not.
So for patches 1-5, please feel free to add:

Tested-by: Tony Lindgren t...@atomide.com


OK I take this as an excuse to apply patches 1-5 with
Tony's test tag.

The maintainers can cheer in if they want, I will
anyway take the OMAP maintainers test tag as
a good quality indication.


Cheers for patch 1-5 ;-)

Acked-by: Santosh Shilimkar ssant...@kernel.org
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[RFC/RFT PATCH 0/7] gpio: omap: rework and fixes

2015-05-22 Thread Grygorii Strashko
Hi Tony,

As I promised in [1] I've prepared a new series for OMAP GPIO driver.

Patches 1-2 are bug fixes.

Patches 3-6 is attempt (RFC/RFT) to rework OMAP GPIO driver taking into account
that GPIO Chip and GPIO IRQ Chip functionality are mostly orthogonal.

Patch 7 is second attempt (RFC/RFT) to Runtime PM APIs without checking current
GPIO bank's state with BANK_USED() macro.

Based on top of:
 030bbdb Linux 4.1-rc3

Tested on
  dra7-evm, gpiosysfs, GPIO IRQ only

Refs:
[1] gpio: omap: Fix PM runtime issue and remove most BANK_USED macros 
http://www.spinics.net/lists/linux-gpio/msg05308.html
[2] [RFC/RFT PATCH 2/2] gpio: omap: ensure that runtime pm will disable unused 
gpio banks
http://marc.info/?l=linux-gpiom=142567003515626w=2

Grygorii Strashko (7):
  gpio: omap: fix omap_gpio_free to not clean up irq configuration
  gpio: omap: fix error handling in omap_gpio_irq_type
  gpio: omap: rework omap_x_irq_shutdown to touch only irqs specific registers
  gpio: omap: rework omap_gpio_request to touch only gpio specific registers
  gpio: omap: rework omap_gpio_irq_startup to handle current pin state properly
  gpio: omap: clean up omap_gpio_irq_type
  gpio: omap: ensure that runtime pm will disable unused gpio banks

 drivers/gpio/gpio-omap.c | 85 
 1 file changed, 36 insertions(+), 49 deletions(-)

-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [RFC/RFT PATCH 0/7] gpio: omap: rework and fixes

2015-05-22 Thread Tony Lindgren
* Grygorii Strashko grygorii.stras...@linaro.org [150522 07:37]:
 Hi Tony,
 
 As I promised in [1] I've prepared a new series for OMAP GPIO driver.

Great!
 
 Patches 1-2 are bug fixes.
 
 Patches 3-6 is attempt (RFC/RFT) to rework OMAP GPIO driver taking into 
 account
 that GPIO Chip and GPIO IRQ Chip functionality are mostly orthogonal.

Patches 1-5 seem to work for me, patch 6 does not.
So for patches 1-5, please feel free to add:

Tested-by: Tony Lindgren t...@atomide.com
 
 Patch 7 is second attempt (RFC/RFT) to Runtime PM APIs without checking 
 current
 GPIO bank's state with BANK_USED() macro.

Made some comments on patches 6-7 on what I saw.

Regards,

Tony
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html