Re: [RFC 0/5] PM / clock_ops: provide default runtime ops and cleanup users
On Tue, Apr 21, 2015 at 10:56 AM, Rajendra Nayak rna...@codeaurora.org wrote:
Note that the new code always has a dev_pm_domain, while the old code had
it
conditionally on CONFIG_PM.
Right, but since USE_PM_CLK_RUNTIME_OPS is actually a nop with
!CONFIG_PM, we don't really need the checks anymore.
What I mean is that it uses more memory, to store the dev_pm_domain struct.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say programmer or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC 0/5] PM / clock_ops: provide default runtime ops and cleanup users
On Tue, Apr 21, 2015 at 1:25 AM, santosh shilimkar
santosh.shilim...@oracle.com wrote:
On 4/20/2015 4:21 PM, Kevin Hilman wrote:
Rajendra Nayak rna...@codeaurora.org writes:
Most users of PM clocks do the exact same thing in runtime callbacks.
Probably because they were all copied from mach-davinci. ;)
Yep. ;-)
If you're interested in the history, I did some digging last year:
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-March/242352.html
Provide default callbacks and cleanup the existing users
(keystone/davinci/omap1/sh)
Very nice cleanup, Thanks!
Note that the new code always has a dev_pm_domain, while the old code had
it
conditionally on CONFIG_PM.
Right, but since USE_PM_CLK_RUNTIME_OPS is actually a nop with
!CONFIG_PM, we don't really need the checks anymore.
I don't think that matters much, as we seem to be having more and more
systems that rely on CONFIG_PM=y...
For the series:
Reviewed-by: Kevin Hilman khil...@linaro.org
Acked-by: Santosh Shilimkar ssant...@kernel.org
Looks good to me, and works fine on (pre-Clock Domain) r8a7791/koelsch
and r8a7740/armadillo-legacy (with PM Domains, but still relying on the
drivers/sh/pm_runtime.c hack for devices in the C5 always on domain).
This code is no longer used in multiplatform kernels on shmobile boards
with real PM Domains.
Acked-by: Geert Uytterhoeven geert+rene...@glider.be
Thanks,
Rajendra
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker.
But
when I'm talking to journalists I just say programmer or something like
that.
-- Linus Torvalds
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC 0/5] PM / clock_ops: provide default runtime ops and cleanup users
On Tue, Apr 21, 2015 at 1:25 AM, santosh shilimkar
santosh.shilim...@oracle.com wrote:
On 4/20/2015 4:21 PM, Kevin Hilman wrote:
Rajendra Nayak rna...@codeaurora.org writes:
Most users of PM clocks do the exact same thing in runtime callbacks.
Probably because they were all copied from mach-davinci. ;)
Yep. ;-)
If you're interested in the history, I did some digging last year:
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-March/242352.html
Provide default callbacks and cleanup the existing users
(keystone/davinci/omap1/sh)
Very nice cleanup, Thanks!
Note that the new code always has a dev_pm_domain, while the old code had it
conditionally on CONFIG_PM.
I don't think that matters much, as we seem to be having more and more
systems that rely on CONFIG_PM=y...
For the series:
Reviewed-by: Kevin Hilman khil...@linaro.org
Acked-by: Santosh Shilimkar ssant...@kernel.org
Looks good to me, and works fine on (pre-Clock Domain) r8a7791/koelsch
and r8a7740/armadillo-legacy (with PM Domains, but still relying on the
drivers/sh/pm_runtime.c hack for devices in the C5 always on domain).
This code is no longer used in multiplatform kernels on shmobile boards
with real PM Domains.
Acked-by: Geert Uytterhoeven geert+rene...@glider.be
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say programmer or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC 0/5] PM / clock_ops: provide default runtime ops and cleanup users
Rajendra Nayak rna...@codeaurora.org writes: Most users of PM clocks do the exact same thing in runtime callbacks. Probably because they were all copied from mach-davinci. ;) Provide default callbacks and cleanup the existing users (keystone/davinci/omap1/sh) Very nice cleanup, Thanks! For the series: Reviewed-by: Kevin Hilman khil...@linaro.org Kevin -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC 0/5] PM / clock_ops: provide default runtime ops and cleanup users
On 4/20/2015 4:21 PM, Kevin Hilman wrote: Rajendra Nayak rna...@codeaurora.org writes: Most users of PM clocks do the exact same thing in runtime callbacks. Probably because they were all copied from mach-davinci. ;) Yep. ;-) Provide default callbacks and cleanup the existing users (keystone/davinci/omap1/sh) Very nice cleanup, Thanks! Indeed !! I can't test it out but from the series, I don't expect anything to break. So looks good to me as well. For the series: Reviewed-by: Kevin Hilman khil...@linaro.org Acked-by: Santosh Shilimkar ssant...@kernel.org -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[RFC 0/5] PM / clock_ops: provide default runtime ops and cleanup users
Most users of PM clocks do the exact same thing in runtime callbacks. Provide default callbacks and cleanup the existing users (keystone/davinci/omap1/sh) Rajendra Nayak (5): PM / clock_ops: Provide default runtime ops to users arm: keystone: remove boilerplate code and use USE_PM_CLK_RUNTIME_OPS arm: omap1: remove boilerplate code and use USE_PM_CLK_RUNTIME_OPS arm: davinci: remove boilerplate code and use USE_PM_CLK_RUNTIME_OPS drivers: sh: remove boilerplate code and use USE_PM_CLK_RUNTIME_OPS arch/arm/mach-davinci/pm_domain.c | 32 +- arch/arm/mach-keystone/pm_domain.c | 33 +- arch/arm/mach-omap1/pm_bus.c | 37 ++ drivers/base/power/clock_ops.c | 38 ++ drivers/sh/pm_runtime.c| 47 ++ include/linux/pm_clock.h | 10 6 files changed, 54 insertions(+), 143 deletions(-) -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
