Re: [v4 3/3] mtd: devices: elm: Low power transition support

2013-06-13 Thread Kevin Hilman 
Pekon Gupta pe...@ti.com writes:

 From: avinash philip avinashphi...@ti.com

 In low power modes of AM335X platforms, peripherals power is cut off.
 This patch supports low power sleep transition support for ELM driver.

This series needs a bit more description about what low power sleep
transition is, and how adding runtime PM calls makes this transition
happen.

Kevin

 Signed-off-by: Philip Avinash avinashphi...@ti.com
 Signed-off-by: Pekon Gupta pe...@ti.com
 ---
  drivers/mtd/devices/elm.c | 19 +++
  1 file changed, 19 insertions(+)

 diff --git a/drivers/mtd/devices/elm.c b/drivers/mtd/devices/elm.c
 index dccef9f..171efcd 100644
 --- a/drivers/mtd/devices/elm.c
 +++ b/drivers/mtd/devices/elm.c
 @@ -20,6 +20,7 @@
  #include linux/interrupt.h
  #include linux/io.h
  #include linux/of.h
 +#include linux/sched.h
  #include linux/pm_runtime.h
  #include linux/platform_data/elm.h
  
 @@ -385,6 +386,23 @@ static int elm_remove(struct platform_device *pdev)
   return 0;
  }
  
 +static int elm_suspend(struct device *dev)
 +{
 + pm_runtime_put_sync(dev);
 + return 0;
 +}
 +
 +static int elm_resume(struct device *dev)
 +{
 + struct elm_info *info = dev_get_drvdata(dev);
 +
 + pm_runtime_get_sync(dev);
 + elm_config(dev, info-bch_type);
 + return 0;
 +}
 +
 +static SIMPLE_DEV_PM_OPS(elm_pm_ops, elm_suspend, elm_resume);
 +
  #ifdef CONFIG_OF
  static const struct of_device_id elm_of_match[] = {
   { .compatible = ti,am3352-elm },
 @@ -398,6 +416,7 @@ static struct platform_driver elm_driver = {
   .name   = elm,
   .owner  = THIS_MODULE,
   .of_match_table = of_match_ptr(elm_of_match),
 + .pm = elm_pm_ops,
   },
   .probe  = elm_probe,
   .remove = elm_remove,
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[v4 3/3] mtd: devices: elm: Low power transition support

2013-06-12 Thread Pekon Gupta 
From: avinash philip avinashphi...@ti.com

In low power modes of AM335X platforms, peripherals power is cut off.
This patch supports low power sleep transition support for ELM driver.

Signed-off-by: Philip Avinash avinashphi...@ti.com
Signed-off-by: Pekon Gupta pe...@ti.com
---
 drivers/mtd/devices/elm.c | 19 +++
 1 file changed, 19 insertions(+)

diff --git a/drivers/mtd/devices/elm.c b/drivers/mtd/devices/elm.c
index dccef9f..171efcd 100644
--- a/drivers/mtd/devices/elm.c
+++ b/drivers/mtd/devices/elm.c
@@ -20,6 +20,7 @@
 #include linux/interrupt.h
 #include linux/io.h
 #include linux/of.h
+#include linux/sched.h
 #include linux/pm_runtime.h
 #include linux/platform_data/elm.h
 
@@ -385,6 +386,23 @@ static int elm_remove(struct platform_device *pdev)
return 0;
 }
 
+static int elm_suspend(struct device *dev)
+{
+   pm_runtime_put_sync(dev);
+   return 0;
+}
+
+static int elm_resume(struct device *dev)
+{
+   struct elm_info *info = dev_get_drvdata(dev);
+
+   pm_runtime_get_sync(dev);
+   elm_config(dev, info-bch_type);
+   return 0;
+}
+
+static SIMPLE_DEV_PM_OPS(elm_pm_ops, elm_suspend, elm_resume);
+
 #ifdef CONFIG_OF
 static const struct of_device_id elm_of_match[] = {
{ .compatible = ti,am3352-elm },
@@ -398,6 +416,7 @@ static struct platform_driver elm_driver = {
.name   = elm,
.owner  = THIS_MODULE,
.of_match_table = of_match_ptr(elm_of_match),
+   .pm = elm_pm_ops,
},
.probe  = elm_probe,
.remove = elm_remove,
-- 
1.8.1

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v4 3/3] mtd: devices: elm: Low power transition support

2013-06-12 Thread Pekon Gupta 
From: avinash philip avinashphi...@ti.com

In low power modes of AM335X platforms, peripherals power is cut off.
This patch supports low power sleep transition support for ELM driver.

Signed-off-by: Philip Avinash avinashphi...@ti.com
Signed-off-by: Pekon Gupta pe...@ti.com
---
 drivers/mtd/devices/elm.c | 19 +++
 1 file changed, 19 insertions(+)

diff --git a/drivers/mtd/devices/elm.c b/drivers/mtd/devices/elm.c
index dccef9f..171efcd 100644
--- a/drivers/mtd/devices/elm.c
+++ b/drivers/mtd/devices/elm.c
@@ -20,6 +20,7 @@
 #include linux/interrupt.h
 #include linux/io.h
 #include linux/of.h
+#include linux/sched.h
 #include linux/pm_runtime.h
 #include linux/platform_data/elm.h
 
@@ -385,6 +386,23 @@ static int elm_remove(struct platform_device *pdev)
return 0;
 }
 
+static int elm_suspend(struct device *dev)
+{
+   pm_runtime_put_sync(dev);
+   return 0;
+}
+
+static int elm_resume(struct device *dev)
+{
+   struct elm_info *info = dev_get_drvdata(dev);
+
+   pm_runtime_get_sync(dev);
+   elm_config(dev, info-bch_type);
+   return 0;
+}
+
+static SIMPLE_DEV_PM_OPS(elm_pm_ops, elm_suspend, elm_resume);
+
 #ifdef CONFIG_OF
 static const struct of_device_id elm_of_match[] = {
{ .compatible = ti,am3352-elm },
@@ -398,6 +416,7 @@ static struct platform_driver elm_driver = {
.name   = elm,
.owner  = THIS_MODULE,
.of_match_table = of_match_ptr(elm_of_match),
+   .pm = elm_pm_ops,
},
.probe  = elm_probe,
.remove = elm_remove,
-- 
1.8.1

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html