Re: [PATCH 2/9 v3] usb: musb: Remove board_data parameter from musb_platform_init()

2010-12-12 Thread Sergei Shtylyov 

Hello.

On 11-12-2010 20:43, Greg KH wrote:


Removed the board_data parameter being passed to musb_platform_init function
as board data can be extracted from device structure which is already member of
musb structure.



Signed-off-by: Hema HKhem...@ti.com
Cc: Felipe Balbiba...@ti.com
Cc: Tony Lindgrent...@atomide.com
Cc: Kevin Hilmankhil...@deeprootsystems.com
Cc: Cousson, Benoitb-cous...@ti.com
Cc: Paul Walmsleyp...@pwsan.com



For the davinci changes:



Acked-by: Kevin Hilmankhil...@deeprootsystems.com



Kevin



---
drivers/usb/musb/blackfin.c  |2 +-
drivers/usb/musb/davinci.c   |2 +-
drivers/usb/musb/musb_core.c |2 +-
drivers/usb/musb/musb_core.h |2 +-
drivers/usb/musb/omap2430.c  |6 --
drivers/usb/musb/tusb6010.c  |2 +-
6 files changed, 9 insertions(+), 7 deletions(-)



Grr. This misses changes to da8xx.c and am35x.c -- which breaks
the compilation for them!
Greg, could you drop it from your usb-next branch? Or should we
send a patch adding these glue layers?



I can't drop patches from a git branch, sorry, it doesn't work that way
anymore.



OTOH, you could revert it (as breaking the build). Dunno if that
makes sense...



Again, I trust the musb maintainer here to handle this type of thing,
not me.  So take it up with him.


   Done already. And he's on the CC here too...


thanks,



greg k-h


WBR, Sergei
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/9 v3] usb: musb: Remove board_data parameter from musb_platform_init()

2010-12-10 Thread Sergei Shtylyov 

Hello.

Kevin Hilman wrote:


Removed the board_data parameter being passed to musb_platform_init function
as board data can be extracted from device structure which is already member of
musb structure.



Signed-off-by: Hema HK hem...@ti.com
Cc: Felipe Balbi ba...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: Kevin Hilman khil...@deeprootsystems.com
Cc: Cousson, Benoit b-cous...@ti.com
Cc: Paul Walmsley p...@pwsan.com



For the davinci changes:



Acked-by: Kevin Hilman khil...@deeprootsystems.com



Kevin



---
 drivers/usb/musb/blackfin.c  |2 +-
 drivers/usb/musb/davinci.c   |2 +-
 drivers/usb/musb/musb_core.c |2 +-
 drivers/usb/musb/musb_core.h |2 +-
 drivers/usb/musb/omap2430.c  |6 --
 drivers/usb/musb/tusb6010.c  |2 +-
 6 files changed, 9 insertions(+), 7 deletions(-)


   Grr. This misses changes to da8xx.c and am35x.c -- which breaks the 
compilation for them!
   Greg, could you drop it from your usb-next branch? Or should we send a patch 
adding these glue layers?


WBR. Sergei

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/9 v3] usb: musb: Remove board_data parameter from musb_platform_init()

2010-12-10 Thread Greg KH 
On Fri, Dec 10, 2010 at 10:30:50PM +0300, Sergei Shtylyov wrote:
 Hello.
 
 Kevin Hilman wrote:
 
 Removed the board_data parameter being passed to musb_platform_init function
 as board data can be extracted from device structure which is already 
 member of
 musb structure.
 
 Signed-off-by: Hema HK hem...@ti.com
 Cc: Felipe Balbi ba...@ti.com
 Cc: Tony Lindgren t...@atomide.com
 Cc: Kevin Hilman khil...@deeprootsystems.com
 Cc: Cousson, Benoit b-cous...@ti.com
 Cc: Paul Walmsley p...@pwsan.com
 
 For the davinci changes:
 
 Acked-by: Kevin Hilman khil...@deeprootsystems.com
 
 Kevin
 
 ---
  drivers/usb/musb/blackfin.c  |2 +-
  drivers/usb/musb/davinci.c   |2 +-
  drivers/usb/musb/musb_core.c |2 +-
  drivers/usb/musb/musb_core.h |2 +-
  drivers/usb/musb/omap2430.c  |6 --
  drivers/usb/musb/tusb6010.c  |2 +-
  6 files changed, 9 insertions(+), 7 deletions(-)
 
Grr. This misses changes to da8xx.c and am35x.c -- which breaks
 the compilation for them!
Greg, could you drop it from your usb-next branch? Or should we
 send a patch adding these glue layers?

I can't drop patches from a git branch, sorry, it doesn't work that way
anymore.

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/9 v3] usb: musb: Remove board_data parameter from musb_platform_init()

2010-12-10 Thread Sergei Shtylyov 

Hello.

Greg KH wrote:


Removed the board_data parameter being passed to musb_platform_init function
as board data can be extracted from device structure which is already member of
musb structure.



Signed-off-by: Hema HK hem...@ti.com
Cc: Felipe Balbi ba...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: Kevin Hilman khil...@deeprootsystems.com
Cc: Cousson, Benoit b-cous...@ti.com
Cc: Paul Walmsley p...@pwsan.com



For the davinci changes:



Acked-by: Kevin Hilman khil...@deeprootsystems.com



Kevin

---
drivers/usb/musb/blackfin.c  |2 +-
drivers/usb/musb/davinci.c   |2 +-
drivers/usb/musb/musb_core.c |2 +-
drivers/usb/musb/musb_core.h |2 +-
drivers/usb/musb/omap2430.c  |6 --
drivers/usb/musb/tusb6010.c  |2 +-
6 files changed, 9 insertions(+), 7 deletions(-)



   Grr. This misses changes to da8xx.c and am35x.c -- which breaks
the compilation for them!
   Greg, could you drop it from your usb-next branch? Or should we
send a patch adding these glue layers?



I can't drop patches from a git branch, sorry, it doesn't work that way
anymore.


   That's why I really prefer quilt to git. :-)


greg k-h


WBR, Sergei
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 2/9 v3] usb: musb: Remove board_data parameter from musb_platform_init()

2010-09-29 Thread Kalliguddi, Hema 
Hi,

-Original Message-
From: Kalliguddi, Hema 
Sent: Thursday, September 23, 2010 5:58 AM
To: linux-omap@vger.kernel.org; linux-...@vger.kernel.org
Cc: Kalliguddi, Hema; Balbi, Felipe; Tony Lindgren; Kevin 
Hilman; Cousson, Benoit; Paul Walmsley
Subject: [PATCH 2/9 v3] usb: musb: Remove board_data parameter 
from musb_platform_init()

Removed the board_data parameter being passed to 
musb_platform_init function
as board data can be extracted from device structure which is 
already member of
musb structure.

Signed-off-by: Hema HK hem...@ti.com
Cc: Felipe Balbi ba...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: Kevin Hilman khil...@deeprootsystems.com
Cc: Cousson, Benoit b-cous...@ti.com
Cc: Paul Walmsley p...@pwsan.com

---
 drivers/usb/musb/blackfin.c  |2 +-
 drivers/usb/musb/davinci.c   |2 +-
 drivers/usb/musb/musb_core.c |2 +-
 drivers/usb/musb/musb_core.h |2 +-
 drivers/usb/musb/omap2430.c  |6 --
 drivers/usb/musb/tusb6010.c  |2 +-
 6 files changed, 9 insertions(+), 7 deletions(-)

Index: linux-omap-pm/drivers/usb/musb/blackfin.c
===
--- linux-omap-pm.orig/drivers/usb/musb/blackfin.c
+++ linux-omap-pm/drivers/usb/musb/blackfin.c
@@ -323,7 +323,7 @@ int musb_platform_set_mode(struct musb *
   return -EIO;
 }
 
-int __init musb_platform_init(struct musb *musb, void *board_data)
+int __init musb_platform_init(struct musb *musb)
 {
 
   /*
Index: linux-omap-pm/drivers/usb/musb/davinci.c
===
--- linux-omap-pm.orig/drivers/usb/musb/davinci.c
+++ linux-omap-pm/drivers/usb/musb/davinci.c
@@ -376,7 +376,7 @@ int musb_platform_set_mode(struct musb *
   return -EIO;
 }
 
-int __init musb_platform_init(struct musb *musb, void *board_data)
+int __init musb_platform_init(struct musb *musb)
 {
   void __iomem*tibase = musb-ctrl_base;
   u32 revision;
Index: linux-omap-pm/drivers/usb/musb/musb_core.c
===
--- linux-omap-pm.orig/drivers/usb/musb/musb_core.c
+++ linux-omap-pm/drivers/usb/musb/musb_core.c
@@ -2022,7 +2022,7 @@ bad_config:
* isp1504, non-OTG, etc) mostly hooking up through ULPI.
*/
   musb-isr = generic_interrupt;
-  status = musb_platform_init(musb, plat-board_data);
+  status = musb_platform_init(musb);
   if (status  0)
   goto fail2;
 
Index: linux-omap-pm/drivers/usb/musb/musb_core.h
===
--- linux-omap-pm.orig/drivers/usb/musb/musb_core.h
+++ linux-omap-pm/drivers/usb/musb/musb_core.h
@@ -612,7 +612,7 @@ extern int musb_platform_get_vbus_status
 #define musb_platform_get_vbus_status(x)  0
 #endif
 
-extern int __init musb_platform_init(struct musb *musb, void 
*board_data);
+extern int __init musb_platform_init(struct musb *musb);
 extern int musb_platform_exit(struct musb *musb);
 
 #endif/* __MUSB_CORE_H__ */
Index: linux-omap-pm/drivers/usb/musb/omap2430.c
===
--- linux-omap-pm.orig/drivers/usb/musb/omap2430.c
+++ linux-omap-pm/drivers/usb/musb/omap2430.c
@@ -187,10 +187,12 @@ int musb_platform_set_mode(struct musb *
   return 0;
 }
 
-int __init musb_platform_init(struct musb *musb, void *board_data)
+int __init musb_platform_init(struct musb *musb)
 {
   u32 l;
-  struct omap_musb_board_data *data = board_data;
+  struct device *dev = musb-controller;
+  struct musb_hdrc_platform_data *plat = dev-platform_data;
+  struct omap_musb_board_data *data = plat-board_data;
 
   /* We require some kind of external transceiver, hooked
* up through ULPI.  TWL4030-family PMICs include one,
Index: linux-omap-pm/drivers/usb/musb/tusb6010.c
===
--- linux-omap-pm.orig/drivers/usb/musb/tusb6010.c
+++ linux-omap-pm/drivers/usb/musb/tusb6010.c
@@ -1091,7 +1091,7 @@ err:
   return -ENODEV;
 }
 
-int __init musb_platform_init(struct musb *musb, void *board_data)
+int __init musb_platform_init(struct musb *musb)
 {
   struct platform_device  *pdev;
   struct resource *mem;


Any comments on this patch? 


Regards,
Hema


--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/9 v3] usb: musb: Remove board_data parameter from musb_platform_init()

2010-09-29 Thread Felipe Balbi 

Hi,

On Wed, Sep 29, 2010 at 02:00:14AM -0500, Kalliguddi, Hema wrote:

Any comments on this patch?


I need an ack from Mike (blackfin) and Kevin (DaVinci). Everything else
is fine by me.

--
balbi
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/9 v3] usb: musb: Remove board_data parameter from musb_platform_init()

2010-09-29 Thread Kevin Hilman 
Hema HK hem...@ti.com writes:

 Removed the board_data parameter being passed to musb_platform_init function
 as board data can be extracted from device structure which is already member 
 of
 musb structure.

 Signed-off-by: Hema HK hem...@ti.com
 Cc: Felipe Balbi ba...@ti.com
 Cc: Tony Lindgren t...@atomide.com
 Cc: Kevin Hilman khil...@deeprootsystems.com
 Cc: Cousson, Benoit b-cous...@ti.com
 Cc: Paul Walmsley p...@pwsan.com

For the davinci changes:

Acked-by: Kevin Hilman khil...@deeprootsystems.com

Kevin

 ---
  drivers/usb/musb/blackfin.c  |2 +-
  drivers/usb/musb/davinci.c   |2 +-
  drivers/usb/musb/musb_core.c |2 +-
  drivers/usb/musb/musb_core.h |2 +-
  drivers/usb/musb/omap2430.c  |6 --
  drivers/usb/musb/tusb6010.c  |2 +-
  6 files changed, 9 insertions(+), 7 deletions(-)

 Index: linux-omap-pm/drivers/usb/musb/blackfin.c
 ===
 --- linux-omap-pm.orig/drivers/usb/musb/blackfin.c
 +++ linux-omap-pm/drivers/usb/musb/blackfin.c
 @@ -323,7 +323,7 @@ int musb_platform_set_mode(struct musb *
   return -EIO;
  }
  
 -int __init musb_platform_init(struct musb *musb, void *board_data)
 +int __init musb_platform_init(struct musb *musb)
  {
  
   /*
 Index: linux-omap-pm/drivers/usb/musb/davinci.c
 ===
 --- linux-omap-pm.orig/drivers/usb/musb/davinci.c
 +++ linux-omap-pm/drivers/usb/musb/davinci.c
 @@ -376,7 +376,7 @@ int musb_platform_set_mode(struct musb *
   return -EIO;
  }
  
 -int __init musb_platform_init(struct musb *musb, void *board_data)
 +int __init musb_platform_init(struct musb *musb)
  {
   void __iomem*tibase = musb-ctrl_base;
   u32 revision;
 Index: linux-omap-pm/drivers/usb/musb/musb_core.c
 ===
 --- linux-omap-pm.orig/drivers/usb/musb/musb_core.c
 +++ linux-omap-pm/drivers/usb/musb/musb_core.c
 @@ -2022,7 +2022,7 @@ bad_config:
* isp1504, non-OTG, etc) mostly hooking up through ULPI.
*/
   musb-isr = generic_interrupt;
 - status = musb_platform_init(musb, plat-board_data);
 + status = musb_platform_init(musb);
   if (status  0)
   goto fail2;
  
 Index: linux-omap-pm/drivers/usb/musb/musb_core.h
 ===
 --- linux-omap-pm.orig/drivers/usb/musb/musb_core.h
 +++ linux-omap-pm/drivers/usb/musb/musb_core.h
 @@ -612,7 +612,7 @@ extern int musb_platform_get_vbus_status
  #define musb_platform_get_vbus_status(x) 0
  #endif
  
 -extern int __init musb_platform_init(struct musb *musb, void *board_data);
 +extern int __init musb_platform_init(struct musb *musb);
  extern int musb_platform_exit(struct musb *musb);
  
  #endif   /* __MUSB_CORE_H__ */
 Index: linux-omap-pm/drivers/usb/musb/omap2430.c
 ===
 --- linux-omap-pm.orig/drivers/usb/musb/omap2430.c
 +++ linux-omap-pm/drivers/usb/musb/omap2430.c
 @@ -187,10 +187,12 @@ int musb_platform_set_mode(struct musb *
   return 0;
  }
  
 -int __init musb_platform_init(struct musb *musb, void *board_data)
 +int __init musb_platform_init(struct musb *musb)
  {
   u32 l;
 - struct omap_musb_board_data *data = board_data;
 + struct device *dev = musb-controller;
 + struct musb_hdrc_platform_data *plat = dev-platform_data;
 + struct omap_musb_board_data *data = plat-board_data;
  
   /* We require some kind of external transceiver, hooked
* up through ULPI.  TWL4030-family PMICs include one,
 Index: linux-omap-pm/drivers/usb/musb/tusb6010.c
 ===
 --- linux-omap-pm.orig/drivers/usb/musb/tusb6010.c
 +++ linux-omap-pm/drivers/usb/musb/tusb6010.c
 @@ -1091,7 +1091,7 @@ err:
   return -ENODEV;
  }
  
 -int __init musb_platform_init(struct musb *musb, void *board_data)
 +int __init musb_platform_init(struct musb *musb)
  {
   struct platform_device  *pdev;
   struct resource *mem;
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html