Re: [PATCH v4] ARM: dts: OMAP5: Add palmas MFD node and regulator nodes

2013-06-12 Thread Stephen Warren 
On 06/12/2013 02:19 AM, J Keerthy wrote:
 This patch adds Palmas MFD node and the regulator nodes for OMAP5.
 
 The node definitions are based on: https://lkml.org/lkml/2013/6/6/25
 
 Boot tested on omap5-uevm board.

Reviewed-by: Stephen Warren swar...@nvidia.com

 diff --git a/arch/arm/boot/dts/omap5-uevm.dts 
 b/arch/arm/boot/dts/omap5-uevm.dts

 + palmas: palmas@48 {
 + reg = 0x48;
 + interrupts = GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH; /* IRQ_SYS_1N */
 + interrupt-parent = gic;
 + compatible = ti,palmas;

... although personally I prefer the compatible property to be right at
the top of each node, since it's what implies the schema for the rest of
the node. That's a tiny nit though; feel free to ignore it if the OMAP
files don't follow that convention.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH v4] ARM: dts: OMAP5: Add palmas MFD node and regulator nodes

2013-06-12 Thread J, KEERTHY 
Hi Stephen,

 -Original Message-
 From: Stephen Warren [mailto:swar...@wwwdotorg.org]
 Sent: Wednesday, June 12, 2013 9:22 PM
 To: J, KEERTHY
 Cc: Cousson, Benoit; devicetree-disc...@lists.ozlabs.org; linux-
 o...@vger.kernel.org; linux-ker...@vger.kernel.org;
 ldewan...@nvidia.com; grant.lik...@secretlab.ca; swar...@nvidia.com;
 sa...@linux.intel.com; g...@slimlogic.co.uk; lee.jo...@linaro.org
 Subject: Re: [PATCH v4] ARM: dts: OMAP5: Add palmas MFD node and
 regulator nodes
 
 On 06/12/2013 02:19 AM, J Keerthy wrote:
  This patch adds Palmas MFD node and the regulator nodes for OMAP5.
 
  The node definitions are based on: https://lkml.org/lkml/2013/6/6/25
 
  Boot tested on omap5-uevm board.
 
 Reviewed-by: Stephen Warren swar...@nvidia.com

Thanks..

 
  diff --git a/arch/arm/boot/dts/omap5-uevm.dts
  b/arch/arm/boot/dts/omap5-uevm.dts
 
  +   palmas: palmas@48 {
  +   reg = 0x48;
  +   interrupts = GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH; /* IRQ_SYS_1N
 */
  +   interrupt-parent = gic;
  +   compatible = ti,palmas;
 
 ... although personally I prefer the compatible property to be right at
 the top of each node, since it's what implies the schema for the rest
 of the node. That's a tiny nit though; feel free to ignore it if the
 OMAP files don't follow that convention.

Sure. I will send hopefully the last version incorporating this :-).

Regards,
Keerthy
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html