Re: [TMP] OMAP3EVM: Test gpmc nand smsc911x

2012-04-25 Thread Tony Lindgren 
* Afzal Mohammed af...@ti.com [120405 09:08]:
 @@ -114,6 +147,8 @@ static struct omap_smsc911x_platform_data smsc911x_cfg = {
  
  static inline void __init omap3evm_init_smsc911x(void)
  {
 + struct gpmc_device_pdata *gpmc_smsc911x_info;
 +
   /* Configure ethernet controller reset gpio */
   if (cpu_is_omap3430()) {
   if (get_omap3_evm_rev() == OMAP3EVM_BOARD_GEN_1)
 @@ -122,7 +157,11 @@ static inline void __init omap3evm_init_smsc911x(void)
   smsc911x_cfg.gpio_reset = OMAP3EVM_GEN2_ETHR_GPIO_RST;
   }
  
 - gpmc_smsc911x_init(smsc911x_cfg);
 + gpmc_smsc911x_info = gpmc_smsc911x_init(smsc911x_cfg);
 + if (gpmc_smsc911x_info)
 + *gpmc_data_cur++ = gpmc_smsc911x_info;
 + else
 + pr_err(error: unable to initilaize gpmc smsc911x\n);
  }
  
  #else

Obviously we can't merge any of this if until all the board-*.c files
are changed and tested.

Can you maybe still keep the old interfaces in addition to the new ones
so we can do the conversion one board-*.c file at a time while keeping
things working?

Regards,

Tony
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [TMP] OMAP3EVM: Test gpmc nand smsc911x

2012-04-25 Thread Mohammed, Afzal 
Hi Tony,

On Wed, Apr 25, 2012 at 22:17:26, Tony Lindgren wrote:
 Obviously we can't merge any of this if until all the board-*.c files
 are changed and tested.
 
 Can you maybe still keep the old interfaces in addition to the new ones
 so we can do the conversion one board-*.c file at a time while keeping
 things working?

As there are peripherals using helper functions, to handle those, you
meant to create a new altered similar function to deal for each too ?,
while keeping existing functions as such.

i.e. like having gpmc_smsc911x_init  gpmc_smsc911x_new_init for
each peripheral ?, with gpmc_smsc911x_new_init using gpmc driver,
and gpmc_smsc911x_init as is.

Regards
Afzal


--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html