Re: [PATCHv9 07/18] mfd: omap-prm: added suspend prepare and complete callbacks

2011-11-21 Thread Tero Kristo
Hi Kevin,

On Fri, 2011-11-18 at 11:02 -0800, Kevin Hilman wrote:
 Tero Kristo t-kri...@ti.com writes:
 
  These are needed because runtime PM is disabled during suspend, and
  it is bad if we get interrupts from the PRCM chain handler during it.
  Now, PRCM interrupt forwarding is disabled until the suspend-complete,
  which makes sure that all the needed drivers are up.
 
 Just to clarify...  based on reading the patch, the wakeup and PRCM
 interrupts themselves still happen (and are saved). They are just not
 dispatched to the drivers until -complete().
 

Yea, this is true. We just postpone the dispatching until -complete().
This is accomplished by disabling all the interrupts from the mask
register once a wakeup interrupt happens, saving the mask, and restoring
it at complete() which triggers the pending interrupts again.

 I think the changelog should be a bit clearer about that.

I can take a look at this for the next version.

-Tero

 
 Thanks,
 
 Kevin


--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCHv9 07/18] mfd: omap-prm: added suspend prepare and complete callbacks

2011-11-18 Thread Kevin Hilman
Tero Kristo t-kri...@ti.com writes:

 These are needed because runtime PM is disabled during suspend, and
 it is bad if we get interrupts from the PRCM chain handler during it.
 Now, PRCM interrupt forwarding is disabled until the suspend-complete,
 which makes sure that all the needed drivers are up.

Just to clarify...  based on reading the patch, the wakeup and PRCM
interrupts themselves still happen (and are saved). They are just not
dispatched to the drivers until -complete().

I think the changelog should be a bit clearer about that.

Thanks,

Kevin
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html