Re: am335x: TSC ADC reworking including DT pieces, take 5
Hi Sebastian, On Wed, Jun 12, 2013 at 06:58:01PM +0200, Sebastian Andrzej Siewior wrote: Hi Samuel, I did the cosmetic changes of the subject line and removed the changes from within the sob lines in each patch. I dropped the #define XPP STEPCONFIG_XPP thingy and patch #1 which removed regmap from mfd. Not that I agree with it, I just do not want to miss the merge window due to this. The following changes since commit d683b96b072dc4680fc74964eca77e6a23d1fa6e: Linux 3.10-rc4 (2013-06-02 17:11:17 +0900) are available in the git repository at: git://breakpoint.cc/bigeasy/linux tags/am335x_tsc-adc Pulled and pushed back to mfd-next, thanks. I fixed a couple of unused variable warnings on top of it. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: am335x: TSC ADC reworking including DT pieces, take 5
On 06/13/2013 11:07 AM, Samuel Ortiz wrote:
Hi Sebastian,
Hi Samuel,
Pulled and pushed back to mfd-next, thanks.
Thank you.
I fixed a couple of unused variable warnings on top of it.
I saw your patch at git.k.o and I am asking you not to taking it :)
The code is:
of_property_for_each_u32(node, ti,adc-channels, prop, cur, val) {
adc_channels++;
if (val 7) {
dev_err(pdev-dev, PIN numbers are 0..7 (not
%d)\n,
val);
return -EINVAL;
}
}
and without CONFIG_OF of_property_for_each_u32() becomes most likely
empty. That is why I haven't seen it.
So either the macro should be changed to tell the compiler that the
variables are used (so the warning does not show up) or let the driver
depend on CONFIG_OF. I will look at the former and can prepare a patch
for the latter if you want.
Cheers,
Samuel.
Sebastian
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: am335x: TSC ADC reworking including DT pieces, take 5
Hi Sebastian, On Thu, Jun 13, 2013 at 11:25:26AM +0200, Sebastian Andrzej Siewior wrote: I fixed a couple of unused variable warnings on top of it. I saw your patch at git.k.o and I am asking you not to taking it :) I understand why now, I'll remove it. Sorry about that. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
am335x: TSC ADC reworking including DT pieces, take 5
Hi Samuel, I did the cosmetic changes of the subject line and removed the changes from within the sob lines in each patch. I dropped the #define XPP STEPCONFIG_XPP thingy and patch #1 which removed regmap from mfd. Not that I agree with it, I just do not want to miss the merge window due to this. The following changes since commit d683b96b072dc4680fc74964eca77e6a23d1fa6e: Linux 3.10-rc4 (2013-06-02 17:11:17 +0900) are available in the git repository at: git://breakpoint.cc/bigeasy/linux tags/am335x_tsc-adc for you to fetch changes up to 1460c152c53335b5403045d056502eda1204c33a: iio: ti_am335x_adc: check if we found the value (2013-06-12 18:50:23 +0200) A complete refurbished series inclunding: - DT support for the MFD, TSC and ADC driver platform device support, which has no users, has been killed. - iio_map from last series is gone and replaced by proper nodes in the device tree. - suspend fixes which means correct data structs are taken and no interrupt storm - fifo split which should problem with TSC ADC beeing used at the same time - The ADC channels are now checked before blindly applied. That means the touch part reads X, Y and Z coordinates and does not mix them up. Same goes for the IIO ADC driver. - The IIO ADC driver now creates files named in_voltageX_raw where X represents the ADC line instead of a number starting at 0. A read from this file can return -EBUSY in case touch is busy and the ADC didn't collect a value. Pantelis Antoniou (2): iio: ti_tscadc: provide datasheet_name and scan_type mfd: ti_tscadc: deal with partial activation Patil, Rachna (7): input: ti_am33x_tsc: Step enable bits made configurable input: ti_am33x_tsc: Order of TSC wires, made configurable input: ti_am33x_tsc: remove unwanted fifo flush input: ti_am33x_tsc: Add DT support iio: ti_am335x_adc: Add DT support mfd: ti_am335x_tscadc: Add DT support arm: am33xx: add TSC/ADC mfd device support Sebastian Andrzej Siewior (12): mfd: input: iio: ti_am335x_adc: use one structure for ti_tscadc_dev input: ti_am33x_tsc: remove platform_data support iio: ti_am335x_adc: remove platform_data support mfd: ti_am335x_tscadc: remove platform_data support input: mfd: ti_am335x_tsc remove remaining platform data pieces mfd: input: ti_am335x_tsc: rename device from tsc to TI-am335x-tsc mfd: iio: ti_am335x_adc: rename device from tiadc to TI-am335x-adc input: ti_am335x_adc: use only FIFO0 and clean up a little input: ti_am335x_tsc: ACK the HW_PEN irq in ISR input: ti_am335x_tsc: return IRQ_NONE if there was no IRQ for us iio: ti_am335x_adc: Allow to specify input line iio: ti_am335x_adc: check if we found the value .../bindings/input/touchscreen/ti-tsc-adc.txt | 44 +++ arch/arm/boot/dts/am335x-evm.dts | 14 + arch/arm/boot/dts/am33xx.dtsi | 18 ++ drivers/iio/adc/ti_am335x_adc.c| 132 ++--- drivers/input/touchscreen/ti_am335x_tsc.c | 288 ++-- drivers/mfd/ti_am335x_tscadc.c | 112 ++-- include/linux/input/ti_am335x_tsc.h| 23 -- include/linux/mfd/ti_am335x_tscadc.h | 35 +-- include/linux/platform_data/ti_am335x_adc.h| 14 - 9 files changed, 486 insertions(+), 194 deletions(-) create mode 100644 Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt delete mode 100644 include/linux/input/ti_am335x_tsc.h delete mode 100644 include/linux/platform_data/ti_am335x_adc.h Sebastian -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
