Re: spare group
Neil Brown írta: On Tuesday June 12, [EMAIL PROTECTED] wrote: I am very sorry, but it wont works with .9 superblocks also :( We missing something small, but important here. Before you start to code. mdadm was running in monitor mode, and reported a Fail. mdadm is the latest version, 2.6.2. tg Hmmm. [tests code] Yes, you are right. It looks like a bug was introduced in 2.6 which broke various aspects of --monitor. I guess I need to add some --monitor tests to my regression test suite. This patch should fix it. Thanks again, NeilBrown Thanks, the patch is working. tg - To unsubscribe from this list: send the line unsubscribe linux-raid in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: spare group
On Tuesday June 12, [EMAIL PROTECTED] wrote: According to the source: * If an array has active raid spare == 0 spare_group !=NULL * Look for another array with spare 0 and active == raid and same spare_group * if found, choose a device and hotremove/hotadd This is not happening. What is my mistake? Is mdadm --monitor running? That is required to perform spare-migration. Yes, of course. Good - I need to get the obvious things out of the way first :-) (reads code). Ahhh. You are using version-1 superblocks aren't you? That code only works for version-0.90 superblocks. That was careless of me. It shouldn't be hard to make it work more generally, but it looks like it will be slightly more than trivial. I'll try to get you a patch in the next day or so (feel free to remind me if I seem to have forgotten). Thanks for testing and reporting this problem. NeilBrown - To unsubscribe from this list: send the line unsubscribe linux-raid in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: spare group
Neil Brown írta: (reads code). Ahhh. You are using version-1 superblocks aren't you? That code only works for version-0.90 superblocks. That was careless of me. It shouldn't be hard to make it work more generally, but it looks like it will be slightly more than trivial. I'll try to get you a patch in the next day or so (feel free to remind me if I seem to have forgotten). Thanks for testing and reporting this problem. NeilBrown # mdadm26 --detail /dev/md0 /dev/md0: Version : 00.90.03 Creation Time : Tue Jun 12 10:31:08 2007 Raid Level : raid5 Array Size : 19534848 (18.63 GiB 20.00 GB) Used Dev Size : 9767424 (9.31 GiB 10.00 GB) Raid Devices : 3 Total Devices : 4 Preferred Minor : 0 Persistence : Superblock is persistent Update Time : Tue Jun 12 10:33:35 2007 State : clean Active Devices : 3 Working Devices : 4 Failed Devices : 0 Spare Devices : 1 Layout : left-symmetric Chunk Size : 64K UUID : 5fd83926:01739a55:36458d87:119f8994 (local to host ursula) Events : 0.4 Number Major Minor RaidDevice State 0 810 active sync /dev/sda1 1 8 171 active sync /dev/sdb1 2 8 332 active sync /dev/sdc1 3 8 49- spare /dev/sdd1 /dev/md1: Version : 00.90.03 Creation Time : Tue Jun 12 10:31:29 2007 Raid Level : raid5 Array Size : 19534848 (18.63 GiB 20.00 GB) Used Dev Size : 9767424 (9.31 GiB 10.00 GB) Raid Devices : 3 Total Devices : 3 Preferred Minor : 1 Persistence : Superblock is persistent Update Time : Tue Jun 12 10:36:18 2007 State : clean, degraded Active Devices : 2 Working Devices : 2 Failed Devices : 1 Spare Devices : 0 Layout : left-symmetric Chunk Size : 64K UUID : 815d6fc4:a55c2602:36458d87:119f8994 (local to host ursula) Events : 0.6 Number Major Minor RaidDevice State 0 8 650 active sync /dev/sde1 1 8 811 active sync /dev/sdf1 2 002 removed 3 8 97- faulty spare /dev/sdg1 ARRAY /dev/md1 level=raid5 num-devices=3 spare-group=ubul UUID=815d6fc4:a55c2602:36458d87:119f8994 ARRAY /dev/md0 level=raid5 num-devices=3 spares=1 spare-group=ubul UUID=5fd83926:01739a55:36458d87:119f8994 I am very sorry, but it wont works with .9 superblocks also :( We missing something small, but important here. Before you start to code. mdadm was running in monitor mode, and reported a Fail. mdadm is the latest version, 2.6.2. tg - To unsubscribe from this list: send the line unsubscribe linux-raid in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: spare group
On Tuesday June 12, [EMAIL PROTECTED] wrote:
I am very sorry, but it wont works with .9 superblocks also :( We
missing something small, but important here. Before you start to code.
mdadm was running in monitor mode, and reported a Fail. mdadm is the
latest version, 2.6.2.
tg
Hmmm.
[tests code]
Yes, you are right. It looks like a bug was introduced in 2.6 which
broke various aspects of --monitor. I guess I need to add some
--monitor tests to my regression test suite.
This patch should fix it.
Thanks again,
NeilBrown
---
Fix spare migration and other problems with --monitor.
2.6 broke --monitor in various ways, including spare migration
stopped working. This fixes it.
### Diffstat output
./Monitor.c |1 +
1 file changed, 1 insertion(+)
diff .prev/Monitor.c ./Monitor.c
--- .prev/Monitor.c 2007-02-22 14:59:11.0 +1100
+++ ./Monitor.c 2007-06-12 19:48:34.0 +1000
@@ -328,6 +328,7 @@ int Monitor(mddev_dev_t devlist,
for (i=0; iMaxDisks i = array.raid_disks +
array.nr_disks;
i++) {
mdu_disk_info_t disc;
+ disc.number = i;
if (ioctl(fd, GET_DISK_INFO, disc) = 0) {
info[i].state = disc.state;
info[i].major = disc.major;
-
To unsubscribe from this list: send the line unsubscribe linux-raid in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
