Re: [PATCH 1/1] i2c: s3c2410: Remove class based instantiation
On Tue, Jun 03, 2014 at 02:30:22PM +0530, Sachin Kamat wrote: With multiplatform support enabled for Exynos, class based instantiation causes a boot time delay due to I2C_CLASS_HWMON triggered probe. Since class based instantiation has been deprecated since some time now, remove it for Samsung I2C driver. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com Cc: Olof Johansson o...@lixom.net In my book, not long enough. I suggest I will take care of the removal. I'll do it for all class deprecating drivers. signature.asc Description: Digital signature
Re: [PATCH 1/1] i2c: s3c2410: Remove class based instantiation
Hi Wolfram, On Tue, Jun 3, 2014 at 3:35 PM, Wolfram Sang w...@the-dreams.de wrote: On Tue, Jun 03, 2014 at 02:30:22PM +0530, Sachin Kamat wrote: With multiplatform support enabled for Exynos, class based instantiation causes a boot time delay due to I2C_CLASS_HWMON triggered probe. Since class based instantiation has been deprecated since some time now, remove it for Samsung I2C driver. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com Cc: Olof Johansson o...@lixom.net In my book, not long enough. I suggest I will take care of the removal. I'll do it for all class deprecating drivers. The reason for the removal is the boot delay it is causing on Exynos 5250 based boards by throwing the following errors continuously. [ 55.005300] s3c-i2c 12ce.i2c: cannot get bus (error -110) [ 59.005300] s3c-i2c 12ce.i2c: cannot get bus (error -110) [ 63.005300] s3c-i2c 12ce.i2c: cannot get bus (error -110) Regards, Sachin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1] i2c: s3c2410: Remove class based instantiation
The reason for the removal is the boot delay it is causing on Exynos 5250 based boards by throwing the following errors continuously. [ 55.005300] s3c-i2c 12ce.i2c: cannot get bus (error -110) [ 59.005300] s3c-i2c 12ce.i2c: cannot get bus (error -110) [ 63.005300] s3c-i2c 12ce.i2c: cannot get bus (error -110) I know. That's why I implemented the deprecated class. Still, users may need more time to switch over. Keep it an out-of-tree patch until then. signature.asc Description: Digital signature
Re: [PATCH 1/1] i2c: s3c2410: Remove class based instantiation
Hi Wolfram, Sachin, On 03.06.2014 13:21, Sachin Kamat wrote: Hi Wolfram, On Tue, Jun 3, 2014 at 3:35 PM, Wolfram Sang w...@the-dreams.de wrote: On Tue, Jun 03, 2014 at 02:30:22PM +0530, Sachin Kamat wrote: With multiplatform support enabled for Exynos, class based instantiation causes a boot time delay due to I2C_CLASS_HWMON triggered probe. Since class based instantiation has been deprecated since some time now, remove it for Samsung I2C driver. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com Cc: Olof Johansson o...@lixom.net In my book, not long enough. I suggest I will take care of the removal. I'll do it for all class deprecating drivers. Couldn't it be made configurable with a Kconfig entry? E.g. Enable deprecated class-based instantiation under Drivers / I2C? Turning it off could make the code ignore the class field completely. This way people that don't want it could just disable it and others could also test whether disabling it affects them in any way. The reason for the removal is the boot delay it is causing on Exynos 5250 based boards by throwing the following errors continuously. [ 55.005300] s3c-i2c 12ce.i2c: cannot get bus (error -110) [ 59.005300] s3c-i2c 12ce.i2c: cannot get bus (error -110) [ 63.005300] s3c-i2c 12ce.i2c: cannot get bus (error -110) Are you sure this is directly related to class-based instantiation? This looks like the bus being driven low by some external component or incorrectly configured pins. What is this bus used for on affected board? Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1] i2c: s3c2410: Remove class based instantiation
Couldn't it be made configurable with a Kconfig entry? E.g. Enable deprecated class-based instantiation under Drivers / I2C? Turning it off could make the code ignore the class field completely. Technically, yes. But we could also wait another cycle and just be done with it :) signature.asc Description: Digital signature
Re: [PATCH 1/1] i2c: s3c2410: Remove class based instantiation
On 03.06.2014 14:17, Wolfram Sang wrote: Couldn't it be made configurable with a Kconfig entry? E.g. Enable deprecated class-based instantiation under Drivers / I2C? Turning it off could make the code ignore the class field completely. Technically, yes. But we could also wait another cycle and just be done with it :) OK, if it's just one cycle, then it wouldn't make sense indeed. Thanks for clarification. Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
