Re: [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
On Fri, Aug 22, 2014 at 3:39 AM, Kukjin Kim kgene@samsung.com wrote: Olof Johansson wrote: On Tue, Aug 19, 2014 at 12:15:41PM +0200, Javier Martinez Canillas wrote: Hello, On Tue, Aug 19, 2014 at 11:57 AM, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: IMHO they should go to upstream ASAP as they fix the boot for ODROID boards and they cannot break anything as they are limited to ODROID dts files. Agreed, this is definitely -rc material IMHO. Yes. Definitely. OK, agreed. Will apply into fixes. Hi, I'm about to send a batch up to Linus, and this was quick to apply myself, so I've done so -- I'm interested in keeping this hardware working since I have it in my test setup as the only EXYNOS4 machine. -Olof -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
Olof Johansson wrote: On Tue, Aug 19, 2014 at 12:15:41PM +0200, Javier Martinez Canillas wrote: Hello, On Tue, Aug 19, 2014 at 11:57 AM, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: IMHO they should go to upstream ASAP as they fix the boot for ODROID boards and they cannot break anything as they are limited to ODROID dts files. Agreed, this is definitely -rc material IMHO. Yes. Definitely. OK, agreed. Will apply into fixes. Thanks, Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
Hi,
On Monday, August 18, 2014 11:43:07 AM Kukjin Kim wrote:
On 08/12/14 08:06, Tomeu Vizoso wrote:
Tested on an Odroid-U2:
Tested-by: Tomeu Vizosoto...@tomeuvizoso.net
Thanks,
Tomeu
On 16 July 2014 10:50, Daniel Drakedr...@endlessm.com wrote:
The ODROID kernel shows that the PMIC interrupt line is hooked up
to pin GPX3-2.
This is needed for the max77686-irq driver to create the PMIC IRQ
domain, which is needed by max77686-rtc.
Signed-off-by: Daniel Drakedr...@endlessm.com
---
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 11 +++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
index 6d6d23c..cb6f55f 100644
--- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
+++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
@@ -148,6 +148,10 @@
max77686: pmic@09 {
compatible = maxim,max77686;
+ interrupt-parent =gpx3;
+ interrupts =2 0;
+ pinctrl-names = default;
+ pinctrl-0 =max77686_irq;
reg =0x09;
#clock-cells =1;
@@ -368,4 +372,11 @@
samsung,pins = gpx1-3;
samsung,pin-pud =0;
};
+
+ max77686_irq: max77686-irq {
+ samsung,pins = gpx3-2;
+ samsung,pin-function =0;
+ samsung,pin-pud =0;
+ samsung,pin-drv =0;
+ };
};
Thanks, applied this series.
Unfortunately these patches were applied to v3.18-next/dt-samsung
branch and not v3.17-samsung-fixes-1 one.
IMHO they should go to upstream ASAP as they fix the boot for
ODROID boards and they cannot break anything as they are limited
to ODROID dts files.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung RD Institute Poland
Samsung Electronics
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
Hello, On Tue, Aug 19, 2014 at 11:57 AM, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: IMHO they should go to upstream ASAP as they fix the boot for ODROID boards and they cannot break anything as they are limited to ODROID dts files. Agreed, this is definitely -rc material IMHO. Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
On 08/12/14 08:06, Tomeu Vizoso wrote:
Tested on an Odroid-U2:
Tested-by: Tomeu Vizosoto...@tomeuvizoso.net
Thanks,
Tomeu
On 16 July 2014 10:50, Daniel Drakedr...@endlessm.com wrote:
The ODROID kernel shows that the PMIC interrupt line is hooked up
to pin GPX3-2.
This is needed for the max77686-irq driver to create the PMIC IRQ
domain, which is needed by max77686-rtc.
Signed-off-by: Daniel Drakedr...@endlessm.com
---
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 11 +++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
index 6d6d23c..cb6f55f 100644
--- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
+++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
@@ -148,6 +148,10 @@
max77686: pmic@09 {
compatible = maxim,max77686;
+ interrupt-parent =gpx3;
+ interrupts =2 0;
+ pinctrl-names = default;
+ pinctrl-0 =max77686_irq;
reg =0x09;
#clock-cells =1;
@@ -368,4 +372,11 @@
samsung,pins = gpx1-3;
samsung,pin-pud =0;
};
+
+ max77686_irq: max77686-irq {
+ samsung,pins = gpx3-2;
+ samsung,pin-function =0;
+ samsung,pin-pud =0;
+ samsung,pin-drv =0;
+ };
};
Thanks, applied this series.
- Kukjin
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
Tested on an Odroid-U2:
Tested-by: Tomeu Vizoso to...@tomeuvizoso.net
Thanks,
Tomeu
On 16 July 2014 10:50, Daniel Drake dr...@endlessm.com wrote:
The ODROID kernel shows that the PMIC interrupt line is hooked up
to pin GPX3-2.
This is needed for the max77686-irq driver to create the PMIC IRQ
domain, which is needed by max77686-rtc.
Signed-off-by: Daniel Drake dr...@endlessm.com
---
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 11 +++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
index 6d6d23c..cb6f55f 100644
--- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
+++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
@@ -148,6 +148,10 @@
max77686: pmic@09 {
compatible = maxim,max77686;
+ interrupt-parent = gpx3;
+ interrupts = 2 0;
+ pinctrl-names = default;
+ pinctrl-0 = max77686_irq;
reg = 0x09;
#clock-cells = 1;
@@ -368,4 +372,11 @@
samsung,pins = gpx1-3;
samsung,pin-pud = 0;
};
+
+ max77686_irq: max77686-irq {
+ samsung,pins = gpx3-2;
+ samsung,pin-function = 0;
+ samsung,pin-pud = 0;
+ samsung,pin-drv = 0;
+ };
};
--
1.9.1
___
linux-arm-kernel mailing list
linux-arm-ker...@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
The ODROID kernel shows that the PMIC interrupt line is hooked up
to pin GPX3-2.
This is needed for the max77686-irq driver to create the PMIC IRQ
domain, which is needed by max77686-rtc.
Signed-off-by: Daniel Drake dr...@endlessm.com
---
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 11 +++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
index 6d6d23c..cb6f55f 100644
--- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
+++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
@@ -148,6 +148,10 @@
max77686: pmic@09 {
compatible = maxim,max77686;
+ interrupt-parent = gpx3;
+ interrupts = 2 0;
+ pinctrl-names = default;
+ pinctrl-0 = max77686_irq;
reg = 0x09;
#clock-cells = 1;
@@ -368,4 +372,11 @@
samsung,pins = gpx1-3;
samsung,pin-pud = 0;
};
+
+ max77686_irq: max77686-irq {
+ samsung,pins = gpx3-2;
+ samsung,pin-function = 0;
+ samsung,pin-pud = 0;
+ samsung,pin-drv = 0;
+ };
};
--
1.9.1
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
On 16.07.2014 10:50, Daniel Drake wrote:
The ODROID kernel shows that the PMIC interrupt line is hooked up
to pin GPX3-2.
This is needed for the max77686-irq driver to create the PMIC IRQ
domain, which is needed by max77686-rtc.
Signed-off-by: Daniel Drake dr...@endlessm.com
---
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 11 +++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
index 6d6d23c..cb6f55f 100644
--- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
+++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
@@ -148,6 +148,10 @@
max77686: pmic@09 {
compatible = maxim,max77686;
+ interrupt-parent = gpx3;
+ interrupts = 2 0;
+ pinctrl-names = default;
+ pinctrl-0 = max77686_irq;
reg = 0x09;
#clock-cells = 1;
@@ -368,4 +372,11 @@
samsung,pins = gpx1-3;
samsung,pin-pud = 0;
};
+
+ max77686_irq: max77686-irq {
+ samsung,pins = gpx3-2;
+ samsung,pin-function = 0;
+ samsung,pin-pud = 0;
+ samsung,pin-drv = 0;
+ };
};
Reviewed-by: Tomasz Figa t.f...@samsung.com
--
Best regards,
Tomasz
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
