[PATCH] isci: fix two comment typos

2015-10-04 Thread Geliang Tang 
Just fix two typos in the code comment.

Signed-off-by: Geliang Tang 
---
 drivers/scsi/isci/request.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/isci/request.c b/drivers/scsi/isci/request.c
index cfd0084..8fe106f 100644
--- a/drivers/scsi/isci/request.c
+++ b/drivers/scsi/isci/request.c
@@ -3306,7 +3306,7 @@ sci_io_request_construct_smp(struct device *dev,
  * @ireq: This parameter points to the isci_request allocated in the
  *request construct function.
  *
- * SCI_SUCCESS on successfull completion, or specific failure code.
+ * SCI_SUCCESS on successful completion, or specific failure code.
  */
 static enum sci_status isci_smp_request_build(struct isci_request *ireq)
 {
@@ -3332,7 +3332,7 @@ static enum sci_status isci_smp_request_build(struct 
isci_request *ireq)
  * @sci_device: This parameter is the handle for the sci core's remote device
  *object that is the destination for this request.
  *
- * SCI_SUCCESS on successfull completion, or specific failure code.
+ * SCI_SUCCESS on successful completion, or specific failure code.
  */
 static enum sci_status isci_io_request_build(struct isci_host *ihost,
 struct isci_request *request,
-- 
2.5.0


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] scsi: dpt: remove i2o header in uapi

2015-10-04 Thread Greg Kroah-Hartman 
On Sun, Oct 04, 2015 at 01:22:50AM +0200, Gabriel Laskar wrote:
> The i2o subsystem was removed by
> commit 4a72a7af462d ("staging: remove i2o subsystem") but the header was
> still used by drivers/scsi/dpt_i2o.c driver.
> 
> This patch moves the structures used from the header into dpti_i2o.h.
> 
> CC: Arnd Bergmann 
> CC: Greg Kroah-Hartman 
> Signed-off-by: Gabriel Laskar 
> ---
>  drivers/scsi/dpt/dpti_i2o.h  | 134 +-
>  include/uapi/linux/Kbuild|   1 -
>  include/uapi/linux/i2o-dev.h | 421 
> ---
>  3 files changed, 132 insertions(+), 424 deletions(-)
>  delete mode 100644 include/uapi/linux/i2o-dev.h

Acked-by: Greg Kroah-Hartman 
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/52] atp870u: Major rework

2015-10-04 Thread Christoph Hellwig 
On Sun, Jul 26, 2015 at 10:24:07PM +0200, Ondrej Zary wrote:
> Partially (up to patch 34) Acked-by: Christoph Hellwig 

The rest looks fine to me, too.

Let's get this merged!
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH V5 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-10-04 Thread Greg Kroah-Hartman 
On Sun, Sep 27, 2015 at 03:48:24PM +0200, Rafael J. Wysocki wrote:
> On Sun, Sep 27, 2015 at 12:04 AM, Viresh Kumar  
> wrote:
> > global_lock is defined as an unsigned long and accessing only its lower
> > 32 bits from sysfs is incorrect, as we need to consider other 32 bits
> > for big endian 64-bit systems. There are no such platforms yet, but the
> > code needs to be robust for such a case.
> >
> > Fix that by changing type of 'global_lock' to u32.
> >
> > Signed-off-by: Viresh Kumar 
> 
> Acked-by: Rafael J. Wysocki 
> 
> Greg, please take this one along with the [2/2] if that one looks good to you.

Thanks, will do.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 01/18] mpt2sas: Use mpi headers from mpt3sas

2015-10-04 Thread Christoph Hellwig 
Wasn't this originally my patch?  Not that I really care for this
trivial move, but the commit log just sounded familar.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: RFC: reduce CONFIG_SCSI_CONSTANTS impact by 4k

2015-10-04 Thread Christoph Hellwig 
On Sun, Oct 04, 2015 at 12:09:58AM +0200, Rasmus Villemoes wrote:
> On Sat, Oct 03 2015, Christoph Hellwig  wrote:
> 
> > Hi Rasmus,
> >
> > I like this idea.  But maybe it's also time to just move the constants
> > to a plain text file and auto-generate C headers from them?  That way
> > the format in which they can be edited is decoupled from the
> > representation in the kernel image.
> 
> Well, I don't really have an opinion on that part.
> 
> In the meantime, I got another idea for doubling the saving to 8k. It
> requires a few more code changes and is perhaps also more hacky. 2/2
> would be something like below. Please let me know which version you'd
> prefer, and I'll send both patches properly.

I don't think the new version is too bad, and the saving is impressive.
So I'd opt for the new one.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/3] scsi: drop unlikely behind BUG_ON()

2015-10-04 Thread Geliang Tang 
BUG_ON() already contain an unlikely compiler flag. Drop it.

Signed-off-by: Geliang Tang 
---
 drivers/scsi/scsi_lib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index f570b48..3b5faab 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -1164,8 +1164,8 @@ int scsi_init_io(struct scsi_cmnd *cmd)
 
count = blk_rq_map_integrity_sg(rq->q, rq->bio,
prot_sdb->table.sgl);
-   BUG_ON(unlikely(count > ivecs));
-   BUG_ON(unlikely(count > queue_max_integrity_segments(rq->q)));
+   BUG_ON(count > ivecs);
+   BUG_ON(count > queue_max_integrity_segments(rq->q));
 
cmd->prot_sdb = prot_sdb;
cmd->prot_sdb->table.nents = count;
-- 
2.5.0


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Bugs in multipath scsi in 4.3-rc2

2015-10-04 Thread Christoph Hellwig 
On Fri, Oct 02, 2015 at 06:44:57AM -0700, James Bottomley wrote:
> I think I prefer restoring that to having to build in every dh module to
> get them to work.  If we take your proposed fix for the sync module load
> in the current scheme, any non-built in modules would never attach, so
> we'd be moving towards the conclusion that *every* device handler has to
> be non-modular.

You don't need to build every module in to make it work.  In 4.2 and earlier
we already only auto load modules when dm-multipath explicitly attaches
to them.  That will still work in 4.3+.  In fact we will now autoload
when activating through sysfs as well.  With the change I sent to Paul
we still won't autoload at scan time, which would be really useful to have,
but wasn't implemented previously.

> Skimming the code it looks like dh should be using the driver binding
> model rather than reinventing it.  That would decouple it better and
> make sure binding happened regardless of when the module was loaded.

I tried this early on but gave up because I ran into too many problems.
I can try to give it a spin again.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [REGRESSION v4.3] scsi_dh: use-after-free when removing scsi device

2015-10-04 Thread Christoph Hellwig 
On Thu, Oct 01, 2015 at 11:40:23AM +, Junichi Nomura wrote:
> On 10/01/15 14:21, Christoph Hellwig wrote:
> > Any chance you could share all your multipath tests in a git repository
> > somewhere?  It seems like you're the only one actually having a good
> > set of reproducable but minimalistic tests.
> 
> Hmm, sorry I don't have a public git repository...
> 
> I'm using a pair of KVM guest, one for iSCSI target and the other
> for testing.

Any chance you could share your various scripts in some way to that
people doing multipath changes can run them to verify those changes?

> 
> I could reproduce the crash using this loop, within a few minutes:
> 
>service multipathd start
>while true; do
>  multipath -F
>  iscsiadm -m node --logout
>  iscsiadm -m node --login
>done
> 
> It might implicitly depend on udev to do some small amount of I/O
> after device uevent though.

I can't reproduce this unfortunately.  I suspect udev doesn't do enough
stupid things on my old Debian test system.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [REGRESSION v4.3] scsi_dh: use-after-free when removing scsi device

2015-10-04 Thread Christoph Hellwig 
This patch looks fine to me:

Acked-by: Christoph Hellwig 
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] scsi: drop unlikely behind BUG_ON()

2015-10-04 Thread Bart Van Assche 

On 10/03/15 23:18, Geliang Tang wrote:

BUG_ON() already contain an unlikely compiler flag. Drop it.

Signed-off-by: Geliang Tang 


Reviewed-by: Bart Van Assche 

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] scsi: dpt: remove i2o header in uapi

2015-10-04 Thread Arnd Bergmann 
On Sunday 04 October 2015 01:22:50 Gabriel Laskar wrote:
> The i2o subsystem was removed by
> commit 4a72a7af462d ("staging: remove i2o subsystem") but the header was
> still used by drivers/scsi/dpt_i2o.c driver.
> 
> This patch moves the structures used from the header into dpti_i2o.h.
> 
> CC: Arnd Bergmann 
> CC: Greg Kroah-Hartman 
> Signed-off-by: Gabriel Laskar 
> 

Acked-by: Arnd Bergmann 
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html