RE: [PATCH] - MPT FUSION - SPLITTING SCSI HOST DRIVERS
On Saturday, March 26, 2005 4:21 AM, Christoph Hellwig wrote: I took a quick look an a here's a few comments: - I don't think renaming mptscsih.c to mpt_core.c makes sense. the new name is confusing at best, and keeping the old name allows to keep SCCS history aswell. That means the new SPI stub driver should be called mptspi or something like that. Ok fine. I was wondering whether I should be providing a patch for all the defconfig files down in the arch branch with CONFIG_FUSION=m , so our new drivers(mptspi and mptfc) would be getting compiled into default configurations? - please don't link mpt_core.o into both mptfch.ko and mptscsih.ko but make it a module of it's own I'm not clear on this request. Do you want me to add the mptscsih.ko module back, with module_init and module_exit functions? Thus when someone is either loading mptspi.ko/mptfc.ko, then they would need to load mptscsih.ko as well as mptbase.ko? Bottom line, three drivers loaded for either FC or SPI. Just wondering whether keeping the naming of mptscsih.ko driver would cause any problems. - the new driver shoild use module_param, not MODULE_PARM I'll fix it. - why does the fc driver set ioc-spi_data.mpt_pq_filter? Yes - this appplies to fiber. It was requested by engenio, to prevent seeing a dummy Lun. I probably confused you when I saved this command line options in the spi_data member. Fine, I will save mpt_pq_filter somewhere else. - no need to forward-declare the module_init/module_exit handlers Fine - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] - MPT FUSION - SPLITTING SCSI HOST DRIVERS
I took a quick look an a here's a few comments: - I don't think renaming mptscsih.c to mpt_core.c makes sense. the new name is confusing at best, and keeping the old name allows to keep SCCS history aswell. That means the new SPI stub driver should be called mptspi or something like that. - please don't link mpt_core.o into both mptfch.ko and mptscsih.ko but make it a module of it's own - the new driver shoild use module_param, not MODULE_PARM - why does the fc driver set ioc-spi_data.mpt_pq_filter? - no need to forward-declare the module_init/module_exit handlers - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] - MPT FUSION - SPLITTING SCSI HOST DRIVERS
Here are several patches(7) which follow this email. These patches are for the mpt fusion scsi host drivers, which separate the scsi host drivers into separate bus type kernel modules. This was requested by several people on the linux-scsi@ forum, so our driver can properly support the various transport layers; e.g. SPI, FC, and eventually SAS. In these set of patches the Fiber Channel controllers are moved to a new driver called mptfch.ko. The current Parallel SCSI controllers will remain with mptscsih.ko. Eventually we will be adding SAS support in the new modules that will be mptsash.ko. Overview of patches (1) mptlinux-3.03.00-1-misc - Kconfig and Makefile changes, for new separated drivers. (2) mptlinux-3.03.00-2-mptscsih-c - delete mptscsih.c , code moved to mptcore.c (3) mptlinux-3.03.00-3-mptscsih-h - delete mptscsih.h, code moved to mptscsi.h (4) mptlinux-3.03.00-4-mpt-core-c - formerly mptscsih.c. This will be compiled linked between mptscsi.c and mptfc.c (5) mptlinux-3.03.00-5-mptscsi-h - formerly mptscsih.c (6) mptlinux-3.03.00-6-mptscsi-c - SPI driver, having only module_init, module_exit, and probe. (7) mptlinux-3.03.00-7-mptfc-c - FC driver, having only module_init, module_exit, and probe. Please apply this patch against the 3.01.20 version of the mpt driver in http://linux-scsi.bkbits.net:8080/scsi-misc-2.6 Backup of these patches can be found at this ftp: ftp://ftp.lsil.com/HostAdapterDrivers/linux/Fusion-MPT/2.6-kernel/3.03.00/ Signed-off-by: Eric Moore [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html