[PATCH] SCSI: Get SG_ALL out of the way

2007-08-09 Thread Boaz Harrosh
Jens hi playing with sglist and iscsi I stumbled on this.
You might want to add it to the sglist tree. Or maybe
James wants to include it for next merge window.

===

  - Some 50 scsi drivers use SG_ALL for their .sg_tablesize
So a value of 255 is a bit specific. Change it to ~0
as meaning MAX_ what ever unsigned type it will ever be.

Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
---
 include/scsi/scsi_host.h |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
index 88f6871..b84a4eb 100644
--- a/include/scsi/scsi_host.h
+++ b/include/scsi/scsi_host.h
@@ -30,7 +30,7 @@ struct blk_queue_tags;
  *  used in one scatter-gather request.
  */
 #define SG_NONE 0
-#define SG_ALL 0xff
+#define SG_ALL (~0)
 
 
 #define DISABLE_CLUSTERING 0
-- 
1.5.2.2.249.g45fd

-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] SCSI: Get SG_ALL out of the way

2007-08-09 Thread Boaz Harrosh
Boaz Harrosh wrote:
 Jens hi playing with sglist and iscsi I stumbled on this.
 You might want to add it to the sglist tree. Or maybe
 James wants to include it for next merge window.
 
 ===
 
   - Some 50 scsi drivers use SG_ALL for their .sg_tablesize
 So a value of 255 is a bit specific. Change it to ~0
 as meaning MAX_ what ever unsigned type it will ever be.
 
 Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
 ---
  include/scsi/scsi_host.h |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 
 diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
 index 88f6871..b84a4eb 100644
 --- a/include/scsi/scsi_host.h
 +++ b/include/scsi/scsi_host.h
 @@ -30,7 +30,7 @@ struct blk_queue_tags;
   *used in one scatter-gather request.
   */
  #define SG_NONE 0
 -#define SG_ALL 0xff
 +#define SG_ALL (~0)
  
  
  #define DISABLE_CLUSTERING 0

Sorry about that patch. I just did a make allmodconfig and it 
appears that some drivers use this constant as an Array size.
I will submit a new Patch.

Boaz
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html