Use memdup_user() helper instead of open-coding to simplify the code.

Signed-off-by: Geliang Tang <geliangt...@gmail.com>
---
 drivers/block/cciss.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index cd37550..40ee715 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -1596,15 +1596,9 @@ static int cciss_bigpassthru(ctlr_info_t *h, void __user 
*argp)
                return -EINVAL;
        if (!capable(CAP_SYS_RAWIO))
                return -EPERM;
-       ioc = kmalloc(sizeof(*ioc), GFP_KERNEL);
-       if (!ioc) {
-               status = -ENOMEM;
-               goto cleanup1;
-       }
-       if (copy_from_user(ioc, argp, sizeof(*ioc))) {
-               status = -EFAULT;
-               goto cleanup1;
-       }
+       ioc = memdup_user(argp, sizeof(*ioc));
+       if (IS_ERR(ioc))
+               return PTR_ERR(ioc);
        if ((ioc->buf_size < 1) &&
            (ioc->Request.Type.Direction != XFER_NONE)) {
                status = -EINVAL;
-- 
2.9.3

Reply via email to