Re: [PATCH] libsas: fix sense_buffer overrun

2008-01-14 Thread Darrick J. Wong
Looks sane to me;
Acked-by: Darrick J. Wong [EMAIL PROTECTED]

--D

On Sun, Jan 13, 2008 at 02:20:18AM +0900, FUJITA Tomonori wrote:
 
 Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
 ---
  drivers/scsi/libsas/sas_scsi_host.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 
 diff --git a/drivers/scsi/libsas/sas_scsi_host.c 
 b/drivers/scsi/libsas/sas_scsi_host.c
 index b784089..828fed1 100644
 --- a/drivers/scsi/libsas/sas_scsi_host.c
 +++ b/drivers/scsi/libsas/sas_scsi_host.c
 @@ -108,7 +108,7 @@ static void sas_scsi_task_done(struct sas_task *task)
   break;
   case SAM_CHECK_COND:
   memcpy(sc-sense_buffer, ts-buf,
 -max(SCSI_SENSE_BUFFERSIZE, ts-buf_valid_size));
 +min(SCSI_SENSE_BUFFERSIZE, ts-buf_valid_size));
   stat = SAM_CHECK_COND;
   break;
   default:
 -- 
 1.5.3.4
 
 -
 To unsubscribe from this list: send the line unsubscribe linux-scsi in
 the body of a message to [EMAIL PROTECTED]
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] libsas: fix sense_buffer overrun

2008-01-12 Thread FUJITA Tomonori

Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
---
 drivers/scsi/libsas/sas_scsi_host.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/libsas/sas_scsi_host.c 
b/drivers/scsi/libsas/sas_scsi_host.c
index b784089..828fed1 100644
--- a/drivers/scsi/libsas/sas_scsi_host.c
+++ b/drivers/scsi/libsas/sas_scsi_host.c
@@ -108,7 +108,7 @@ static void sas_scsi_task_done(struct sas_task *task)
break;
case SAM_CHECK_COND:
memcpy(sc-sense_buffer, ts-buf,
-  max(SCSI_SENSE_BUFFERSIZE, ts-buf_valid_size));
+  min(SCSI_SENSE_BUFFERSIZE, ts-buf_valid_size));
stat = SAM_CHECK_COND;
break;
default:
-- 
1.5.3.4

-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html