Re: [PATCH] scsi: qedf: properly update arguments position in function call

[Gustavo A. R. Silva]

Hi Martin,

Quoting "Martin K. Petersen" :


Gustavo A.,


Properly update the position of the arguments in function call.


Applied to 4.12/scsi-fixes, thank you!



Awesome, glad to help. :)
--
Gustavo A. R. Silva

Re: [PATCH] scsi: qedf: properly update arguments position in function call

[Martin K. Petersen]

Gustavo A.,

> Properly update the position of the arguments in function call.

Applied to 4.12/scsi-fixes, thank you!

-- 
Martin K. Petersen  Oracle Linux Engineering

Re: [PATCH] scsi: qedf: properly update arguments position in function call

[Chad Dupuis]

On Wed, 3 May 2017, 3:17pm, Gustavo A. R. Silva wrote:

> Properly update the position of the arguments in function call.
> 
> Addresses-Coverity-ID: 1402010
> Signed-off-by: Gustavo A. R. Silva 
> ---
>  drivers/scsi/qedf/qedf_els.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qedf/qedf_els.c b/drivers/scsi/qedf/qedf_els.c
> index 59f3e5c..107ed2b 100644
> --- a/drivers/scsi/qedf/qedf_els.c
> +++ b/drivers/scsi/qedf/qedf_els.c
> @@ -106,7 +106,7 @@ static int qedf_initiate_els(struct qedf_rport *fcport, 
> unsigned int op,
>   did = fcport->rdata->ids.port_id;
>   sid = fcport->sid;
>  
> - __fc_fill_fc_hdr(fc_hdr, FC_RCTL_ELS_REQ, sid, did,
> + __fc_fill_fc_hdr(fc_hdr, FC_RCTL_ELS_REQ, did, sid,
>  FC_TYPE_ELS, FC_FC_FIRST_SEQ | FC_FC_END_SEQ |
>  FC_FC_SEQ_INIT, 0);
>  
> 

Thanks.

Acked-by: Chad Dupuis 

[PATCH] scsi: qedf: properly update arguments position in function call

[Gustavo A. R. Silva]

Properly update the position of the arguments in function call.

Addresses-Coverity-ID: 1402010
Signed-off-by: Gustavo A. R. Silva 
---
 drivers/scsi/qedf/qedf_els.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qedf/qedf_els.c b/drivers/scsi/qedf/qedf_els.c
index 59f3e5c..107ed2b 100644
--- a/drivers/scsi/qedf/qedf_els.c
+++ b/drivers/scsi/qedf/qedf_els.c
@@ -106,7 +106,7 @@ static int qedf_initiate_els(struct qedf_rport *fcport, 
unsigned int op,
did = fcport->rdata->ids.port_id;
sid = fcport->sid;
 
-   __fc_fill_fc_hdr(fc_hdr, FC_RCTL_ELS_REQ, sid, did,
+   __fc_fill_fc_hdr(fc_hdr, FC_RCTL_ELS_REQ, did, sid,
   FC_TYPE_ELS, FC_FC_FIRST_SEQ | FC_FC_END_SEQ |
   FC_FC_SEQ_INIT, 0);
 
-- 
2.5.0