Re: [PATCH] xen-scsifront: correct return value checks on xenbus_scanf()

[Juergen Gross]

On 07/07/16 10:01, Jan Beulich wrote:
> Only a positive return value indicates success.
> 
> Signed-off-by: Jan Beulich 

Acked-by: Juergen Gross 

> ---
>  drivers/scsi/xen-scsifront.c |4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- 4.7-rc6-xenbus_scanf.orig/drivers/scsi/xen-scsifront.c
> +++ 4.7-rc6-xenbus_scanf/drivers/scsi/xen-scsifront.c
> @@ -1000,14 +1000,14 @@ static void scsifront_do_lun_hotplug(str
>   snprintf(str, sizeof(str), "vscsi-devs/%s/state", dir[i]);
>   err = xenbus_scanf(XBT_NIL, dev->otherend, str, "%u",
>  _state);
> - if (XENBUS_EXIST_ERR(err))
> + if (err <= 0)
>   continue;
>  
>   /* virtual SCSI device */
>   snprintf(str, sizeof(str), "vscsi-devs/%s/v-dev", dir[i]);
>   err = xenbus_scanf(XBT_NIL, dev->otherend, str,
>  "%u:%u:%u:%u", , , , );
> - if (XENBUS_EXIST_ERR(err))
> + if (err != 4)
>   continue;
>  
>   /*
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] xen-scsifront: correct return value checks on xenbus_scanf()

[Jan Beulich]

Only a positive return value indicates success.

Signed-off-by: Jan Beulich 
---
 drivers/scsi/xen-scsifront.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- 4.7-rc6-xenbus_scanf.orig/drivers/scsi/xen-scsifront.c
+++ 4.7-rc6-xenbus_scanf/drivers/scsi/xen-scsifront.c
@@ -1000,14 +1000,14 @@ static void scsifront_do_lun_hotplug(str
snprintf(str, sizeof(str), "vscsi-devs/%s/state", dir[i]);
err = xenbus_scanf(XBT_NIL, dev->otherend, str, "%u",
   _state);
-   if (XENBUS_EXIST_ERR(err))
+   if (err <= 0)
continue;
 
/* virtual SCSI device */
snprintf(str, sizeof(str), "vscsi-devs/%s/v-dev", dir[i]);
err = xenbus_scanf(XBT_NIL, dev->otherend, str,
   "%u:%u:%u:%u", , , , );
-   if (XENBUS_EXIST_ERR(err))
+   if (err != 4)
continue;
 
/*



--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html