[PATCH 00/10] Re-implement am53c974 driver
Hi all, having found some issues with the current tmscsim driver I looked at the code and found is really awkward to clean up. Seeing that the am53c974 chip is actually based on the 'ESP' chip design I've re-implemented it based on the common esp_scsi routines. This new driver (cunningly named 'am53c974') provides all features found on the tmscsim driver, with the goal of obsoleting the old tmscsim driver. Tested with Tekram DC390 and qemu esp-scsi. Hannes Reinecke (10): esp_scsi: spellcheck 'driver' esp_scsi: make number of tags configurable esp_scsi: convert to dev_printk esp_scsi: debug event and command esp_scsi: read status registers scsi: add 'am53c974' driver esp: Use FIFO for command submission am53c974: BLAST residual handling esp: correctly detect am53c974 esp: enable CONFIG2_FENAB for am53c974 drivers/scsi/Kconfig| 18 ++ drivers/scsi/Makefile | 1 + drivers/scsi/am53c974.c | 562 drivers/scsi/esp_scsi.c | 378 drivers/scsi/esp_scsi.h | 22 +- 5 files changed, 843 insertions(+), 138 deletions(-) create mode 100644 drivers/scsi/am53c974.c -- 1.8.5.2 -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/10] Re-implement am53c974 driver
On Fri, Nov 21, 2014 at 10:27:47AM +0100, Hannes Reinecke wrote: Hi all, having found some issues with the current tmscsim driver I looked at the code and found is really awkward to clean up. Seeing that the am53c974 chip is actually based on the 'ESP' chip design I've re-implemented it based on the common esp_scsi routines. This new driver (cunningly named 'am53c974') provides all features found on the tmscsim driver, with the goal of obsoleting the old tmscsim driver. Tested with Tekram DC390 and qemu esp-scsi. This looks very nice! Three high level comments: - please Cc Dave for changes to esp_scsi - please Cc Guennadi as the tmscsim maintainer - this probably should deprecated and/or remove the tmscsim driver -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/10] Re-implement am53c974 driver
On 11/21/2014 11:26 AM, Christoph Hellwig wrote: On Fri, Nov 21, 2014 at 10:27:47AM +0100, Hannes Reinecke wrote: Hi all, having found some issues with the current tmscsim driver I looked at the code and found is really awkward to clean up. Seeing that the am53c974 chip is actually based on the 'ESP' chip design I've re-implemented it based on the common esp_scsi routines. This new driver (cunningly named 'am53c974') provides all features found on the tmscsim driver, with the goal of obsoleting the old tmscsim driver. Tested with Tekram DC390 and qemu esp-scsi. This looks very nice! Three high level comments: - please Cc Dave for changes to esp_scsi That's what I thought, too, but 'get_maintainers.pl' doesn't know about him. Maybe we should fix this up ... - please Cc Guennadi as the tmscsim maintainer - this probably should deprecated and/or remove the tmscsim driver That was the general idea. I just thought to be conservative and add a new driver. But yeah, the idea is to sent another patch to remove tmscsim altogether. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/10] Re-implement am53c974 driver
Hi, On Fri, 21 Nov 2014, Hannes Reinecke wrote: On 11/21/2014 11:26 AM, Christoph Hellwig wrote: On Fri, Nov 21, 2014 at 10:27:47AM +0100, Hannes Reinecke wrote: Hi all, having found some issues with the current tmscsim driver I looked at the code and found is really awkward to clean up. Seeing that the am53c974 chip is actually based on the 'ESP' chip design I've re-implemented it based on the common esp_scsi routines. This new driver (cunningly named 'am53c974') provides all features found on the tmscsim driver, with the goal of obsoleting the old tmscsim driver. Tested with Tekram DC390 and qemu esp-scsi. This looks very nice! Three high level comments: - please Cc Dave for changes to esp_scsi That's what I thought, too, but 'get_maintainers.pl' doesn't know about him. Maybe we should fix this up ... - please Cc Guennadi as the tmscsim maintainer - this probably should deprecated and/or remove the tmscsim driver That was the general idea. I just thought to be conservative and add a new driver. But yeah, the idea is to sent another patch to remove tmscsim altogether. Sure, the driver is rather old and... well... its style is somewhat foreign to the modern Linux kernel coding style :) I actually also thought, that the hardware is really legacy and hardly anyone is still using it, so the tmscsim driver was in a bug-fix only mode, but if you want to replace it with a better written one - certainly go for it! I've hardly had any work with this my maintainer task in the last few years, except for a recent SCSI Tag rehash, but that was committed before I had enough time to sufficiently understand them :) And I'm not using that hardware actively any more these days... So, I'd have nothing against removal of tmscsim and, respectively, from its entry in MAINTAINERS :) Thanks Guennadi -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
