Re: [PATCH 12/12] Replace tmscsim by am53c974

2014-11-23 Thread Guennadi Liakhovetski
On Fri, 21 Nov 2014, Hannes Reinecke wrote:

 The am53c974 is a re-implementation of the tmscsim driver,
 and provides the same functionality.
 So remove the tmscsim driver and make am53c974 an alias to tmscsim.
 
 Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de
 Signed-off-by: Hannes Reinecke h...@suse.de
 ---
  MAINTAINERS |7 +-
  drivers/scsi/Kconfig|   16 -
  drivers/scsi/Makefile   |1 -
  drivers/scsi/am53c974.c |1 +
  drivers/scsi/tmscsim.c  | 2626 
 ---
  drivers/scsi/tmscsim.h  |  549 --
  6 files changed, 4 insertions(+), 3196 deletions(-)
  delete mode 100644 drivers/scsi/tmscsim.c
  delete mode 100644 drivers/scsi/tmscsim.h
 
 diff --git a/MAINTAINERS b/MAINTAINERS
 index d206f37..d780e46 100644
 --- a/MAINTAINERS
 +++ b/MAINTAINERS
 @@ -2862,11 +2862,10 @@ F:Documentation/networking/dmfe.txt
  F:   drivers/net/ethernet/dec/tulip/dmfe.c
  
  DC390/AM53C974 SCSI driver
 -M:   Kurt Garloff garl...@suse.de
 -W:   http://www.garloff.de/kurt/linux/dc390/
 -M:   Guennadi Liakhovetski g.liakhovet...@gmx.de
 +M:   Hannes Reinecke h...@suse.de
 +L:   linux-scsi@vger.kernel.org
  S:   Maintained
 -F:   drivers/scsi/tmscsim.*
 +F:   drivers/scsi/am53c974.c
  
  DC395x SCSI driver
  M:   Oliver Neukum oli...@neukum.org

Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de

Thanks
Guennadi

 diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
 index 519c3ef..f871a80 100644
 --- a/drivers/scsi/Kconfig
 +++ b/drivers/scsi/Kconfig
 @@ -1341,22 +1341,6 @@ config SCSI_DC395x
 To compile this driver as a module, choose M here: the
 module will be called dc395x.
  
 -config SCSI_DC390T
 - tristate Tekram DC390(T) and Am53/79C974 SCSI support
 - depends on PCI  SCSI
 - ---help---
 -   This driver supports PCI SCSI host adapters based on the Am53C974A
 -   chip, e.g. Tekram DC390(T), DawiControl 2974 and some onboard
 -   PCscsi/PCnet (Am53/79C974) solutions.
 -
 -   Documentation can be found in file:Documentation/scsi/tmscsim.txt.
 -
 -   Note that this driver does NOT support Tekram DC390W/U/F, which are
 -   based on NCR/Symbios chips. Use NCR53C8XX SCSI support for those.
 -
 -   To compile this driver as a module, choose M here: the
 -   module will be called tmscsim.
 -
  config SCSI_AM53C974
   tristate Tekram DC390(T) and Am53/79C974 SCSI support (new driver)
   depends on PCI  SCSI
 diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile
 index 79a6571..a9f3fa8 100644
 --- a/drivers/scsi/Makefile
 +++ b/drivers/scsi/Makefile
 @@ -100,7 +100,6 @@ obj-$(CONFIG_SCSI_EATA_PIO)   += eata_pio.o
  obj-$(CONFIG_SCSI_7000FASST) += wd7000.o
  obj-$(CONFIG_SCSI_EATA)  += eata.o
  obj-$(CONFIG_SCSI_DC395x)+= dc395x.o
 -obj-$(CONFIG_SCSI_DC390T)+= tmscsim.o
  obj-$(CONFIG_SCSI_AM53C974)  += esp_scsi.o   am53c974.o
  obj-$(CONFIG_MEGARAID_LEGACY)+= megaraid.o
  obj-$(CONFIG_MEGARAID_NEWGEN)+= megaraid/
 diff --git a/drivers/scsi/am53c974.c b/drivers/scsi/am53c974.c
 index 55622eb..5ce2bb2 100644
 --- a/drivers/scsi/am53c974.c
 +++ b/drivers/scsi/am53c974.c
 @@ -572,6 +572,7 @@ MODULE_DESCRIPTION(AM53C974 SCSI driver);
  MODULE_AUTHOR(Hannes Reinecke h...@suse.de);
  MODULE_LICENSE(GPL);
  MODULE_VERSION(DRV_MODULE_VERSION);
 +MODULE_ALIAS(tmscsim);
  
  module_param(am53c974_fenab, bool, 0444);
  MODULE_PARM_DESC(am53c974_fenab, Enable 24-bit DMA transfer sizes);
 diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c
 deleted file mode 100644
 index 844c9a0..000
 --- a/drivers/scsi/tmscsim.c
 +++ /dev/null
 @@ -1,2626 +0,0 @@
 -/
 - *   FILE NAME : TMSCSIM.C   *
 - *BY   : C.L. Huang,  ch...@tekram.com.tw*
 - *   Description: Device Driver for Tekram DC-390(T) PCI SCSI*
 - *Bus Master Host Adapter*
 - * (C)Copyright 1995-1996 Tekram Technology Co., Ltd.
 *
 - 
 - * (C) Copyright: put under GNU GPL in 10/96 *
 - *   (see Documentation/scsi/tmscsim.txt)*
 - 
 - * $Id: tmscsim.c,v 2.60.2.30 2000/12/20 01:07:12 garloff Exp $  
 *
 - *   Enhancements and bugfixes by*
 - *   Kurt Garloff k...@garloff.de  garl...@suse.de   *
 - 
 - *   HISTORY:*
 - *   *
 - *   REV#DATENAMEDESCRIPTION *
 - *   1.00  96/04/24  CLH First 

Re: [PATCH 12/12] Replace tmscsim by am53c974

2014-11-23 Thread David Miller

Please do not _EVER_ quote an entire huge patch just to add a signoff
or ACK.

This wastes tons of mailing list resources because it means that
the entire huge patch is sent once again to every single recipient
on the mailing list.

Instead, just at most quote the commit message, then add your
ACK, and remove the patch from the quoted material entirely.

Thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 12/12] Replace tmscsim by am53c974

2014-11-21 Thread Hannes Reinecke
The am53c974 is a re-implementation of the tmscsim driver,
and provides the same functionality.
So remove the tmscsim driver and make am53c974 an alias to tmscsim.

Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de
Signed-off-by: Hannes Reinecke h...@suse.de
---
 MAINTAINERS |7 +-
 drivers/scsi/Kconfig|   16 -
 drivers/scsi/Makefile   |1 -
 drivers/scsi/am53c974.c |1 +
 drivers/scsi/tmscsim.c  | 2626 ---
 drivers/scsi/tmscsim.h  |  549 --
 6 files changed, 4 insertions(+), 3196 deletions(-)
 delete mode 100644 drivers/scsi/tmscsim.c
 delete mode 100644 drivers/scsi/tmscsim.h

diff --git a/MAINTAINERS b/MAINTAINERS
index d206f37..d780e46 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2862,11 +2862,10 @@ F:  Documentation/networking/dmfe.txt
 F: drivers/net/ethernet/dec/tulip/dmfe.c
 
 DC390/AM53C974 SCSI driver
-M: Kurt Garloff garl...@suse.de
-W: http://www.garloff.de/kurt/linux/dc390/
-M: Guennadi Liakhovetski g.liakhovet...@gmx.de
+M: Hannes Reinecke h...@suse.de
+L: linux-scsi@vger.kernel.org
 S: Maintained
-F: drivers/scsi/tmscsim.*
+F: drivers/scsi/am53c974.c
 
 DC395x SCSI driver
 M: Oliver Neukum oli...@neukum.org
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 519c3ef..f871a80 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -1341,22 +1341,6 @@ config SCSI_DC395x
  To compile this driver as a module, choose M here: the
  module will be called dc395x.
 
-config SCSI_DC390T
-   tristate Tekram DC390(T) and Am53/79C974 SCSI support
-   depends on PCI  SCSI
-   ---help---
- This driver supports PCI SCSI host adapters based on the Am53C974A
- chip, e.g. Tekram DC390(T), DawiControl 2974 and some onboard
- PCscsi/PCnet (Am53/79C974) solutions.
-
- Documentation can be found in file:Documentation/scsi/tmscsim.txt.
-
- Note that this driver does NOT support Tekram DC390W/U/F, which are
- based on NCR/Symbios chips. Use NCR53C8XX SCSI support for those.
-
- To compile this driver as a module, choose M here: the
- module will be called tmscsim.
-
 config SCSI_AM53C974
tristate Tekram DC390(T) and Am53/79C974 SCSI support (new driver)
depends on PCI  SCSI
diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile
index 79a6571..a9f3fa8 100644
--- a/drivers/scsi/Makefile
+++ b/drivers/scsi/Makefile
@@ -100,7 +100,6 @@ obj-$(CONFIG_SCSI_EATA_PIO) += eata_pio.o
 obj-$(CONFIG_SCSI_7000FASST)   += wd7000.o
 obj-$(CONFIG_SCSI_EATA)+= eata.o
 obj-$(CONFIG_SCSI_DC395x)  += dc395x.o
-obj-$(CONFIG_SCSI_DC390T)  += tmscsim.o
 obj-$(CONFIG_SCSI_AM53C974)+= esp_scsi.o   am53c974.o
 obj-$(CONFIG_MEGARAID_LEGACY)  += megaraid.o
 obj-$(CONFIG_MEGARAID_NEWGEN)  += megaraid/
diff --git a/drivers/scsi/am53c974.c b/drivers/scsi/am53c974.c
index 55622eb..5ce2bb2 100644
--- a/drivers/scsi/am53c974.c
+++ b/drivers/scsi/am53c974.c
@@ -572,6 +572,7 @@ MODULE_DESCRIPTION(AM53C974 SCSI driver);
 MODULE_AUTHOR(Hannes Reinecke h...@suse.de);
 MODULE_LICENSE(GPL);
 MODULE_VERSION(DRV_MODULE_VERSION);
+MODULE_ALIAS(tmscsim);
 
 module_param(am53c974_fenab, bool, 0444);
 MODULE_PARM_DESC(am53c974_fenab, Enable 24-bit DMA transfer sizes);
diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c
deleted file mode 100644
index 844c9a0..000
--- a/drivers/scsi/tmscsim.c
+++ /dev/null
@@ -1,2626 +0,0 @@
-/
- * FILE NAME : TMSCSIM.C   *
- *  BY   : C.L. Huang,  ch...@tekram.com.tw*
- * Description: Device Driver for Tekram DC-390(T) PCI SCSI*
- *  Bus Master Host Adapter*
- * (C)Copyright 1995-1996 Tekram Technology Co., Ltd.  *
- 
- * (C) Copyright: put under GNU GPL in 10/96   *
- * (see Documentation/scsi/tmscsim.txt)*
- 
- * $Id: tmscsim.c,v 2.60.2.30 2000/12/20 01:07:12 garloff Exp $
*
- * Enhancements and bugfixes by*
- * Kurt Garloff k...@garloff.de  garl...@suse.de   *
- 
- * HISTORY:*
- * *
- * REV#DATENAMEDESCRIPTION *
- * 1.00  96/04/24  CLH First release   *
- * 1.01  96/06/12  CLH Fixed bug of Media Change for Removable *
- * Device, scan all LUN. Support