[PATCH trivial] include linux/mutex.h from scsi_transport_iscsi.h
scsi/scsi_transport_iscsi.h uses struct mutex, so while linux/mutex.h seems to be pulled in indirectly by one of the headers it includes, the right thing is to include linux/mutex.h directly. Signed-off-by: Michael S. Tsirkin [EMAIL PROTECTED] --- diff --git a/include/scsi/scsi_transport_iscsi.h b/include/scsi/scsi_transport_iscsi.h index 706c0cd..7530e98 100644 --- a/include/scsi/scsi_transport_iscsi.h +++ b/include/scsi/scsi_transport_iscsi.h @@ -24,6 +24,7 @@ #define SCSI_TRANSPORT_ISCSI_H #include linux/device.h +#include linux/mutex.h #include scsi/iscsi_if.h struct scsi_transport_template; -- MST - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH trivial] include linux/mutex.h from scsi_transport_iscsi.h
Michael S. Tsirkin wrote: scsi/scsi_transport_iscsi.h uses struct mutex, so while linux/mutex.h seems to be pulled in indirectly by one of the headers it includes, the right thing is to include linux/mutex.h directly. Is that part about always including the header directly right? If so then were you going to include list.h too, and were you going to fix up some of the other iscsi code? - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH trivial] include linux/mutex.h from scsi_transport_iscsi.h
Quoting Mike Christie [EMAIL PROTECTED]: Subject: Re: [PATCH trivial] include linux/mutex.h from scsi_transport_iscsi.h Michael S. Tsirkin wrote: scsi/scsi_transport_iscsi.h uses struct mutex, so while linux/mutex.h seems to be pulled in indirectly by one of the headers it includes, the right thing is to include linux/mutex.h directly. Is that part about always including the header directly right? Think so. Analogous patches by me has been accepted in various subsystems. See e.g. f8916c11a4dc4cb2367e9bee1788f4e0f1b4eabc. If so then were you going to include list.h too, Makes sense. I'll repost. and were you going to fix up some of the other iscsi code? Not at the moment. The reason I noticed this is because I'm doing some other project. I'll post patches for other files if/when I notice any issues. -- MST - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
