Re: [PATCH v2 05/16] iscsi-target: add void (*iscsit_get_rx_pdu)()

[Sagi Grimberg]

Add void (*iscsit_get_rx_pdu)() to
struct iscsit_transport, iscsi-target
uses this callback to receive and
process Rx iSCSI PDUs.


Same comment on change logs.

The iser bit looks harmless

Acked-by: Sagi Grimberg 

Though I agree with hch that we don't really need
rx threads in iSER, but that's another story...
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 05/16] iscsi-target: add void (*iscsit_get_rx_pdu)()

[Varun Prakash]

Add void (*iscsit_get_rx_pdu)() to
struct iscsit_transport, iscsi-target
uses this callback to receive and
process Rx iSCSI PDUs.

Signed-off-by: Varun Prakash 
---
 drivers/infiniband/ulp/isert/ib_isert.c | 10 ++
 drivers/target/iscsi/iscsi_target.c | 10 ++
 include/target/iscsi/iscsi_transport.h  |  1 +
 3 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/drivers/infiniband/ulp/isert/ib_isert.c 
b/drivers/infiniband/ulp/isert/ib_isert.c
index 411e446..9118d7c 100644
--- a/drivers/infiniband/ulp/isert/ib_isert.c
+++ b/drivers/infiniband/ulp/isert/ib_isert.c
@@ -3273,6 +3273,15 @@ static void isert_free_conn(struct iscsi_conn *conn)
isert_put_conn(isert_conn);
 }
 
+static void isert_get_rx_pdu(struct iscsi_conn *conn)
+{
+   struct completion comp;
+
+   init_completion();
+
+   wait_for_completion_interruptible();
+}
+
 static struct iscsit_transport iser_target_transport = {
.name   = "IB/iSER",
.transport_type = ISCSI_INFINIBAND,
@@ -3291,6 +3300,7 @@ static struct iscsit_transport iser_target_transport = {
.iscsit_queue_data_in   = isert_put_datain,
.iscsit_queue_status= isert_put_response,
.iscsit_aborted_task= isert_aborted_task,
+   .iscsit_get_rx_pdu  = isert_get_rx_pdu,
.iscsit_get_sup_prot_ops = isert_get_sup_prot_ops,
 };
 
diff --git a/drivers/target/iscsi/iscsi_target.c 
b/drivers/target/iscsi/iscsi_target.c
index 9e65e5d..4311636 100644
--- a/drivers/target/iscsi/iscsi_target.c
+++ b/drivers/target/iscsi/iscsi_target.c
@@ -3989,14 +3989,8 @@ int iscsi_target_rx_thread(void *arg)
if (rc < 0 || iscsi_target_check_conn_state(conn))
return 0;
 
-   if (conn->conn_transport->transport_type == ISCSI_INFINIBAND) {
-   struct completion comp;
-
-   init_completion();
-   rc = wait_for_completion_interruptible();
-   if (rc < 0)
-   goto transport_err;
-
+   if (conn->conn_transport->iscsit_get_rx_pdu) {
+   conn->conn_transport->iscsit_get_rx_pdu(conn);
goto transport_err;
}
 
diff --git a/include/target/iscsi/iscsi_transport.h 
b/include/target/iscsi/iscsi_transport.h
index 19cef94..1f63d8c 100644
--- a/include/target/iscsi/iscsi_transport.h
+++ b/include/target/iscsi/iscsi_transport.h
@@ -30,6 +30,7 @@ struct iscsit_transport {
  struct iscsi_datain_req *,
  struct iscsi_datain *);
void (*iscsit_release_cmd)(struct iscsi_conn *, struct iscsi_cmd *);
+   void (*iscsit_get_rx_pdu)(struct iscsi_conn *);
enum target_prot_op (*iscsit_get_sup_prot_ops)(struct iscsi_conn *);
 };
 
-- 
2.0.2

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html