Re: [Xen-devel] [patch] xen-scsifront: use GFP_ATOMIC under spin_lock

[Juergen Gross]

On 09/08/2014 01:15 PM, Dan Carpenter wrote:

This function is only called with a spin_lock held and IRQs disabled.
The allocation is not allowed to sleep and NOIO is not sufficient, it
has to be ATOMIC.

Signed-off-by: Dan Carpenter dan.carpen...@oracle.com


Reviewed-by: Juergen Gross jgr...@suse.com

Thanks,

Juergen



diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c
index 0aceb70..7e88659 100644
--- a/drivers/scsi/xen-scsifront.c
+++ b/drivers/scsi/xen-scsifront.c
@@ -359,7 +359,7 @@ static int map_data_for_request(struct vscsifrnt_info *info,
}
seg_grants = vscsiif_grants_sg(data_grants);
shadow-sg = kcalloc(data_grants,
-   sizeof(struct scsiif_request_segment), GFP_NOIO);
+   sizeof(struct scsiif_request_segment), GFP_ATOMIC);
if (!shadow-sg)
return -ENOMEM;
}

___
Xen-devel mailing list
xen-de...@lists.xen.org
http://lists.xen.org/xen-devel



--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [Xen-devel] [patch] xen-scsifront: use GFP_ATOMIC under spin_lock

[David Vrabel]

On 08/09/14 12:15, Dan Carpenter wrote:
 This function is only called with a spin_lock held and IRQs disabled.
 The allocation is not allowed to sleep and NOIO is not sufficient, it
 has to be ATOMIC.

Applied this and the scsiback one to devel/for-linus-3.18.

Thanks.

David
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html