RE: [PATCH 16/37] smartpqi: minor driver cleanup

2017-05-03 Thread Don Brace
> -Original Message-
> From: Bart Van Assche [mailto:bart.vanass...@sandisk.com]
> Sent: Tuesday, April 25, 2017 3:10 PM
> To: h...@infradead.org; Viswas G <viswa...@microsemi.com>; Gerry
> Morong <gerry.mor...@microsemi.com>; Mahesh Rajashekhara
> <mahesh.rajashekh...@microsemi.com>; posw...@suse.com; Scott
> Benesh <scott.ben...@microsemi.com>; Don Brace
> <don.br...@microsemi.com>; Bader Ali - Saleh
> <bader.alisa...@microsemi.com>; Kevin Barnett
> <kevin.barn...@microsemi.com>; joseph.szczy...@hpe.com; Scott Teel
> <scott.t...@microsemi.com>; j...@linux.vnet.ibm.com; Justin Lindley
> <justin.lind...@microsemi.com>; John Hall <john.h...@microsemi.com>
> Cc: linux-scsi@vger.kernel.org
> Subject: Re: [PATCH 16/37] smartpqi: minor driver cleanup
> 
> EXTERNAL EMAIL
> 
> 
> On Tue, 2017-04-25 at 14:47 -0500, Don Brace wrote:
> > From: Kevin Barnett <kevin.barn...@hpe.com>
> >
> > - align with in-house driver
> 
> This is not an appropriate patch description. A patch description should
> explain what has been changed and also what the purpose is of these
> changes.
> 
> Thanks,
> 
> Bart.

Agreed, added patch description

Thanks,
Don Brace
ESC - Smart Storage
Microsemi Corporation




Re: [PATCH 16/37] smartpqi: minor driver cleanup

2017-04-25 Thread Bart Van Assche
On Tue, 2017-04-25 at 14:47 -0500, Don Brace wrote:
> From: Kevin Barnett 
> 
> - align with in-house driver

This is not an appropriate patch description. A patch description should
explain what has been changed and also what the purpose is of these changes.

Thanks,

Bart.