Re: [PATCH] lpfc: Fix nvme io stoppage after link bounce

2017-06-26 Thread Martin K. Petersen 

James,

> On link down, transport is calling driver to abort outstanding ios.
> Driver erroneously rejects the abort if the port indicates it isn't
> logged in - which will be the case after the link down. Thus, the io
> can't clean up. This prevents reconnection at the transport level.
>
> Fix by allowing abort to proceed.

Applied to 4.13/scsi-queue, thanks!

-- 
Martin K. Petersen  Oracle Linux Engineering

Re: [PATCH] lpfc: Fix nvme io stoppage after link bounce

2017-06-22 Thread Johannes Thumshirn 
On Thu, Jun 22, 2017 at 08:52:14AM -0700, James Smart wrote:
> well, the primary reason is the code that was removed was bogus to begin
> with. Abort of an io/exchange, if its active, needs to occur on the link
> regardless of the ndlp state. This it simply needed to occur. As not checks
> on ndlp state are needed, there is no race.

Thanks for the explanation

-- 
Johannes Thumshirn  Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Re: [PATCH] lpfc: Fix nvme io stoppage after link bounce

2017-06-22 Thread James Smart 

On 6/22/2017 12:41 AM, Johannes Thumshirn wrote:

On Wed, Jun 21, 2017 at 10:37:58AM -0700, James Smart wrote:
[...]

-   /*
-* Catch race where our node has transitioned, but the
-* transport is still transitioning.
-*/



The patch looks fine but can you please explain why the above race can't
happen anymore?

Thanks,
Reviewed-by: Johannes Thumshirn 



well, the primary reason is the code that was removed was bogus to begin 
with. Abort of an io/exchange, if its active, needs to occur on the link 
regardless of the ndlp state. This it simply needed to occur. As not 
checks on ndlp state are needed, there is no race.


-- james

Re: [PATCH] lpfc: Fix nvme io stoppage after link bounce

2017-06-22 Thread Johannes Thumshirn 
On Wed, Jun 21, 2017 at 10:37:58AM -0700, James Smart wrote:
[...]
> - /*
> -  * Catch race where our node has transitioned, but the
> -  * transport is still transitioning.
> -  */


The patch looks fine but can you please explain why the above race can't
happen anymore?

Thanks,
Reviewed-by: Johannes Thumshirn 

-- 
Johannes Thumshirn  Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850