Re: sym53c8xx driver hangs

2005-02-18 Thread Roger Håkansson
Matthew Wilcox wrote:
Yeah, I don't think any existing patch will help you.  
Actually I got it to work when I applied the patch frage schnell posted 
jan.20 (http://marc.theaimsgroup.com/?l=linux-scsim=110624183606642)

Could you try this one?
No luck, same errors as with the standard(2.1.18m) driver, and the 
driver gets stuck



smime.p7s
Description: S/MIME Cryptographic Signature


Re: sym53c8xx driver hangs

2005-02-18 Thread Matthew Wilcox
On Fri, Feb 18, 2005 at 11:05:51AM +0100, Roger Håkansson wrote:
 Matthew Wilcox wrote:
 Yeah, I don't think any existing patch will help you.  
 
 Actually I got it to work when I applied the patch frage schnell posted 
 jan.20 (http://marc.theaimsgroup.com/?l=linux-scsim=110624183606642)

Oh.  I think I'm confused as to which version of sym2 is in which version
of Linus' tree.  The same line in my development tree reads:

if ((goal-options  PPR_OPT_MASK) || (goal-period  0xa)) {

Does it still work if you use that?  The problem with Frage Schnell's
patch is that it won't try to negotiate U160 speeds; it'll be capped
at U80.

-- 
Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception. -- Mark Twain
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: sym53c8xx driver hangs

2005-02-18 Thread Roger Håkansson
Matthew Wilcox wrote:
Oh.  I think I'm confused as to which version of sym2 is in which version
of Linus' tree.  The same line in my development tree reads:
if ((goal-options  PPR_OPT_MASK) || (goal-period  0xa)) {
Does it still work if you use that?  The problem with Frage Schnell's
patch is that it won't try to negotiate U160 speeds; it'll be capped
at U80.
Well, I guess that part of the driver is rewritten a bit, I get a 
compile error if I put that in ;)
But yes, it works if I put in:

if ((tp-tinfo.goal.options  PPR_OPT_MASK) ||
(tp-tinfo.goal.period  0xa)) {


smime.p7s
Description: S/MIME Cryptographic Signature


Re: sym53c8xx driver hangs

2005-02-18 Thread Matthew Wilcox
On Fri, Feb 18, 2005 at 06:05:22PM +0100, Roger Håkansson wrote:
 Matthew Wilcox wrote:
 Oh.  I think I'm confused as to which version of sym2 is in which version
 of Linus' tree.  The same line in my development tree reads:
 
 Well, I guess that part of the driver is rewritten a bit, I get a 
 compile error if I put that in ;)

Oh, er, yes, looking at the diff from 2.6.10 shows I did ...

+   struct sym_trans *goal = tp-tinfo.goal;
+   struct sym_trans *curr = tp-tinfo.curr;

lalalla ;-)

 But yes, it works if I put in:
 
 if ((tp-tinfo.goal.options  PPR_OPT_MASK) ||
 (tp-tinfo.goal.period  0xa)) {

Excellent.  Then 2.6.11 works for Ultrium tape drives.  Yay!  Tick another
annoying bug off the list ... just the strange not-working-on-Alpha bug
to investigate, I think.

-- 
Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception. -- Mark Twain
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: sym53c8xx driver hangs

2005-02-17 Thread Matthew Wilcox
On Thu, Feb 17, 2005 at 04:51:44PM +0100, Roger Håkansson wrote:
 I've seen that there are more people having similar problem and some 
 patches have also been suggested, but I haven't tested any of them yet.

Yeah, I don't think any existing patch will help you.  Could you try
this one?

Index: drivers/scsi/sym53c8xx_2/sym_hipd.c
===
RCS file: /var/lib/cvs/linux-2.6/drivers/scsi/sym53c8xx_2/sym_hipd.c,v
retrieving revision 1.48
diff -u -p -r1.48 sym_hipd.c
--- drivers/scsi/sym53c8xx_2/sym_hipd.c 16 Feb 2005 20:54:02 -  1.48
+++ drivers/scsi/sym53c8xx_2/sym_hipd.c 18 Feb 2005 05:14:51 -
@@ -2738,6 +2738,10 @@ unexpected_phase:
 dsp == SCRIPTB_BA (np, send_sdtr) ||
 dsp == SCRIPTB_BA (np, send_ppr)) {
nxtdsp = SCRIPTB_BA (np, nego_bad_phase);
+   if (dsp == SCRIPTB_BA(np, send_ppr)) {
+   struct scsi_device *dev = cp-cam_ccb-device;
+   dev-ppr = 0;
+   }
}
break;
 #if 0

Basically, the drive is being Bad by acting as if PPR is a personal
insult even though it claims to be SCSI-3.  This should turn off future
attempts to negotiate with PPR after the first attempt fails.

-- 
Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception. -- Mark Twain
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html