[linux-usb-devel] Re: ISP116x Linux Driver / Strange behaviour

2006-02-14 Thread Olav Kongas


On Mon, 13 Feb 2006, Peter Wippich wrote:
 thank you for your response. Trying to actualy run the driver with
 PTD_TRACE enabled is not realy possible. As soon as I open my device I get
 flooded with repeated messages:
 
 [  122.48] td: f 8i2 0,64,64  0 101
 .

You can cut the amount of log very much down by adding to 
the beginning of dump_ptd() in isp116x.h the following 
check:

if (PTD_GET_CC(ptd) == 0xf)
return;

 
 I will try to set up some other debugging environment on Wendesday (I'm
 out off office tomorrow) and than get back to you.

I thought a little bit more about it. It would be good to 
print out some more info right before the BUG() is hit. 
Could you please apply the patch below (I didn't test it, 
hopefully it is clean).

Olav

PS! I am wondering whether the driver in newer kernels might 
work better.


--- linux-2.6.14-or/drivers/usb/host/isp116x-hcd.c.or   2006-02-14 
10:09:23.0 +0200
+++ linux-2.6.14-or/drivers/usb/host/isp116x-hcd.c  2006-02-14 
10:41:56.0 +0200
@@ -532,11 +532,13 @@ static void start_atl_transfers(struct i
} else if (ep-nextpid == USB_PID_ACK) {
len = 0;
} else {
+   int len1, len2, len3 = -7, len4 = -7;
+
/* Find current free length ... */
-   len = (MAX_LOAD_LIMIT - load) / byte_time;
+   len1 = len = (MAX_LOAD_LIMIT - load) / byte_time;
 
/* ... then limit it to configured max size ... */
-   len = min(len, speed == USB_SPEED_LOW ?
+   len2 = len = min(len, speed == USB_SPEED_LOW ?
  MAX_TRANSFER_SIZE_LOWSPEED :
  MAX_TRANSFER_SIZE_FULLSPEED);
 
@@ -546,11 +548,25 @@ static void start_atl_transfers(struct i
(urb-transfer_buffer_length -
 urb-actual_length)) {
len -= len % ep-maxpacket;
+   len3 = len;
if (!len)
continue;
} else
-   len = urb-transfer_buffer_length -
+   len4 = len = urb-transfer_buffer_length -
urb-actual_length;
+   if (len  0)
+   printk(-- len: %d %d %d %d\n
+   load %d  byte_time %d  speed %d\n
+   transfer_buffer_length %d  
+   actual_length %d\n
+   ep: %d %d %d %d %d\n
+   len1, len2, len3, len4,
+   (int)load, byte_time, speed,
+   urb-transfer_buffer_length,
+   urb-actual_length,
+   (int)ep-maxpacket, (int)ep-epnum,
+   (int)ep-nextpid, (int)ep-error_count,
+   (int)ep-length);
BUG_ON(len  0);
}
 


---
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnkkid=103432bid=230486dat=121642
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel


[linux-usb-devel] Re: USB on motherboards VIA

2006-02-14 Thread Jean-Philippe Mengual
Hi,
uhci-hcd driver is loaded, because I built it in the kernel to be sure
it's correctly loaded. So, it's enabled.

dmesg displays, when I boot with my hd connected, this (about USB):
Intel machine check architecture supported.
Intel machine check reporting enabled on CPU#0.
CPU: AMD Athlon(tm) XP 1900+ stepping 02
Enabling fast FPU save and restore... done.
Linux Plug and Play Support v0.97 (c) Adam Belay
SCSI subsystem initialized
usbcore: registered new driver usbfs
usbcore: registered new driver hub
Linux agpgart interface v0.100 (c) Dave Jones
agpgart: Detected VIA KT266/KY266x/KT333 chipset
agpgart: Maximum main memory to use for agp memory: 203M
agpgart: AGP aperture is 64M @ 0xe000
[drm] Initialized drm 1.0.0 20040925
ohci_hcd: 2004 Nov 08 USB 1.1 'Open' Host Controller (OHCI) Driver
(PCI)
USB Universal Host Controller Interface driver v2.2
uhci_hcd :00:11.2: VIA Technologies, Inc. VT82x UHCI USB 1.1
Controller
uhci_hcd :00:11.2: irq 11, io base 0xd800
uhci_hcd :00:11.2: new USB bus registered, assigned bus number 1
uhci_hcd :00:11.2: USBCMD_HCRESET timed out!
uhci_hcd :00:11.2: init error -110
uhci_hcd :00:11.2: remove, state 0
Uninitialised timer!
This is just a warning.  Your computer is OK
function=0x, data=0x0
[c011f9ed] check_timer_failed+0x5d/0x70
[c011fdfb] del_timer+0x1b/0xc0
[c026dd1d] uhci_stop+0x1d/0xb0
[c025a66f] usb_hcd_pci_remove+0x8f/0x1b0
[c025a395] usb_hcd_pci_probe+0x2b5/0x500
[c01c42f2] pci_device_probe_static+0x52/0x70
[c01c434c] __pci_device_probe+0x3c/0x50
[c01c438c] pci_device_probe+0x2c/0x60
[c0203e2f] driver_probe_device+0x2f/0x80
[c0203f82] driver_attach+0x52/0xa0
[c02044c8] bus_add_driver+0x98/0xe0
[c0204b2f] driver_register+0x2f/0x40
[c01c461c] pci_register_driver+0x5c/0x80
[c03c6a9f] uhci_hcd_init+0x7f/0x100
[c03ae883] do_initcalls+0x53/0xc0
[c01002b0] init+0x0/0x120
[c01002b0] init+0x0/0x120
[c01002df] init+0x2f/0x120
[c0100830] kernel_thread_helper+0x0/0x10
[c0100835] kernel_thread_helper+0x5/0x10
uhci_hcd :00:11.2: USB bus 1 deregistered
uhci_hcd: probe of :00:11.2 failed with error -110
uhci_hcd :00:11.3: VIA Technologies, Inc. VT82x UHCI USB 1.1
Controller
(#2)
uhci_hcd :00:11.3: irq 11, io base 0xdc00
uhci_hcd :00:11.3: new USB bus registered, assigned bus number 1
uhci_hcd :00:11.3: USBCMD_HCRESET timed out!
uhci_hcd :00:11.3: init error -110
uhci_hcd :00:11.3: remove, state 0
Uninitialised timer!
This is just a warning.  Your computer is OK
function=0x, data=0x0
[c011f9ed] check_timer_failed+0x5d/0x70
[c011fdfb] del_timer+0x1b/0xc0
[c026dd1d] uhci_stop+0x1d/0xb0
[c025a66f] usb_hcd_pci_remove+0x8f/0x1b0
[c025a395] usb_hcd_pci_probe+0x2b5/0x500
[c01c42f2] pci_device_probe_static+0x52/0x70
[c01c434c] __pci_device_probe+0x3c/0x50
[c01c438c] pci_device_probe+0x2c/0x60
[c0203e2f] driver_probe_device+0x2f/0x80
[c0203f82] driver_attach+0x52/0xa0
[c02044c8] bus_add_driver+0x98/0xe0
[c0204b2f] driver_register+0x2f/0x40
[c01c461c] pci_register_driver+0x5c/0x80
[c03c6a9f] uhci_hcd_init+0x7f/0x100
[c03ae883] do_initcalls+0x53/0xc0
[c01002b0] init+0x0/0x120
[c01002b0] init+0x0/0x120
[c01002df] init+0x2f/0x120
[c0100830] kernel_thread_helper+0x0/0x10
[c0100835] kernel_thread_helper+0x5/0x10
uhci_hcd :00:11.3: USB bus 1 deregistered
uhci_hcd: probe of :00:11.3 failed with error -110
uhci_hcd :00:11.4: VIA Technologies, Inc. VT82x UHCI USB 1.1
Controller
(#3)
uhci_hcd :00:11.4: irq 11, io base 0xe000
uhci_hcd :00:11.4: new USB bus registered, assigned bus number 1
uhci_hcd :00:11.4: USBCMD_HCRESET timed out!
uhci_hcd :00:11.4: init error -110
uhci_hcd :00:11.4: remove, state 0
Uninitialised timer!
This is just a warning.  Your computer is OK
function=0x, data=0x0
[c011f9ed] check_timer_failed+0x5d/0x70
[c011fdfb] del_timer+0x1b/0xc0
[c026dd1d] uhci_stop+0x1d/0xb0
[c025a66f] usb_hcd_pci_remove+0x8f/0x1b0
[c025a395] usb_hcd_pci_probe+0x2b5/0x500
[c01c42f2] pci_device_probe_static+0x52/0x70
[c01c434c] __pci_device_probe+0x3c/0x50
[c01c438c] pci_device_probe+0x2c/0x60
[c0203e2f] driver_probe_device+0x2f/0x80
[c0203f82] driver_attach+0x52/0xa0
[c02044c8] bus_add_driver+0x98/0xe0
[c0204b2f] driver_register+0x2f/0x40
[c01c461c] pci_register_driver+0x5c/0x80
[c03c6a9f] uhci_hcd_init+0x7f/0x100
[c03ae883] do_initcalls+0x53/0xc0
[c01002b0] init+0x0/0x120
[c01002b0] init+0x0/0x120
[c01002df] init+0x2f/0x120
[c0100830] kernel_thread_helper+0x0/0x10
[c0100835] kernel_thread_helper+0x5/0x10
uhci_hcd :00:11.4: USB bus 1 deregistered
uhci_hcd: probe of :00:11.4 failed with error -110
Initializing USB Mass Storage driver...
usbcore: registered new driver usb-storage
USB Mass Storage support registered.
usbcore: registered new driver hiddev
usbcore: registered new driver usbhid
drivers/usb/input/hid-core.c: v2.0:USB HID core driver

Thanks for your help, and information. That's right I really don't
know jhat I can do, because I don't find the origin of the 

Re: [linux-usb-devel] Re: USB support on VIA motherboards

2006-02-14 Thread Alan Stern
On Tue, 14 Feb 2006, Jean-Philippe Mengual wrote:

 Hi,
 I built a kernel 2.6.15. In my /dev directory, no /dev/sda is created.
 So I can't use my external hd.
 As you asked me, here's the log (dmesg) now:

 Feb 14 20:39:11 mendreanogual kernel: USB Universal Host Controller Interface 
 driver v2.3
 Feb 14 20:39:11 mendreanogual kernel: uhci_hcd :00:11.2: UHCI Host 
 Controller
 Feb 14 20:39:11 mendreanogual kernel: uhci_hcd :00:11.2: HCRESET not 
 completed yet!
 Feb 14 20:39:11 mendreanogual kernel: uhci_hcd :00:11.2: new USB bus 
 registered, assigned bus number 1
 Feb 14 20:39:11 mendreanogual kernel: uhci_hcd :00:11.2: irq 11, io base 
 0xd800
 Feb 14 20:39:11 mendreanogual kernel: hub 1-0:1.0: USB hub found
 Feb 14 20:39:11 mendreanogual kernel: hub 1-0:1.0: 2 ports detected

It looks like you should now see something in /proc/bus/usb/devices, which
is more than you had before.

 This log makes me ask that: what does HCRESET not comple\
 ted yet! mean? How can I solve that? Maybe it's the original problem.
 I used the same .config file than for kernel 2.6.11.12, if you want I
 can send it too.

No, don't send your .config.

The HCRESET not completed yet message refers to a Host Controller reset.  
The driver sends a reset signal to the USB host controller and then waits
5 microseconds for the controller to finish resetting itself.  If it
hasn't finished, you get that warning.

It's possible that your hardware needs more than 5 us.  You can increase 
that delay time if you want, by editing the kernel source file 
drivers/usb/host/pci-quirks.c.  Near the start of the file you'll see a 
routine named uhci_reset_hc which contains a line saying

udelay(5);

Try increasing the 5 to something like 50 or 100, to see if it makes any 
difference.

From the fact that you still can't use your USB hard disk, it could be
that the controller simply doesn't work at all.  The only way to tell is 
by experimenting.

Alan Stern



---
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnkkid=103432bid=230486dat=121642
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel


[linux-usb-devel] Re: [PATCH 1/9] isdn4linux: Siemens Gigaset drivers - Kconfigs and Makefiles

2006-02-14 Thread Greg KH
On Sat, Feb 11, 2006 at 03:52:27PM +0100, Hansjoerg Lipp wrote:
 From: Tilman Schmidt [EMAIL PROTECTED], Hansjoerg Lipp [EMAIL PROTECTED]
 
 This patch prepares the kernel build infrastructure for addition of the
 Gigaset ISDN drivers. It creates a Makefile and Kconfig file for the
 Gigaset driver and hooks them into those of the isdn4linux subsystem.
 It also adds a MAINTAINERS entry for the driver.
 
 This patch depends on patches 2 to 9 of the present set, as without the
 actual source files, activating the options added here will cause the
 kernel build to fail.

Care to redo that and add the Makefile change at the same time as the
driver goes into the tree?  We don't want to break the buid for a
specific patch.

thanks,

greg k-h


---
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnkkid=103432bid=230486dat=121642
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel


[linux-usb-devel] Re: [PATCH 6/9] isdn4linux: Siemens Gigaset drivers - procfs interface

2006-02-14 Thread Andrew Morton
Tilman Schmidt [EMAIL PROTECTED] wrote:

  - You did the ringbuffer the wrong way.  Don't constrain the head and
 tail to be within 0..MAX_EVENTS.  Instead, just let them wrap right up to
 0x.   Apply the masking when you actually _use_ them.
   
 That way, empty is (head == tail) and full is (tail - head == 
 MAX_EVENTS).
 
  Interesting idea. I have to admit it's rather new to me. I have always
  done ringbuffers the way they are done in the Gigaset driver now. Can
  you point me to some example code done the way you propose, so I can
  familiarize myself with its advantages?

Pretty much all the Becker-derived net drivers do this - Say,
vortex_private.cur_tx, .cur_tx.  Also include/linux/circ_buf.h and its
various users.



---
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnkkid=103432bid=230486dat=121642
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel


[linux-usb-devel] Re: [PATCH 2/9] isdn4linux: Siemens Gigaset drivers - common module

2006-02-14 Thread Greg KH
Overall, all of these look fine, I only have a few minor cleanup
comments here and there...


On Sat, Feb 11, 2006 at 03:52:27PM +0100, Hansjoerg Lipp wrote:
 --- linux-2.6.16-rc2/drivers/isdn/gigaset/gigaset.h   1970-01-01 
 01:00:00.0 +0100
 +++ linux-2.6.16-rc2-gig/drivers/isdn/gigaset/gigaset.h   2006-02-11 
 15:20:26.0 +0100
 @@ -0,0 +1,938 @@
 +/* Siemens Gigaset 307x driver
 + * Common header file for all connection variants
 + *
 + * Written by Stefan Eilers [EMAIL PROTECTED]
 + *and Hansjoerg Lipp [EMAIL PROTECTED]
 + *
 + * Version: $Id: gigaset.h,v 1.97.4.26 2006/02/04 18:28:16 hjlipp Exp $

$Id: isn't needed within the kernel tree :)

 + * 
 ===
 + */
 +
 +#ifndef GIGASET_H
 +#define GIGASET_H
 +
 +#include linux/config.h
 +#include linux/kernel.h
 +#include linux/compiler.h
 +#include linux/types.h
 +#include asm/atomic.h
 +#include linux/spinlock.h
 +#include linux/isdnif.h
 +#include linux/usb.h
 +#include linux/skbuff.h
 +#include linux/netdevice.h
 +#include linux/ppp_defs.h
 +#include linux/timer.h
 +#include linux/interrupt.h
 +#include linux/tty.h
 +#include linux/tty_driver.h
 +#include linux/list.h

asm #includes should be at the end of the list.

 +
 +#define GIG_VERSION {0,5,0,0}
 +#define GIG_COMPAT  {0,4,0,0}
 +
 +#define MAX_REC_PARAMS 10 /* Max. number of params 
 in response string */
 +#define MAX_RESP_SIZE 512 /* Max. size of a response 
 string */
 +#define HW_HDR_LEN 2  /* Header size used to 
 store ack info */

No tabs here, yet in other places in the file, you have tabs.  Try using
them everywhere.  Also try to follow the 80 column rule where ever
possible, as per the Documentation/CodingStyle file.

 +#define MAX_EVENTS 64  /* size of event queue */
 +
 +#define RBUFSIZE 8192
 +#define SBUFSIZE 4096/* sk_buff payload size 
 */
 +
 +#define MAX_BUF_SIZE (SBUFSIZE - 2)  /* Max. size of a data packet 
 from LL */
 +#define TRANSBUFSIZE 768 /* bytes per skb for 
 transparent receive */
 +
 +/* compile time options */
 +#define GIG_MAJOR 0
 +
 +#define GIG_MAYINITONDIAL
 +#define GIG_RETRYCID
 +#define GIG_X75
 +
 +#define MAX_TIMER_INDEX 1000
 +#define MAX_SEQ_INDEX   1000
 +
 +#define GIG_TICK (HZ / 10)

What is this needed for?  Timeouts should be in real units, right?

 +/* redefine syslog macros to prepend module name instead of entire source 
 path */
 +/* The space before the comma in , ## is needed by gcc 2.95 */

gcc 2.95 isn't supported by the kernel anymore :)

 +#undef info
 +#define info(format, arg...) printk(KERN_INFO %s:  format \n, 
 THIS_MODULE ? THIS_MODULE-name : gigaset_hw , ## arg)

Care to use the dev_info(), dev_err() and other dev_* friends instead of
rolling your own?  It gives you a much easier and standardised way of
identifying the driver and individual device that the message is
happening for.

thanks,

greg k-h


---
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnkkid=103432bid=230486dat=121642
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel


[linux-usb-devel] Re: [PATCH 6/9] isdn4linux: Siemens Gigaset drivers - procfs interface

2006-02-14 Thread Greg KH
On Sat, Feb 11, 2006 at 03:52:28PM +0100, Hansjoerg Lipp wrote:
 +#include gigaset.h
 +#include linux/ctype.h
 +
 +static ssize_t show_cidmode(struct device *dev, struct device_attribute 
 *attr, char *buf)
 +{
 + struct usb_interface *intf = to_usb_interface(dev);
 + struct cardstate *cs = usb_get_intfdata(intf);
 + return sprintf(buf, %d\n, atomic_read(cs-cidmode)); // FIXME use 
 scnprintf for 13607 bit architectures (if PAGE_SIZE==4096)

sprintf is just fine here, you are only printing a single integer, and
you don't need to worry about the page size.

thanks,

greg k-h


---
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnkkid=103432bid=230486dat=121642
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel


[linux-usb-devel] Re: [PATCH 9/9] isdn4linux: Siemens Gigaset drivers - M105 USB DECT adapter

2006-02-14 Thread Greg KH
On Sat, Feb 11, 2006 at 03:52:29PM +0100, Hansjoerg Lipp wrote:
 +
 +/* Get a minor range for your devices from the usb maintainer */
 +#define USB_SKEL_MINOR_BASE  200

I don't think you need this here anymore :)

 +struct usb_cardstate {
 + struct usb_device   *udev;  /* save off the usb 
 device pointer */
 + struct usb_interface*interface; /* the interface for 
 this device */

You can get to the usb_device from the usb_interface with a helper
function call, but if you want to save both pointers off too, that's
fine.




---
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnkkid=103432bid=230486dat=121642
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel


[linux-usb-devel] Re: [PATCH 2/9] isdn4linux: Siemens Gigaset drivers - common module

2006-02-14 Thread Nishanth Aravamudan
On 11.02.2006 [15:52:27 +0100], Hansjoerg Lipp wrote:
 From: Tilman Schmidt [EMAIL PROTECTED], Hansjoerg Lipp [EMAIL PROTECTED]
 
 This patch adds the common include file for the Siemens Gigaset drivers,
 providing definitions used by all of the Gigaset ISDN driver source files.
 It also adds the main source file of the gigaset module which manages
 common functions not specific to the type of connection to the device.

snip

 +#define GIG_TICK (HZ / 10)

This should probable be in milliseconds and use msecs_to_jiffies either
with another #define, or in the code directly (as Greg also indicated).
That way, we avoid rounding issues as best we can with HZ==250.

snip

 +/* gigaset_initcs
 + * Allocate and initialize cardstate structure for Gigaset driver
 + * Calls hardware dependent gigaset_initcshw() function
 + * Calls B channel initialization function gigaset_initbcs() for each B 
 channel
 + * parameters:
 + *  drv  hardware driver the device belongs to
 + *   channelsnumber of B channels supported by device
 + *   onechannel  !=0: B channel data and AT commands share one 
 communication channel
 + *   ==0: B channels have separate communication channels
 + *   ignoreframesnumber of frames to ignore after setting up B channel
 + *   cidmode !=0: start in CallID mode
 + *   modulename  name of driver module (used for I4L registration)
 + * return value:
 + *   pointer to cardstate structure
 + */
 +struct cardstate *gigaset_initcs(struct gigaset_driver *drv, int channels,
 +  int onechannel, int ignoreframes,
 +  int cidmode, const char *modulename)
 +{

snip

 + cs-timer.data = (unsigned long) cs;
 + cs-timer.function = timer_tick;
 + cs-timer.expires = jiffies + GIG_TICK;

setup_timer()?

Thanks,
Nish


---
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnkkid=103432bid=230486dat=121642
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel


[linux-usb-devel] Re: Linux 2.6.16-rc3

2006-02-14 Thread Arjan van de Ven
On Mon, 2006-02-13 at 20:08 -0700, Michal Jaegermann wrote:
 On Mon, Feb 13, 2006 at 09:57:48AM +0100, Arjan van de Ven wrote:
  On Mon, 2006-02-13 at 00:12 -0800, Andrew Morton wrote:
   
   I think we can assume that it will be seen there.  2.6.16 is going into
   distros and will have more exposure than 2.6.15, 
  
  2.6.15 went into distros as well, such as Fedora Core 4 ;)
 
 And promptly broke laptop suspension.  See, for example:
 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180998


fedora core 4 never really supported suspend in the first place tho..




---
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnkkid=103432bid=230486dat=121642
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel


[linux-usb-devel] Re: Linux 2.6.16-rc3

2006-02-14 Thread Michal Jaegermann
On Mon, Feb 13, 2006 at 10:30:56PM -0500, Lee Revell wrote:
 On Mon, 2006-02-13 at 20:08 -0700, Michal Jaegermann wrote:
  On Mon, Feb 13, 2006 at 09:57:48AM +0100, Arjan van de Ven wrote:
   
   2.6.15 went into distros as well, such as Fedora Core 4 ;)
  
  And promptly broke laptop suspension.  See, for example:
  https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180998
 
 It broke suspension on YOUR laptop - the bug report does not give a make
 and model.

Yes, indeed.  It is Acer Travelmate 230 and it is using
'acpi_sleep=s3_bios'.  The bug report noted though that the
following showed up:

Yenta O2: res at 0x94/0xD4: 00/ca
Yenta O2: enabling read prefetch/write burst
ACPI-0265: *** Error: No installed handler for fixed event [0002]

which was not something which I have seen before and indeed on
another laptop with the same kernel is absent.  But it was also not
there on 230 with earlier kernels.

BTW - this another laptop mentioned above, which happens to be Acer
Travelmate 740, is doing suspend/resume with 2.6.15 kernel, and no
'acpi_sleep=s3_bios' is needed,  but shortly after such cycle both
an external mouse and a touchpad go crazy and a mouse pointer
refuses to move in X from the left screen edge.  Not very useful and
so far I did not found a way to reset rodents.  No problems of that
sort before I will try to suspend.  Always something interesting.
It is actually possible that in this case this is a problem with
ATI Radeon Mobility M6 video driver which gets upset by suspend
(or some other pieces driving display) but I do not really know.

   Michal


---
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnkkid=103432bid=230486dat=121642
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel


[linux-usb-devel] RE: Linux 2.6.16-rc3

2006-02-14 Thread Brown, Len
i have a bug similar to:
http://bugzilla.kernel.org/show_bug.cgi?id=6038 (marked as blocking by
Andrew) on my laptop.

6038 is in NEEDINFO.
If no submitter participates, it may never get fixed.

-Len


---
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnkkid3432bid#0486dat1642
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel


[linux-usb-devel] Re: Linux 2.6.16-rc3

2006-02-14 Thread Michal Jaegermann
On Mon, Feb 13, 2006 at 07:28:38PM -0800, Andrew Morton wrote:
 Michal Jaegermann [EMAIL PROTECTED] wrote:
 
  On Mon, Feb 13, 2006 at 09:57:48AM +0100, Arjan van de Ven wrote:
   On Mon, 2006-02-13 at 00:12 -0800, Andrew Morton wrote:

I think we can assume that it will be seen there.  2.6.16 is going into
distros and will have more exposure than 2.6.15, 
   
   2.6.15 went into distros as well, such as Fedora Core 4 ;)
  
  And promptly broke laptop suspension.  See, for example:
  https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180998
  
 
 That's suspend-to-disk, yes?

No.  That is an S3 suspension to RAM.  On the box in question it
generally worked for quite a long while now provided
'acpi_sleep=s3_bios' was passed to a kernel or video would be
unrestorable.  It is Acer Travelmate 230 with i845G video.

I did not try on that laptop suspend-to-disk so far (and in this
moment the damn thing is just plain broken).

   Michal


---
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnkkid=103432bid=230486dat=121642
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel


[linux-usb-devel] Re: Linux 2.6.16-rc3

2006-02-14 Thread Sanjoy Mahajan
 I don't think anybody claimed this isn't a regression for the 600X.

I narrowed it further.  The short story is that this commit (diff below
sig) makes the second S3 sleep go into the endless loop, if the loaded
modules are exactly thermal, processor, intel_agp, and agpgart:

53f11d4ff8797bcceaf014e62bd39f16ce84baec is first bad commit
diff-tree 53f11d4ff8797bcceaf014e62bd39f16ce84baec (from 
02b28a33aae93a3b53068e0858d62f8bcaef60a3)
Author: Len Brown [EMAIL PROTECTED]
Date:   Mon Dec 5 16:46:36 2005 -0500

[ACPI] Enable Embedded Controller (EC) interrupt mode by default

ec_intr=0 reverts to polling
ec_burst= no longer exists.

Signed-off-by: Len Brown [EMAIL PROTECTED]
Acked-by: Luming Yu [EMAIL PROTECTED]

:04 04 9eec66712c68ebe372b2fb2c8d78bdc99df942ab 
e7e62cd09983730aee468edd4ba1cce50786b7e5 M  Documentation
:04 04 6e7db46918f6124f64a11f6757560078a8a27519 
aa8abb1023024902300cb2e7a5bf74acd8c579e8 M  drivers

If I boot with ec_intr=0, the second sleep works fine.

Here is the full story.  First I tried a system with the minimal set of
modules to boot and run X (S3 sleep-wake wrecks the VGA consoles, but X
restores fine with 'chvt 1; sleep 0.5 ; chvt 7' on wakeup).  So I
stopped every service and unloaded all modules possible, which left only
intel_agp and agpgart.  Then, for each of the usual loaded modules
(except for sound modules, which often has sleep-wake problems anyway),
I tried:

1. Load the module
2. S3 sleep-wake-sleep-wake
3. Unload the module

to see whether the second sleep went into the infinite loop (visible
across the console).  The one culprit I found was 'thermal' (which
brings in 'processor').  Other modules didn't trigger the problem.

Then I recompiled using a minimal config, with only networking (for X to
work) and the acpi modules, and maybe a few others that I couldn't
avoid, and retested to make sure 'thermal' still triggered the problem,
which it did.  I used this config, or one just like it for 2.6.15, as a
base for all other kernels in the bisection search, using the nearest
ancestor's .config and then
   yes '' | make oldconfig
to make the new .config

Eventually bisection converged to the commit above, and then I retested
that kernel with 'ec_intr=0'.

Is this a problem with the TP 600X hardware, in which case I'll just use
ec_intr=0 forever, or is there more software debugging (DSDT or related
to the diff)?  I can turn on gobs of ACPI debugging and send the useful
parts of the log file.

In the bisection, many kernels worked fine, meaning that the second S3
cycle returned and I could compile the next bisection kernel.  In doing
that I noticed another problem, that the fan would not turn on with some
of these good kernels even though the system was hot enough (plenty of
chance for it to turn on since the next compile heated up the CPU).  For
example, acpi -t showed

 Thermal 1: ok, 46.0 degrees C
 Thermal 2: active[0], 42.0 degrees C
 Thermal 3: ok, 31.0 degrees C
 Thermal 4: ok, 34.0 degrees C

but the fan was off.  

So whenever I had a good kernel (meaning taht S3 sleep-wake-sleep-wake
returned), I checked whether the fan would turn on, to collect data for
a separate bisection search.  However, the data seems inconsistent.  If
I feed the data to a fresh git bisect, it complains about one commit
being marked both good and bad.  So I'll ask on the git list about that
issue.

-Sanjoy

`A society of sheep must in time beget a government of wolves.'
   - Bertrand de Jouvenal


diff --git a/Documentation/kernel-parameters.txt 
b/Documentation/kernel-parameters.txt
index 5dffcfe..2ad64ef 100644
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -452,6 +452,11 @@ running once the system is up.
 
eata=   [HW,SCSI]
 
+   ec_intr=[HW,ACPI] ACPI Embedded Controller interrupt mode
+   Format: int
+   0: polling mode
+   non-0: interrupt mode (default)
+
eda=[HW,PS2]
 
edb=[HW,PS2]
diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index bb3963b..d4366ad 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -73,7 +73,7 @@ static struct acpi_driver acpi_ec_driver
.class = ACPI_EC_CLASS,
.ids = ACPI_EC_HID,
.ops = {
-   .add = acpi_ec_poll_add,
+   .add = acpi_ec_intr_add,
.remove = acpi_ec_remove,
.start = acpi_ec_start,
.stop = acpi_ec_stop,
@@ -147,7 +147,7 @@ static union acpi_ec *ec_ecdt;
 
 /* External interfaces use first EC only, so remember */
 static struct acpi_device *first_ec;
-static int acpi_ec_poll_mode = EC_POLL;
+static int acpi_ec_poll_mode = EC_INTR;
 
 /* --
  Transaction Management
@@ -1594,4 +1594,4 @@ static int __init 

[linux-usb-devel] Re: Linux 2.6.16-rc3

2006-02-14 Thread Michal Jaegermann
On Mon, Feb 13, 2006 at 09:57:48AM +0100, Arjan van de Ven wrote:
 On Mon, 2006-02-13 at 00:12 -0800, Andrew Morton wrote:
  
  I think we can assume that it will be seen there.  2.6.16 is going into
  distros and will have more exposure than 2.6.15, 
 
 2.6.15 went into distros as well, such as Fedora Core 4 ;)

And promptly broke laptop suspension.  See, for example:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180998

   Michal


---
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnkkid=103432bid=230486dat=121642
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel


[linux-usb-devel] Re: Linux 2.6.16-rc3

2006-02-14 Thread Dave Jones
On Mon, Feb 13, 2006 at 07:28:38PM -0800, Andrew Morton wrote:
  Michal Jaegermann [EMAIL PROTECTED] wrote:
  
   On Mon, Feb 13, 2006 at 09:57:48AM +0100, Arjan van de Ven wrote:
On Mon, 2006-02-13 at 00:12 -0800, Andrew Morton wrote:
 
 I think we can assume that it will be seen there.  2.6.16 is going into
 distros and will have more exposure than 2.6.15, 

2.6.15 went into distros as well, such as Fedora Core 4 ;)
   
   And promptly broke laptop suspension.  See, for example:
   https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180998
   
  
  That's suspend-to-disk, yes?
  
  Dave, would you have the 2.6.15-1.1830_FC4 - 2.6.15-1.1831_FC4 details
  handy?  There surely can't be much difference?

Tiny changes.
- The icmp remote DoS fix.
- Dropped a patch that broke booting with 'quiet' bootparam
- the 'dm_crypt: zero key before freeing it' change

  There seem to be several ACPI problems there.  Do we have a reliable means
  of feeding such reports up into the (for example) acpi developers?
  
  I have this vaguely unsettled feeling that distros must get more bug
  reports than the usptream developers, yet we hear so little about it

I'd love more hours in the day to push more of them upstream, as
I bet would other vendors kernel maintainers.

Should anyone want to drink from the firehose that is 'redhat kernel bugzilla',
let me know, and I'll see if I can't get a fedora-kernel-bugs mailing
list or the like set up.

Some subsystem maintainers (ACPI for example) really help out here,
and add [EMAIL PROTECTED] to all the Fedora ACPI bugs.
(I believe that list actually gets bug reports from other distro bugzillas too)

(There's also a few 'meta-bugs' -- enter FCMETA_ACPI as a bug id
and you get a link to a dependancy tree showing all the ACPI bugs
reported. There's a bunch of those for various subsystems which
makes it a little easier to track, though again, it's time-consuming
just sorting through stuff).  Off the top of my head, theres one
for USB, SCSI, ACPI, ALSA, SATA (All with FCMETA_ prefix)
Some of them are a bit sparse due to lack of time  effort so far.

Dave



---
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnkkid=103432bid=230486dat=121642
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel


[linux-usb-devel] Re: Linux 2.6.16-rc3

2006-02-14 Thread Andrew Morton
Michal Jaegermann [EMAIL PROTECTED] wrote:

 On Mon, Feb 13, 2006 at 09:57:48AM +0100, Arjan van de Ven wrote:
  On Mon, 2006-02-13 at 00:12 -0800, Andrew Morton wrote:
   
   I think we can assume that it will be seen there.  2.6.16 is going into
   distros and will have more exposure than 2.6.15, 
  
  2.6.15 went into distros as well, such as Fedora Core 4 ;)
 
 And promptly broke laptop suspension.  See, for example:
 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180998
 

That's suspend-to-disk, yes?

Dave, would you have the 2.6.15-1.1830_FC4 - 2.6.15-1.1831_FC4 details
handy?  There surely can't be much difference?

There seem to be several ACPI problems there.  Do we have a reliable means
of feeding such reports up into the (for example) acpi developers?

I have this vaguely unsettled feeling that distros must get more bug
reports than the usptream developers, yet we hear so little about it


---
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnkkid=103432bid=230486dat=121642
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel


[linux-usb-devel] Re: Linux 2.6.16-rc3

2006-02-14 Thread Arjan van de Ven

 I have this vaguely unsettled feeling that distros must get more bug
 reports than the usptream developers, yet we hear so little about it

the number of quality reports (eg enough information to do anything)
isn't that high; Dave is pretty good in sending the good ones on, it
often takes time though to get all the basic info..




---
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnkkid=103432bid=230486dat=121642
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel


[linux-usb-devel] Re: Linux 2.6.16-rc3

2006-02-14 Thread James Bottomley
On Mon, 2006-02-13 at 12:38 -0800, Greg KH wrote:
  - Nasty warnings from scsi about kobject-layer things being called
 from
irq context.  James has a push-it-to-process-context patch which
 sadly
assumes kmalloc() is immortal, but no other fix seems to have
 offered
itself.
 
 This has been the case for a long time.  I don't really think there is
 a
 rush to get this fixed, but I really like James's proposed patch.
 It's
 up to him if he feels it is ready for 2.6.16 or not.

Well, I can't solve the problem that it requires memory allocation from
IRQ context to operate.  Based on that, it's an unsafe interface.  I'm
going to put it inside SCSI for 2.6.16, since it's better than what we
have now, but I don't think we can export it globally.

James




---
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnkkid=103432bid=230486dat=121642
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel


[linux-usb-devel] Re: Linux 2.6.16-rc3

2006-02-14 Thread Lee Revell
On Mon, 2006-02-13 at 20:08 -0700, Michal Jaegermann wrote:
 On Mon, Feb 13, 2006 at 09:57:48AM +0100, Arjan van de Ven wrote:
  On Mon, 2006-02-13 at 00:12 -0800, Andrew Morton wrote:
   
   I think we can assume that it will be seen there.  2.6.16 is going into
   distros and will have more exposure than 2.6.15, 
  
  2.6.15 went into distros as well, such as Fedora Core 4 ;)
 
 And promptly broke laptop suspension.  See, for example:
 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180998

It broke suspension on YOUR laptop - the bug report does not give a make
and model.  2.6.15 would not have shipped if it broke suspend on the
developers' laptops.

Lee



---
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnkkid=103432bid=230486dat=121642
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel


Re: [linux-usb-devel] oops

2006-02-14 Thread Oliver Neukum
Am Mittwoch, 15. Februar 2006 01:23 schrieb Greg KH:
 Can you duplicate this without any closed source kernel modules loaded?
 
 Odds are you can, as I've seen this oops report before :(:(

Where if I may ask?

Regards
Oliver


---
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnkkid=103432bid=230486dat=121642
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel


[linux-usb-devel] EHCI High speed periodic scheduler - ITD reuse problem

2006-02-14 Thread Dima Epshtein
Hi,
 
We are using TDI based High speed USB EHCI controller.
Linux version is 2.6.12

I think that I found the problem with reuse ITD structures in the file
ehci-sched.c
The scenario that the problem happens is the following:

We have High speed device with ISO endpoint, maxPktSize=1024 and
Interval = 1 uframe
Now Host test application (we using usbtest.ko with testusb.c) sending 
for example 10 URBs one after other.
They will using 10 ITDs and will be put on periodic scheduler structure
in the following way.

Frame X:   - itd7 - itd6 - itd5 - itd4 - itd3 - itd2 -
itd1 - itd0 - NULL
Frame X+1:   - itd9 - itd8 - NULL

So itd0 will be sent on uframe 0 of Frame X, itd1 on uframe 1 of Frame
X, itd8 on uframe 0 of Frame X+1, itd9 on uframe 1 of Frame X+1, etc.

Now assume itd0 was sent, so function itd_complete was called and itd0
will moved to stream-free_list, 
but itd1 still point to itd0 by hw_next field of struct ehci_itd 

Now exactly after that test application will send new URB. 
Function itd_submit() and itd_urb_transaction() will be called.

Function itd_urb_transaction() first will try get ehci_itd structure
from the free_list and will get itd0.
Other functions will set all needed fields of ehci_itd structure and
will link itd0 to Frame X+1 list.

Frame X+1:   - itd0 - itd9 - itd8 - NULL

So itd0 should be sent on uframe 3 of Frame X+1.

But HW still process uframe 2 of Frame X. When HW will process uframe 3
of Frame X the itd2 will be send first and in the same uframe itd 0 will
be sent because itd0 still linked to itd1 in Frame X.

On Frame X+1 itd0 will not be sent because it was sent on Frame X.

It cause on miss-ordering of data sending and to bandwidth violations.

I am not familiar enough with all corners of EHCI periodic scheduling, 
but it looks dangerous to unlink ehci_itd structure from Frame X list
(change hw_next field) while the hardware still working on Frame X list.

I see few possible solutions:

1. Don't move ehci_itd structure to stream-free_list during
itd_complete function immediately, 
move all ehci_itd structures linked to Frame X list only when HW will
start to process Frame X+1.

2. In the itd_complete function move ehci_itd structure to the tail of
stream-free_list 
and in the itd_urb_transaction() function before reusing of ehci_itd
structure from 
the stream-free_list check if HW already finished to process the frame
that 
ehci_itd structure was linked before (itd-frame).

I will be glad to hear about other possible solutions.
Maybe somebody already meet the problem and there is patch for it.

Thanks
Dima
 
Dmitri Epshtein - Software engineer
Marvell Semiconductor Israel Ltd
6 Hamada Street 
Mordot HaCarmel Industrial Park
Yokneam 20692, ISRAEL
Email - [EMAIL PROTECTED]
Tel - + 972 4 9091455 
Fax - + 972 4 9091501
WWW Page: http://www.marvell.com 

This message may contain confidential, proprietary or legally privileged
information. The information is intended only for the use of the
individual or entity named above. If the reader of this message is not
the
intended recipient, you are hereby notified that any dissemination,
distribution or copying of this communication is strictly prohibited. If
you have received this communication in error, please notify us
immediately by telephone, or by e-mail and delete the message from your
computer.


---
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnkkid3432bid#0486dat1642
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel