Re: [MPC8272ADS]Problem adding flash partitions inside the device tree

2009-02-13 Thread Jean-Michel Hautbois
2009/2/12 Scott Wood scottw...@freescale.com:
 On Thu, Feb 12, 2009 at 03:26:58PM +0100, Jean-Michel Hautbois wrote:
 I think that the problem is in the reg part, but I can't understand why.
 Isn't it the RAM mpping of my MTD that is the first address ?

 No, it's the offset into the chipselect.

 -Scott


OK.
What means the word #adress-cells BTW ?
When should I have 1, 2 or anything else ?

Regards,
JM
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


[MPC8272ADS]Problem adding flash partitions inside the device tree

2009-02-12 Thread Jean-Michel Hautbois
Hi everybody !
I am currently trying to add the support of partitions for the Flash chip on
my MPC8272ADS board (the chips are Sharp LH28F016SCT-L90).

I have added this part:

fl...@0,0 {
compatible = jedec-flash;
reg = 0x0 0x0 0x200;
bank-width = 4;
device-width = 1;

partit...@ff80 {
label = kernel;
reg = 0xff80 0x0040;
read-only;
};
partit...@ffc0 {
label = user;
reg = 0xffc0 0x0030;
};
partit...@fff0 {
label = u-boot;
reg = 0xfff0 0x0010;
read-only;
};
};

But when I am compiling, I have these warnings:
Warning (reg_format): reg property in /local...@f0010100/fl...@0
,0/partit...@ff80 has invalid length (8 bytes) (#address-cells == 2,
#size-cells == 1)
Warning (reg_format): reg property in /local...@f0010100/fl...@0
,0/partit...@ffc0 has invalid length (8 bytes) (#address-cells == 2,
#size-cells == 1)
Warning (reg_format): reg property in /local...@f0010100/fl...@0
,0/partit...@fff0 has invalid length (8 bytes) (#address-cells == 2,
#size-cells == 1)
Warning (avoid_default_addr_size): Relying on default #address-cells value
for /local...@f0010100/fl...@0,0/partit...@ff80
Warning (avoid_default_addr_size): Relying on default #size-cells value for
/local...@f0010100/fl...@0,0/partit...@ff80
Warning (avoid_default_addr_size): Relying on default #address-cells value
for /local...@f0010100/fl...@0,0/partit...@ffc0
Warning (avoid_default_addr_size): Relying on default #size-cells value for
/local...@f0010100/fl...@0,0/partit...@ffc0
Warning (avoid_default_addr_size): Relying on default #address-cells value
for /local...@f0010100/fl...@0,0/partit...@fff0
Warning (avoid_default_addr_size): Relying on default #size-cells value for
/local...@f0010100/fl...@0,0/partit...@fff0


Can anyone help me ?
I can't understand what the address-cells is.

Thanks in advance !
Best Regards.
JM
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [MPC8272ADS]Problem adding flash partitions inside the device tree

2009-02-12 Thread Pieter
Jean-Michel Hautbois wrote:
 Hi everybody !
 I am currently trying to add the support of partitions for the Flash
 chip on my MPC8272ADS board (the chips are Sharp LH28F016SCT-L90).

 I have added this part:

 fl...@0,0 {
 compatible = jedec-flash;
 reg = 0x0 0x0 0x200;
 bank-width = 4;
 device-width = 1;

 partit...@ff80 {
 label = kernel;
 reg = 0xff80 0x0040;
 read-only;
 };
 partit...@ffc0 {
 label = user;
 reg = 0xffc0 0x0030;
 };
 partit...@fff0 {
 label = u-boot;
 reg = 0xfff0 0x0010;
 read-only;
 };
 };

 But when I am compiling, I have these warnings:
 Warning (reg_format): reg property in
 /local...@f0010100/fl...@0,0/partit...@ff80 has invalid length (8
 bytes) (#address-cells == 2, #size-cells == 1)
 Warning (reg_format): reg property in
 /local...@f0010100/fl...@0,0/partit...@ffc0 has invalid length (8
 bytes) (#address-cells == 2, #size-cells == 1)
 Warning (reg_format): reg property in
 /local...@f0010100/fl...@0,0/partit...@fff0 has invalid length (8
 bytes) (#address-cells == 2, #size-cells == 1)
 Warning (avoid_default_addr_size): Relying on default #address-cells
 value for /local...@f0010100/fl...@0,0/partit...@ff80
 Warning (avoid_default_addr_size): Relying on default #size-cells
 value for /local...@f0010100/fl...@0,0/partit...@ff80
 Warning (avoid_default_addr_size): Relying on default #address-cells
 value for /local...@f0010100/fl...@0,0/partit...@ffc0
 Warning (avoid_default_addr_size): Relying on default #size-cells
 value for /local...@f0010100/fl...@0,0/partit...@ffc0
 Warning (avoid_default_addr_size): Relying on default #address-cells
 value for /local...@f0010100/fl...@0,0/partit...@fff0
 Warning (avoid_default_addr_size): Relying on default #size-cells
 value for /local...@f0010100/fl...@0,0/partit...@fff0


 Can anyone help me ?
 I can't understand what the address-cells is.

 Thanks in advance !
 Best Regards.
 JM
You are missing some definitions, The #address-cells and #size-cells = 1;
tis is a snippet of teh dts i defined for my board.

fl...@0,0 {
#address-cells = 1;
#size-cells = 1;
compatible = cfi-flash;
reg = 0x0 0x0 0x0800;
bank-width = 4;
device-width = 1;
   
/* set flash partition to correspond tu mtd parts in
u-boot*/   
/* 0xf800 */   
partit...@0x0 {
label = factory-image;
reg = 0x 0x0100;
};
/* 0xf900 */   
partit...@0x0100 {
label = app-image-1;
reg = 0x0100 0x0100;
};
cheers pieter



smime.p7s
Description: S/MIME Cryptographic Signature
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [MPC8272ADS]Problem adding flash partitions inside the device tree

2009-02-12 Thread Jean-Michel Hautbois
2009/2/12 Pieter phenn...@vastech.co.za

 Jean-Michel Hautbois wrote:
  Warning (reg_format): reg property in
  /local...@f0010100/fl...@0,0/partit...@ff80 has invalid length (8
  JM
 You are missing some definitions, The #address-cells and #size-cells = 1;
 tis is a snippet of teh dts i defined for my board.

fl...@0,0 {
#address-cells = 1;
#size-cells = 1;
compatible = cfi-flash;
reg = 0x0 0x0 0x0800;
 bank-width = 4;
device-width = 1;

 /* set flash partition to correspond tu mtd parts in
 u-boot*/
/* 0xf800 */
partit...@0x0 {
label = factory-image;
reg = 0x 0x0100;
};
/* 0xf900 */
partit...@0x0100 {
label = app-image-1;
reg = 0x0100 0x0100;
};
 cheers pieter


Hi do have these definitions, at a higher level:
 local...@f0010100 {
compatible = fsl,mpc8272-localbus,
 fsl,pq2-localbus;
#address-cells = 2;
#size-cells = 1;
reg = 0xf0010100 0x40;

ranges = 0x0 0x0 0xfe00 0x200
  0x1 0x0 0xf450 0x8000
  0x3 0x0 0xf820 0x8000;

fl...@0,0 {
etc.

Regards,
JM
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [MPC8272ADS]Problem adding flash partitions inside the device tree

2009-02-12 Thread David Gibson
On Thu, Feb 12, 2009 at 12:10:58PM +0100, Jean-Michel Hautbois wrote:
 2009/2/12 Pieter phenn...@vastech.co.za
 
  Jean-Michel Hautbois wrote:
   Warning (reg_format): reg property in
   /local...@f0010100/fl...@0,0/partit...@ff80 has invalid length (8
   JM
  You are missing some definitions, The #address-cells and #size-cells = 1;
  tis is a snippet of teh dts i defined for my board.
 
 fl...@0,0 {
 #address-cells = 1;
 #size-cells = 1;
 compatible = cfi-flash;
 reg = 0x0 0x0 0x0800;
  bank-width = 4;
 device-width = 1;
 
  /* set flash partition to correspond tu mtd parts in
  u-boot*/
 /* 0xf800 */
 partit...@0x0 {
 label = factory-image;
 reg = 0x 0x0100;
 };
 /* 0xf900 */
 partit...@0x0100 {
 label = app-image-1;
 reg = 0x0100 0x0100;
 };
  cheers pieter
 
 
 Hi do have these definitions, at a higher level:

The address-cells and size-cells definitions are not inherited.  They
cover only the immediate children of the node where they appear.
Otherwise the default values apply (address-cells == 2, size-cells ==
1), which are not right for your case.

-- 
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: [MPC8272ADS]Problem adding flash partitions inside the device tree

2009-02-12 Thread Jean-Michel Hautbois
2009/2/12 David Gibson da...@gibson.dropbear.id.au

 On Thu, Feb 12, 2009 at 12:10:58PM +0100, Jean-Michel Hautbois wrote:
  2009/2/12 Pieter phenn...@vastech.co.za
 
   Jean-Michel Hautbois wrote:
Warning (reg_format): reg property in
/local...@f0010100/fl...@0,0/partit...@ff80 has invalid length
 (8
JM
   You are missing some definitions, The #address-cells and #size-cells =
 1;
   tis is a snippet of teh dts i defined for my board.
  
  fl...@0,0 {
  #address-cells = 1;
  #size-cells = 1;
  compatible = cfi-flash;
  reg = 0x0 0x0 0x0800;
   bank-width = 4;
  device-width = 1;
  
   /* set flash partition to correspond tu mtd parts in
   u-boot*/
  /* 0xf800 */
  partit...@0x0 {
  label = factory-image;
  reg = 0x 0x0100;
  };
  /* 0xf900 */
  partit...@0x0100 {
  label = app-image-1;
  reg = 0x0100 0x0100;
  };
   cheers pieter
  
 
  Hi do have these definitions, at a higher level:

 The address-cells and size-cells definitions are not inherited.  They
 cover only the immediate children of the node where they appear.
 Otherwise the default values apply (address-cells == 2, size-cells ==
 1), which are not right for your case.

 --
 David Gibson| I'll have my music baroque, and my code
 david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_
 _other_
| _way_ _around_!
 http://www.ozlabs.org/~dgibson http://www.ozlabs.org/%7Edgibson

OK, so, after having tested, I can't see any changes when booting.
I do not have more mtd in /proc/mtd.

JM
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [MPC8272ADS]Problem adding flash partitions inside the device tree

2009-02-12 Thread Jean-Michel Hautbois
2009/2/12 Pieter phenn...@vastech.co.za

 Jean-Michel Hautbois wrote:
  2009/2/12 David Gibson da...@gibson.dropbear.id.au
  mailto:da...@gibson.dropbear.id.au
 
  On Thu, Feb 12, 2009 at 12:10:58PM +0100, Jean-Michel Hautbois wrote:
   2009/2/12 Pieter phenn...@vastech.co.za
  mailto:phenn...@vastech.co.za
  
Jean-Michel Hautbois wrote:
 Warning (reg_format): reg property in
 /local...@f0010100/fl...@0,0/partit...@ff80 has invalid
  length (8
 JM
You are missing some definitions, The #address-cells and
  #size-cells = 1;
tis is a snippet of teh dts i defined for my board.
   
   fl...@0,0 {
   #address-cells = 1;
   #size-cells = 1;
   compatible = cfi-flash;
   reg = 0x0 0x0 0x0800;
bank-width = 4;
   device-width = 1;
   
/* set flash partition to correspond tu mtd parts in
u-boot*/
   /* 0xf800 */
   partit...@0x0 {
   label = factory-image;
   reg = 0x 0x0100;
   };
   /* 0xf900 */
   partit...@0x0100 {
   label = app-image-1;
   reg = 0x0100 0x0100;
   };
cheers pieter
   
  
   Hi do have these definitions, at a higher level:
 
  The address-cells and size-cells definitions are not inherited.  They
  cover only the immediate children of the node where they appear.
  Otherwise the default values apply (address-cells == 2, size-cells ==
  1), which are not right for your case.
 
  --
  David Gibson| I'll have my music baroque, and
  my code
  david AT gibson.dropbear.id.au http://gibson.dropbear.id.au  |
  minimalist, thank you.  NOT _the_ _other_
 | _way_ _around_!
  http://www.ozlabs.org/~dgibson http://www.ozlabs.org/%7Edgibson 
 http://www.ozlabs.org/%7Edgibson
 
  OK, so, after having tested, I can't see any changes when booting.
  I do not have more mtd in /proc/mtd.
 
  JM
 have you defined the following in your kernel  config

 CONFIG_MTD_PHYSMAP_OF=y
 CONFIG_MTD_PARTITIONS=y
 CONFIG_MTD_OF_PARTS=y

 cheers pieter


I didn't have CONFIG_MTD_OF_PARTS=y.

Know, I have this output:

 Found: Intel I28F016S3
fe00.flash: Found 4 x8 devices at 0x0 in 32-bit bank
fe00.flash: Found an alias at 0x80 for the chip at 0x0
fe00.flash: Found an alias at 0x100 for the chip at 0x0
fe00.flash: Found an alias at 0x180 for the chip at 0x0
erase region 0: offset=0x0,size=0x4,blocks=32
RedBoot partition parsing not available
Creating 3 MTD partitions on fe00.flash:
0xff80-0xffc0 : kernel
mtd: partition kernel is out of reach -- disabled
mtd: Giving out device 0 to kernel
0xffc0-0xfff0 : user
mtd: partition sofrel is out of reach -- disabled
mtd: Giving out device 1 to user
0xfff0-0x0001 : u-boot
mtd: partition u-boot is out of reach -- disabled
mtd: Giving out device 2 to u-boot

I think that the problem is in the reg part, but I can't understand why.
Isn't it the RAM mpping of my MTD that is the first address ?

Thanks agains,
Regards,
JM
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [MPC8272ADS]Problem adding flash partitions inside the device tree

2009-02-12 Thread Scott Wood
On Thu, Feb 12, 2009 at 03:26:58PM +0100, Jean-Michel Hautbois wrote:
 I think that the problem is in the reg part, but I can't understand why.
 Isn't it the RAM mpping of my MTD that is the first address ?

No, it's the offset into the chipselect.

-Scott
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev