Re: [LTP] Se-Linux Updates for LTP
On Tue, 2007-12-18 at 15:36 -0500, Jeff Burke wrote: Stephen Smalley wrote: On Mon, 2007-12-17 at 13:50 -0500, Stephen Smalley wrote: On Mon, 2007-12-17 at 13:43 -0500, Stephen Smalley wrote: On Thu, 2007-12-13 at 19:33 -0500, Jeff Burke wrote: Stephen, Joy, Dan and James Using Stephens latest patch. Here are the results for the selinux tests ltp-full-20071130, RHEL5.1 + selinux-policy-2.4.6-106.el5_1.3: Reverting the prior patches and applying this one instead, I am able to run all of the test cases successfully on RHEL5.1 with that policy version. I never did get a failure on SELinux10 though even with the old patch. Looking at your log file, it suggests that you were running the tests without a controlling tty? That will break that particular test at least (sendsigio_task). As for the build failure on execshare_parent, I don't know how to fix that on ia64 - is there a portable way to write a call to clone(2) that will work there? I don't have ia64 hardware readily available to me. Ah, from the clone(2) man page, I see that one is supposed to use clone2() instead on IA-64. But someone else will have to do that and test it - I don't have an ia64 machine at my disposal. From the example of other code in the ltp, it looks like the following patch should work for ia-64. This patch for the execshare test program is in addition to the prior policy patch. Stephen, This ran successful with ltp-full-20071130 + Attached Patches on RHEL5.1 + selinux-policy-2.4.6-106.el5_1.3 Good, so the earlier patch should be reverted and these patches should be applied instead to the ltp cvs. I had to do a couple of things. Attached are all the patches that you created. Plus a patch from me for the controlling tty issue. Also a minor change to your patch for the ia64 compile failure. I'll trust you on the latter, as I can't test on ia64. I also believe that the ./testscripts/test_selinux.sh should do something like the this. # Backing up files cp /etc/selinux/semanage.conf etc/selinux/semanage.conf.orig # Added expand-check=0 to /etc/selinux/semanage.conf file # as the test policy will violate some of the neverallow # rules in the base policy. ltp testing. echo expand-check=0 /etc/selinux/semanage.conf cp /etc/selinux/semanage.conf /etc/selinux/semanage.conf.orig echo expand-check=0 /etc/selinux/semanage.conf # Read in new semanage.conf file /usr/sbin/semodule -B You don't actually need that semodule -B command; the updated semanage.conf is read whenever libsemanage gets used, so it will be taken into account when semodule is run to insert the test policy. semodule -B is for rebuilding the actual policy; semanage.conf is not part of the policy. Then before test_selinux.sh exits it should # Putting origianal /etc/selinux/semanage.conf back cp /etc/selinux/semanage.conf.orig /etc/selinux/semanage.conf /sbin/restorecon -v -F /etc/selinux/semanage.conf /usr/sbin/semodule -B Likewise, you won't need the semodule -B here. But otherwise, looks ok - can either be part of test_selinux.sh or just part of the instructions in the README. Thanks, Jeff -- Stephen Smalley National Security Agency - SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ___ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
Re: [LTP] New tests in LTP
On Tue, 2007-12-18 at 15:49 +0100, Aurélien Charbon wrote: I think the natural place for including these tests is the testcases/network/rpc branch. Do you want me to send a patch from the last ltp realease that includes them in the right place ? Yes. That would be great. Please pick up the latest LTP from: http://prdownloads.sourceforge.net/ltp/ltp-full-20071130.tgz?download, And i would also like to propose the following points: 1) You should know the way LTP-Network Tests are run. There are some inherent variables set and other environmental settings done both at the Client as well as the Server Side before these tests are executed. So, your patch (new test cases addition for RPC and TRIPC) should be able to adhere to all those norms. User should be able to execute your test cases automatically when they run LTP-Network tests, 2) You should also properly document what your test cases are all about, how they can be built, installed and executed and how their results should be parsed in a Proper README file in any of the sub-directories that your patch is going to create under ltp/testcases/network/rpc. 3) Include Copyright and GPLv2 definition at the beginning of each of your new Test cases for License conformance in LTP, 4) Last and not the least, please respond to somebody if they find problem(s) in executing your testcases by providing fixes, patches, etc on the mailing-list. Expecting a patch from you on this and much more contribution to LTP in future. Good luck. --Subrata Best regards, Aurélien Subrata Modak wrote: *** Warning: Your file, rpc-test-suite.tar.bz2, contains more than 32 files after decompression and cannot be scanned. *** Well i am waiting for reply to the proposals that i made below. Is it possible for you to submit a Patch on the lines other Network Tests in general and NFS tests in Particular, that are written in LTP. I would also like to know more about the prospect of including the attached test suite inside LTP from the community. What do you feel about including the same in LTP after some tweaking ?? --Subrata On Mon, 2007-12-10 at 15:11 +0530, Subrata Modak wrote: On Mon, 2007-12-10 at 08:51 +0100, Aurélien Charbon wrote: Hi, A test-suite for RPC linux libraries has been developped by our NFSv4 team. I sent a message with code as attachment to the ltp-list, because it would be great to see the code integrated and used in the LTP testsuite. Unfortunately I did not get any answer about that code. I have a question: does the code have to necessarily use the LTP test harness API to be included in the project ? Thanks you in advance for advice. Best regards, Aurélien I had replied to you earlier on this. May be the mail has not reached you. I will paste my Reply below to the same mail you sent earlier: Aurélien Charbon [EMAIL PROTECTED] wrote on 11/30/2007 07:50:02 PM: Hi, A test-suite for RPC linux libraries has been developped in our NFSv4 team. I sent a message with the code as attachment to the ltp-list, because it would be great to see the code integrated and used in the LTP testsuite. Thank you. I received it long back. Yes it would be great to have any sort of Value addition to LTP. We welcome you to give us any nonexistent test cases to LTP. Unfortunately I did not get any answer about that code. Sorry for that. I have a question: does the code have to necessarily use the LTP test harness API to be included in the project ? May not be always. It depends on the type of Test Cases that we are trying to Integrate to LTP. For example, KDUMP is executed Exclusively and does not run with runltp script. So it is not a problem if it reports results in itś own format, but, the same is not with NUMA. So, i got the NUMA guy to write it in Ltp TEST HARNESS API. So, it depends upon the type of Integration. I think the Network testcases in LTP does not follow the LTP API as again Network Test Cases are run separately in most instances. Having said that, i would like to see your test cases in the form of some new subdirectory under ltp/testcases/network. There are already nfs and nfsv4 test cases existing. Please go through them and see whether the functionality they cover are also covered by your test cases, then in such a case there will be just the duplication of same functionality testing. Can you please come up with an idea to find out the exact place where we can comfortably put your test cases in LTP ?? And then submit a Patch in this regard. I would be more than happy to see your test cases in LTP. I am attaching the same once again for everybody to review. Let us come up with an IDEA to include Charbonś contribution in LTP. --Subrata-- -
[LTP] patch for main LTP Makefile
Hi, I have move the config.mk inclusion to the start of a the makefile. The reason for doing this is that the config.mk would have configuration settings for my custom tool chain which I would want to set first. -- Regards, Riaz Ur Rahaman --- ltp-full-20071130/Makefile 2006-06-22 09:46:59.0 +0530 +++ new-ltp-full-20071130/Makefile 2007-12-21 10:56:24.0 +0530 @@ -27,6 +27,8 @@ # in the commandline and in the Makefiles use a dummy variable like in # CFLAGS +-include config.mk + ifdef CROSS_COMPILE CROSS_COMPILER = $(CROSS_COMPILE) endif @@ -38,8 +40,6 @@ endif export CFLAGS += -Wall $(CROSS_CFLAGS) export CC AR LDFLAGS --include config.mk - all: libltp.a @$(MAKE) -C pan $@ @$(MAKE) -C testcases $@ - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/___ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
Re: [LTP] Se-Linux Updates for LTP
Quoting Stephen Smalley ([EMAIL PROTECTED]): On Thu, 2007-12-20 at 09:32 -0600, Serge E. Hallyn wrote: Quoting Subrata Modak ([EMAIL PROTECTED]): Ok. Stephen?? Patch has been Recalled and Jeff?? Applied for all the Fixes he mentions. Thanks to you all for getting this Fixed. --Subrata For the policy to compile without warnings on Fedora 8, I needed the following patch as well. I'm not sure whether it's safe for RHEL5 machines then, though, if the *_bin_* macros there don't include sbin. Don't apply - my original patch likewise switched the sbin to bin references, and that broke the test policy on rhel5. Ok, I feared as much. What we need is better encapsulation of the test policy dependencies. Until then, we may need to maintain multiple test policies for different distro+release combinations, possibly as a common base plus a per-distro-release diff. Sounds reasonable. Module couldn't install because semodule runs out of memory on a 1G ram machine :( Hmmm...that's interesting; I haven't seen that. Take that up as a separate issue on selinux list with as much detail as possible. Will do. Maybe it would help to load the modules for one test at a time, but semodule takes so long that might make the test an all-night affair. Shouldn't be required - let's fix the real problem instead. Ok. thanks, -serge - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
Re: [LTP] Se-Linux Updates for LTP
On Thu, 2007-12-20 at 09:32 -0600, Serge E. Hallyn wrote: Quoting Subrata Modak ([EMAIL PROTECTED]): Ok. Stephen?? Patch has been Recalled and Jeff?? Applied for all the Fixes he mentions. Thanks to you all for getting this Fixed. --Subrata For the policy to compile without warnings on Fedora 8, I needed the following patch as well. I'm not sure whether it's safe for RHEL5 machines then, though, if the *_bin_* macros there don't include sbin. Don't apply - my original patch likewise switched the sbin to bin references, and that broke the test policy on rhel5. What we need is better encapsulation of the test policy dependencies. Until then, we may need to maintain multiple test policies for different distro+release combinations, possibly as a common base plus a per-distro-release diff. Module couldn't install because semodule runs out of memory on a 1G ram machine :( Hmmm...that's interesting; I haven't seen that. Take that up as a separate issue on selinux list with as much detail as possible. Maybe it would help to load the modules for one test at a time, but semodule takes so long that might make the test an all-night affair. Shouldn't be required - let's fix the real problem instead. -- Stephen Smalley National Security Agency - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
