Re: [LTP] [PATCH] cgroup_fj: renamed arguments because the previous ones were not clear.
Hi! > +''|*[!0-9]*) > + usage > + exit_parameter;; > +*) ;; > esac I've removed the trailing whitespace at the end of the ''|*[!0-9]*) and updated the commit message and pushed, thanks. BTW: The canonical format for the git commit message is: short commit description <= 50 characters [empty line] longer commit description that may span across multiple lines with lines up to 72 chars long... [empty line] Signed-off-by: ... -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
Re: [LTP] [PATCH] cgroup_fj: renamed arguments because the previous ones were not clear.
Hi! > case $mount_times in > -"1" ) > +"1"|"100") > mount_times=1 > ;; > -"2" ) > - mount_times=100 > - ;; > * ) Hmm, after the change the mount_times is always set to 1 (forget to remove mount_times=1?). Also we may only want to check that the parameter is a numeric so that we can tune the test parameters later (and for other parameters that can be tuned such as number of subgroup as well). The portable way to do that seems to be case statement: case $mount_times in ''|*[!0-9]*) usage;; *) ;; esac Otherwise the patch looks good. -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
