Re: [LyX/master] Enable OK/Apply buttons when resetting to class defaults.

2017-11-01 Thread Scott Kostyshak 
On Wed, Nov 01, 2017 at 11:34:23PM +, Uwe Stöhr wrote:
> El 01.11.2017 a las 19:20, Scott Kostyshak escribió:
> 
> > Go ahead to 2.3.x branch. Although we have not officially released RC1,
> > we have referred to the installers publicly and I have pushed the commit
> > and tag, so there's no going backward now. If any blocker is found, we
> > would have to move to RC2.
> 
> Hi Scott,
> 
> does this mean 2.3.x is open so that I can commit installer and doc changes?

Yes go ahead.

Scott


signature.asc
Description: PGP signature

Re: [LyX/master] Enable OK/Apply buttons when resetting to class defaults.

2017-11-01 Thread Uwe Stöhr 

El 01.11.2017 a las 19:20, Scott Kostyshak escribió:


Go ahead to 2.3.x branch. Although we have not officially released RC1,
we have referred to the installers publicly and I have pushed the commit
and tag, so there's no going backward now. If any blocker is found, we
would have to move to RC2.


Hi Scott,

does this mean 2.3.x is open so that I can commit installer and doc changes?

regards Uwe

Re: [LyX/master] Enable OK/Apply buttons when resetting to class defaults.

2017-11-01 Thread Scott Kostyshak 
On Wed, Nov 01, 2017 at 05:08:33PM +, Jürgen Spitzmüller wrote:
> Am Mittwoch, den 01.11.2017, 11:43 -0400 schrieb Richard Heck:
> > +1, as it is simple enough, but I guess we have to wait until 2.3.x
> > is
> > open again,
> > after the release of RC1.
> 
> Yes.

Go ahead to 2.3.x branch. Although we have not officially released RC1,
we have referred to the installers publicly and I have pushed the commit
and tag, so there's no going backward now. If any blocker is found, we
would have to move to RC2.

Thanks,

Scott


signature.asc
Description: PGP signature

Re: [LyX/master] Enable OK/Apply buttons when resetting to class defaults.

2017-11-01 Thread Jürgen Spitzmüller 
Am Mittwoch, den 01.11.2017, 11:43 -0400 schrieb Richard Heck:
> +1, as it is simple enough, but I guess we have to wait until 2.3.x
> is
> open again,
> after the release of RC1.

Yes.

> It's fine for 2.2.x, too. Seems totally safe.

Backported to 2.2.x.

Jürgen

> 
> Richard
> 

signature.asc
Description: This is a digitally signed message part

Re: [LyX/master] Enable OK/Apply buttons when resetting to class defaults.

2017-11-01 Thread Richard Heck 
On 11/01/2017 07:05 AM, Jürgen Spitzmüller wrote:
> Am Mittwoch, den 01.11.2017, 12:04 +0100 schrieb Juergen Spitzmueller:
>> commit b851a349b6f303824f329a5dc854827f66828764
>> Author: Juergen Spitzmueller 
>> Date:   Wed Nov 1 12:03:54 2017 +0100
>>
>> Enable OK/Apply buttons when resetting to class defaults.
>> ---
>>  src/frontends/qt4/GuiDocument.cpp |1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/src/frontends/qt4/GuiDocument.cpp
>> b/src/frontends/qt4/GuiDocument.cpp
>> index e80e7ec..385b376 100644
>> --- a/src/frontends/qt4/GuiDocument.cpp
>> +++ b/src/frontends/qt4/GuiDocument.cpp
>> @@ -4149,6 +4149,7 @@ void GuiDocument::useClassDefaults()
>>  }
>>  bp_.useClassDefaults();
>>  paramsToDialog();
>> +changed();
>>  }
> This should go to 2.3.x (and possibly 2.2.x) eventually.

+1, as it is simple enough, but I guess we have to wait until 2.3.x is
open again,
after the release of RC1.

It's fine for 2.2.x, too. Seems totally safe.

Richard

Re: [LyX/master] Enable OK/Apply buttons when resetting to class defaults.

2017-11-01 Thread Jürgen Spitzmüller 
Am Mittwoch, den 01.11.2017, 12:04 +0100 schrieb Juergen Spitzmueller:
> commit b851a349b6f303824f329a5dc854827f66828764
> Author: Juergen Spitzmueller 
> Date:   Wed Nov 1 12:03:54 2017 +0100
> 
> Enable OK/Apply buttons when resetting to class defaults.
> ---
>  src/frontends/qt4/GuiDocument.cpp |1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/src/frontends/qt4/GuiDocument.cpp
> b/src/frontends/qt4/GuiDocument.cpp
> index e80e7ec..385b376 100644
> --- a/src/frontends/qt4/GuiDocument.cpp
> +++ b/src/frontends/qt4/GuiDocument.cpp
> @@ -4149,6 +4149,7 @@ void GuiDocument::useClassDefaults()
>   }
>   bp_.useClassDefaults();
>   paramsToDialog();
> + changed();
>  }

This should go to 2.3.x (and possibly 2.2.x) eventually.

Jürgen

signature.asc
Description: This is a digitally signed message part