Re: [Devel] [PATCH] qbox

2003-12-05 Thread Juergen Spitzmueller
Angus Leeming wrote:
 Jürgen, LengthCombo derives publicly from QComboBox. I think therfore that
 this isn't needed:

 +void LengthCombo::setCurrentItem(int item)
 +{
 +   QComboBox::setCurrentItem(item);
 +}

 The code will just do the right thing.

I'd guess so too, but then I get the error below. Seems that the function is 
somehow overwritten by Lengthcombo::setCurrentItem(LyXLength::unit unit) and 
has to be reimplemented.

QBox.C: In member function `virtual void QBox::update_contents()':
QBox.C:130: error: invalid conversion from `int' to `LyXLength::UNIT'
QBox.C:130: error:   initializing argument 1 of `virtual void
   LengthCombo::setCurrentItem(LyXLength::UNIT)'
QBox.C:147: error: invalid conversion from `int' to `LyXLength::UNIT'
QBox.C:147: error:   initializing argument 1 of `virtual void
   LengthCombo::setCurrentItem(LyXLength::UNIT)'
make[5]: *** [QBox.lo] Fehler 1

Regards,
Jürgen.



Re: [Devel] [PATCH] qbox

2003-12-05 Thread Angus Leeming
Juergen Spitzmueller wrote:
 Jürgen, LengthCombo derives publicly from QComboBox. I think
 therfore that this isn't needed:

 +void LengthCombo::setCurrentItem(int item)
 +{
 +   QComboBox::setCurrentItem(item);
 +}

 The code will just do the right thing.
 
 I'd guess so too, but then I get the error below. Seems that the
 function is somehow overwritten by
 Lengthcombo::setCurrentItem(LyXLength::unit unit) and has to be
 reimplemented.

Ohhh!

-- 
Angus



Re: [PATCH] qbox

2003-12-05 Thread Kornel Benko
-BEGIN PGP SIGNED MESSAGE-

On Donnerstag, 4. Dezember 2003 21:33, Juergen Spitzmueller wrote:
 I have tried to make the ui as simple and intuitive as possible. Therefore
 the code may look a bit tricky (but it works in all cases afaict). And
 another small enhancement to lengthcombo was needed.

 Hope you like it. I will apply during the weekend if I get no objections.

I like it.

 Jürgen

Kornel
- -- 
Kornel Benko
[EMAIL PROTECTED]
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.2.1 (GNU/Linux)

iQCVAwUBP9BczrewfbDGmeqhAQHnFAP/WcZ4bsw74Wrc399hO845nKnyitqICCV2
pSVFujuT9dWZeIZ96eQ8OsVNAIV8/30ATGUj1Ns9dmkWr8lWOxXY5q4OiIevMwJD
EpXblF2s+Tooi0yfI6PouGjn8dTbXSR62zIlsySv8LF0IZNwkwZyZzTjkTiPorGe
zDxUGqSmE+0=
=7vDf
-END PGP SIGNATURE-



Re: [Devel] [PATCH] qbox

2003-12-05 Thread Juergen Spitzmueller
Angus Leeming wrote:
> Jürgen, LengthCombo derives publicly from QComboBox. I think therfore that
> this isn't needed:
>
> +void LengthCombo::setCurrentItem(int item)
> +{
> +   QComboBox::setCurrentItem(item);
> +}
>
> The code will just do the right thing.

I'd guess so too, but then I get the error below. Seems that the function is 
somehow overwritten by Lengthcombo::setCurrentItem(LyXLength::unit unit) and 
has to be reimplemented.

QBox.C: In member function `virtual void QBox::update_contents()':
QBox.C:130: error: invalid conversion from `int' to `LyXLength::UNIT'
QBox.C:130: error:   initializing argument 1 of `virtual void
   LengthCombo::setCurrentItem(LyXLength::UNIT)'
QBox.C:147: error: invalid conversion from `int' to `LyXLength::UNIT'
QBox.C:147: error:   initializing argument 1 of `virtual void
   LengthCombo::setCurrentItem(LyXLength::UNIT)'
make[5]: *** [QBox.lo] Fehler 1

Regards,
Jürgen.



Re: [Devel] [PATCH] qbox

2003-12-05 Thread Angus Leeming
Juergen Spitzmueller wrote:
>> Jürgen, LengthCombo derives publicly from QComboBox. I think
>> therfore that this isn't needed:
>>
>> +void LengthCombo::setCurrentItem(int item)
>> +{
>> +   QComboBox::setCurrentItem(item);
>> +}
>>
>> The code will just do the right thing.
> 
> I'd guess so too, but then I get the error below. Seems that the
> function is somehow overwritten by
> Lengthcombo::setCurrentItem(LyXLength::unit unit) and has to be
> reimplemented.

Ohhh!

-- 
Angus



Re: [PATCH] qbox

2003-12-05 Thread Kornel Benko
-BEGIN PGP SIGNED MESSAGE-

On Donnerstag, 4. Dezember 2003 21:33, Juergen Spitzmueller wrote:
> I have tried to make the ui as simple and intuitive as possible. Therefore
> the code may look a bit tricky (but it works in all cases afaict). And
> another small enhancement to lengthcombo was needed.
>
> Hope you like it. I will apply during the weekend if I get no objections.

I like it.

> Jürgen

Kornel
- -- 
Kornel Benko
[EMAIL PROTECTED]
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.2.1 (GNU/Linux)

iQCVAwUBP9BczrewfbDGmeqhAQHnFAP/WcZ4bsw74Wrc399hO845nKnyitqICCV2
pSVFujuT9dWZeIZ96eQ8OsVNAIV8/30ATGUj1Ns9dmkWr8lWOxXY5q4OiIevMwJD
EpXblF2s+Tooi0yfI6PouGjn8dTbXSR62zIlsySv8LF0IZNwkwZyZzTjkTiPorGe
zDxUGqSmE+0=
=7vDf
-END PGP SIGNATURE-



[PATCH] qbox

2003-12-04 Thread Juergen Spitzmueller
I have tried to make the ui as simple and intuitive as possible. Therefore the 
code may look a bit tricky (but it works in all cases afaict). And another 
small enhancement to lengthcombo was needed.

Hope you like it. I will apply during the weekend if I get no objections.

Jürgen



qbox.diff.gz
Description: GNU Zip compressed data


[PATCH] qbox

2003-12-04 Thread Juergen Spitzmueller
I have tried to make the ui as simple and intuitive as possible. Therefore the 
code may look a bit tricky (but it works in all cases afaict). And another 
small enhancement to lengthcombo was needed.

Hope you like it. I will apply during the weekend if I get no objections.

Jürgen



qbox.diff.gz
Description: GNU Zip compressed data