Re: Default to Qt 4 or Qt 5 with our build systems?

[Pavel Sanda]

Scott Kostyshak wrote:
> > The INSTALL file is up to date. It recommends 5.6 and suggests 5.4 at least.
> > 5.4 is good in theory (this was lowered after some bugs were fixed), 5.5.1
> > got more testing. There is no definitive answer here.
> 
> +1
> 
> Should we also put it in RELEASE-NOTES or should we keep that only for
> when something changes with respect to the previous major version?

If INSTALL is up-to-date then we don't need to mess with REL notes. P

Re: Default to Qt 4 or Qt 5 with our build systems?

[Scott Kostyshak]

On Thu, May 04, 2017 at 10:30:11PM +0200, Guillaume MM wrote:
> Le 04/05/2017 à 19:43, Pavel Sanda a écrit :
> > Guillaume MM wrote:
> > > Le 01/05/2017 ?? 18:43, Jean-Marc Lasgouttes a écrit :
> > > > We can define a lower bound for acceptable qt5 version like we do for
> > > > python 3 vs 2. I would not want a crappy qt 5.1 on a system with a
> > > > perfectly valid qt4.8.
> > > > 
> > > > Note that the end of life warning is not relevant on old systems (in 
> > > > Linux
> > > > world).
> > > > 
> > > > So, what is the minimal good qt5 version ?
> > > 
> > > Qt 5.5.1 AFAICR
> > 
> > -> RELEASE_NOTES ?
> > 
> 
> The INSTALL file is up to date. It recommends 5.6 and suggests 5.4 at least.
> 5.4 is good in theory (this was lowered after some bugs were fixed), 5.5.1
> got more testing. There is no definitive answer here.

+1

Should we also put it in RELEASE-NOTES or should we keep that only for
when something changes with respect to the previous major version?

Scott


signature.asc
Description: PGP signature

Re: Default to Qt 4 or Qt 5 with our build systems?

[Guillaume MM]

Le 04/05/2017 à 19:43, Pavel Sanda a écrit :

Guillaume MM wrote:

Le 01/05/2017 ?? 18:43, Jean-Marc Lasgouttes a écrit :

We can define a lower bound for acceptable qt5 version like we do for
python 3 vs 2. I would not want a crappy qt 5.1 on a system with a
perfectly valid qt4.8.

Note that the end of life warning is not relevant on old systems (in Linux
world).

So, what is the minimal good qt5 version ?


Qt 5.5.1 AFAICR


-> RELEASE_NOTES ?



The INSTALL file is up to date. It recommends 5.6 and suggests 5.4 at 
least. 5.4 is good in theory (this was lowered after some bugs were 
fixed), 5.5.1 got more testing. There is no definitive answer here.

Re: Default to Qt 4 or Qt 5 with our build systems?

[Pavel Sanda]

Guillaume MM wrote:
> Le 01/05/2017 ?? 18:43, Jean-Marc Lasgouttes a écrit :
>> We can define a lower bound for acceptable qt5 version like we do for 
>> python 3 vs 2. I would not want a crappy qt 5.1 on a system with a 
>> perfectly valid qt4.8.
>>
>> Note that the end of life warning is not relevant on old systems (in Linux 
>> world).
>>
>> So, what is the minimal good qt5 version ?
>
> Qt 5.5.1 AFAICR

-> RELEASE_NOTES ?

Re: Default to Qt 4 or Qt 5 with our build systems?

[Richard Heck]

On 05/01/2017 05:37 AM, José Abílio Matos wrote:
> On Monday, 1 May 2017 03.46.51 WEST Richard Heck wrote:
>> On 04/30/2017 07:23 PM, Scott Kostyshak wrote:
>>> Suppose that a system has both Qt 4 and Qt 5 development libraries
>>> installed. Should our automake and CMake build systems choose to use Qt
>>> 4 or Qt 5?
>>>
>>> Uwe made a good point that Qt 4 support is ending. See, for example, the
>>>
>>> following paragraph (from [1]):
>>>   Qt 4.8.7 is planned to be the last patch release of the Qt 4 series.
>>>   Standard support is available until December 2015, after which extended
>>>   support will be available. We recommend all active projects to migrate
>>>   to Qt 5, as new operating systems and compilers with Qt 4.8 will not be
>>>   supported. If you have challenges migrating to Qt 5, please contact us
>>>   or some of our service partners for assistance.
>>>
>>> The argument to still choose Qt 4 by default is that LyX 5.6 is the
>>> minimum recommended version for LyX.
>>>
>>> If we do want to switch to Qt 5 by default for 2.3.0, perhaps we should
>>> give a warning or error for Qt less than (e.g.) 5.5 (maybe we do
>>> already?).
>> What exactly does one need to do to compile with Qt5 as it is?
>>
>> Richard
> From lyx.spec from Fedora:
>
> %if %{use_qt5}
> BuildRequires: pkgconfig(Qt5Core)
> BuildRequires: pkgconfig(Qt5Widgets)
> BuildRequires: pkgconfig(Qt5Gui)
> BuildRequires: pkgconfig(Qt5Svg)
> BuildRequires: pkgconfig(Qt5X11Extras)
> %else
> BuildRequires: qt4-devel
> %endif
>
> and then when building:
>
> %configure ... --enable-qt5 ...

Thanks for the pointer. For the record, I needed:
qt5-qtbase-devel
qt5-qtsvg-devel
qt5-qtx11extras-devel

Richard

Re: Default to Qt 4 or Qt 5 with our build systems?

[Enrico Forestieri]

On Wed, May 03, 2017 at 11:29:30AM +0200, Jean-Marc Lasgouttes wrote:
> Le 02/05/2017 à 03:13, Scott Kostyshak a écrit :
> > On Mon, May 01, 2017 at 07:21:18PM +0200, Guillaume MM wrote:
> > > Le 01/05/2017 à 18:43, Jean-Marc Lasgouttes a écrit :
> > > > We can define a lower bound for acceptable qt5 version like we do for 
> > > > python 3 vs 2. I would not want a crappy qt 5.1 on a system with a 
> > > > perfectly valid qt4.8.
> > 
> > +1
> 
> I took a quick look at the configure code, but, considering the way the code
> works, it seems a bit difficult to get the qt4 and qt5 versions. Enrico,
> would you have an idea?

It should be possible, but I am short on time lately.

> Having Qt5 as default would be trivial, though.

In this case, I think that we should try to automatically configure
for Qt4 if Qt5 is not available or not adequate.

-- 
Enrico

Re: Default to Qt 4 or Qt 5 with our build systems?

[Jean-Marc Lasgouttes]

Le 02/05/2017 à 03:13, Scott Kostyshak a écrit :

On Mon, May 01, 2017 at 07:21:18PM +0200, Guillaume MM wrote:

Le 01/05/2017 à 18:43, Jean-Marc Lasgouttes a écrit :

We can define a lower bound for acceptable qt5 version like we do for python 3 
vs 2. I would not want a crappy qt 5.1 on a system with a perfectly valid qt4.8.


+1


I took a quick look at the configure code, but, considering the way the 
code works, it seems a bit difficult to get the qt4 and qt5 versions. 
Enrico, would you have an idea?


Having Qt5 as default would be trivial, though.

JMarc

Re: Default to Qt 4 or Qt 5 with our build systems?

[Jean-Marc Lasgouttes]

Le 01/05/2017 à 22:18, Uwe Stöhr a écrit :

The plan was not to require Qt 5.1  but just to set in CMake the default
switch from Qt4 to Qt5. What Qt5 version you use its up to you.


The Qt5 that LyX makes me use is the Qt5 that is packaged on my system 
(on Linux).


JMarc

Re: Default to Qt 4 or Qt 5 with our build systems?

[Scott Kostyshak]

On Mon, May 01, 2017 at 10:18:28PM +0200, Uwe Stöhr wrote:
> El 01.05.2017 a las 18:43, Jean-Marc Lasgouttes escribió:
> 
> > We can define a lower bound for acceptable qt5 version like we do for 
> > python 3 vs 2. I would not want a crappy qt 5.1 on a system with a 
> > perfectly valid qt4.8.
> 
> The plan was not to require Qt 5.1  but just to set in CMake the default
> switch from Qt4 to Qt5.

But I think the two discussions are related.

> What Qt5 version you use its up to you.

Yes, but I think it is good to guide the user and to not expect that
they will read the release notes. I personally appreciate it when I
build software and it fails to build if the configuration I tried leads
to known bugs.

Scott


signature.asc
Description: PGP signature

Re: Default to Qt 4 or Qt 5 with our build systems?

[Scott Kostyshak]

On Mon, May 01, 2017 at 07:21:18PM +0200, Guillaume MM wrote:
> Le 01/05/2017 à 18:43, Jean-Marc Lasgouttes a écrit :
> > We can define a lower bound for acceptable qt5 version like we do for 
> > python 3 vs 2. I would not want a crappy qt 5.1 on a system with a 
> > perfectly valid qt4.8.

+1

> > 
> > Note that the end of life warning is not relevant on old systems (in Linux 
> > world).
> > 
> > So, what is the minimal good qt5 version ?
> 
> Qt 5.5.1 AFAICR

+1

Scott


signature.asc
Description: PGP signature

Re: Default to Qt 4 or Qt 5 with our build systems?

[Uwe Stöhr]

El 01.05.2017 a las 18:43, Jean-Marc Lasgouttes escribió:


We can define a lower bound for acceptable qt5 version like we do for python 3 
vs 2. I would not want a crappy qt 5.1 on a system with a perfectly valid qt4.8.


The plan was not to require Qt 5.1  but just to set in CMake the default 
switch from Qt4 to Qt5. What Qt5 version you use its up to you.


In my opinion Qt 5.6 is a good choice because it is a long term support 
series.
In my opinion the security issues affect us. Delivering Qt DLLs that 
have security issues will also affect LyX. Therefore for me as packager 
it is important to use a release for which I regularly get security fixes.
However, I id not want do force a certain Qt version, I just wanted to 
have the CMake default switch to be "Qt5".


regards Uwe

Re: Default to Qt 4 or Qt 5 with our build systems?

[Guillaume MM]

Le 01/05/2017 à 18:43, Jean-Marc Lasgouttes a écrit :

We can define a lower bound for acceptable qt5 version like we do for python 3 
vs 2. I would not want a crappy qt 5.1 on a system with a perfectly valid qt4.8.

Note that the end of life warning is not relevant on old systems (in Linux 
world).

So, what is the minimal good qt5 version ?


Qt 5.5.1 AFAICR

Re: Default to Qt 4 or Qt 5 with our build systems?

[Jean-Marc Lasgouttes]

We can define a lower bound for acceptable qt5 version like we do for python 3 
vs 2. I would not want a crappy qt 5.1 on a system with a perfectly valid 
qt4.8. 

Note that the end of life warning is not relevant on old systems (in Linux 
world).

So, what is the minimal good qt5 version ?

JMarc

Le 1 mai 2017 01:23:41 GMT+02:00, Scott Kostyshak  a écrit :
>Suppose that a system has both Qt 4 and Qt 5 development libraries
>installed. Should our automake and CMake build systems choose to use Qt
>4 or Qt 5?
>
>
>The argument to still choose Qt 4 by default is that LyX 5.6 is the
>minimum recommended version for LyX.
>
>If we do want to switch to Qt 5 by default for 2.3.0, perhaps we should
>give a warning or error for Qt less than (e.g.) 5.5 (maybe we do
>already?).

Re: Default to Qt 4 or Qt 5 with our build systems?

[José Abílio Matos]

On Monday, 1 May 2017 03.46.51 WEST Richard Heck wrote:
> On 04/30/2017 07:23 PM, Scott Kostyshak wrote:
> > Suppose that a system has both Qt 4 and Qt 5 development libraries
> > installed. Should our automake and CMake build systems choose to use Qt
> > 4 or Qt 5?
> > 
> > Uwe made a good point that Qt 4 support is ending. See, for example, the
> > 
> > following paragraph (from [1]):
> >   Qt 4.8.7 is planned to be the last patch release of the Qt 4 series.
> >   Standard support is available until December 2015, after which extended
> >   support will be available. We recommend all active projects to migrate
> >   to Qt 5, as new operating systems and compilers with Qt 4.8 will not be
> >   supported. If you have challenges migrating to Qt 5, please contact us
> >   or some of our service partners for assistance.
> > 
> > The argument to still choose Qt 4 by default is that LyX 5.6 is the
> > minimum recommended version for LyX.
> > 
> > If we do want to switch to Qt 5 by default for 2.3.0, perhaps we should
> > give a warning or error for Qt less than (e.g.) 5.5 (maybe we do
> > already?).
> 
> What exactly does one need to do to compile with Qt5 as it is?
> 
> Richard

From lyx.spec from Fedora:

%if %{use_qt5}
BuildRequires: pkgconfig(Qt5Core)
BuildRequires: pkgconfig(Qt5Widgets)
BuildRequires: pkgconfig(Qt5Gui)
BuildRequires: pkgconfig(Qt5Svg)
BuildRequires: pkgconfig(Qt5X11Extras)
%else
BuildRequires: qt4-devel
%endif

and then when building:

%configure ... --enable-qt5 ...

-- 
José Abílio

Re: Default to Qt 4 or Qt 5 with our build systems?

[Kornel Benko]

Am Sonntag, 30. April 2017 um 22:46:51, schrieb Richard Heck 
> On 04/30/2017 07:23 PM, Scott Kostyshak wrote:
> > Suppose that a system has both Qt 4 and Qt 5 development libraries
> > installed. Should our automake and CMake build systems choose to use Qt
> > 4 or Qt 5?
> >
> > Uwe made a good point that Qt 4 support is ending. See, for example, the
> > following paragraph (from [1]): 
> >
> >   Qt 4.8.7 is planned to be the last patch release of the Qt 4 series.
> >   Standard support is available until December 2015, after which extended
> >   support will be available. We recommend all active projects to migrate
> >   to Qt 5, as new operating systems and compilers with Qt 4.8 will not be
> >   supported. If you have challenges migrating to Qt 5, please contact us
> >   or some of our service partners for assistance.
> >
> > The argument to still choose Qt 4 by default is that LyX 5.6 is the
> > minimum recommended version for LyX.
> >
> > If we do want to switch to Qt 5 by default for 2.3.0, perhaps we should
> > give a warning or error for Qt less than (e.g.) 5.5 (maybe we do
> > already?).
> 
> What exactly does one need to do to compile with Qt5 as it is?
> 
> Richard

For cmake build you need the devel packages.
On debian based system they are
qtbase5-dev libqt5svg5-dev libqt5x11extras5-dev
 Configure with
# cmake  -DLYX_USE_QT=QT5 ...

Kornel


signature.asc
Description: This is a digitally signed message part.

Re: Default to Qt 4 or Qt 5 with our build systems?

[Richard Heck]

On 04/30/2017 07:23 PM, Scott Kostyshak wrote:
> Suppose that a system has both Qt 4 and Qt 5 development libraries
> installed. Should our automake and CMake build systems choose to use Qt
> 4 or Qt 5?
>
> Uwe made a good point that Qt 4 support is ending. See, for example, the
> following paragraph (from [1]): 
>
>   Qt 4.8.7 is planned to be the last patch release of the Qt 4 series.
>   Standard support is available until December 2015, after which extended
>   support will be available. We recommend all active projects to migrate
>   to Qt 5, as new operating systems and compilers with Qt 4.8 will not be
>   supported. If you have challenges migrating to Qt 5, please contact us
>   or some of our service partners for assistance.
>
> The argument to still choose Qt 4 by default is that LyX 5.6 is the
> minimum recommended version for LyX.
>
> If we do want to switch to Qt 5 by default for 2.3.0, perhaps we should
> give a warning or error for Qt less than (e.g.) 5.5 (maybe we do
> already?).

What exactly does one need to do to compile with Qt5 as it is?

Richard

Default to Qt 4 or Qt 5 with our build systems?

[Scott Kostyshak]

Suppose that a system has both Qt 4 and Qt 5 development libraries
installed. Should our automake and CMake build systems choose to use Qt
4 or Qt 5?

Uwe made a good point that Qt 4 support is ending. See, for example, the
following paragraph (from [1]): 

  Qt 4.8.7 is planned to be the last patch release of the Qt 4 series.
  Standard support is available until December 2015, after which extended
  support will be available. We recommend all active projects to migrate
  to Qt 5, as new operating systems and compilers with Qt 4.8 will not be
  supported. If you have challenges migrating to Qt 5, please contact us
  or some of our service partners for assistance.

The argument to still choose Qt 4 by default is that LyX 5.6 is the
minimum recommended version for LyX.

If we do want to switch to Qt 5 by default for 2.3.0, perhaps we should
give a warning or error for Qt less than (e.g.) 5.5 (maybe we do
already?).

Scott

[1] http://blog.qt.io/blog/2015/05/26/qt-4-8-7-released/


signature.asc
Description: PGP signature