Re: lyx2lyx bug in 2.x -> 1.6.x

2023-01-07 Thread Scott Kostyshak
On Sat, Jan 07, 2023 at 11:39:20AM -0500, Richard Kimberly Heck wrote:
> On 1/6/23 14:02, Jürgen Spitzmüller wrote:
> > Am Freitag, dem 06.01.2023 um 13:51 -0500 schrieb Richard Kimberly
> > Heck:
> > > And not that it matters, but git blame makes it look like I'm the one
> > > who forgot this. I'm not.
> > I know. A closer look at the logs revealed tat you just fixed up the
> > method.
> 
> I thought you probably knew, but others who looked might not have noticed.

Indeed, I thought you were the one to blame in the "introduced the code"
sense, although I promise I did not blame you in the "how dare you
introduce a bug, I've never done that!" sense :).

In any case, the record now shows you were not to blame in either sense.

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: lyx2lyx bug in 2.x -> 1.6.x

2023-01-07 Thread Richard Kimberly Heck

On 1/6/23 14:02, Jürgen Spitzmüller wrote:

Am Freitag, dem 06.01.2023 um 13:51 -0500 schrieb Richard Kimberly
Heck:

And not that it matters, but git blame makes it look like I'm the one
who forgot this. I'm not.

I know. A closer look at the logs revealed tat you just fixed up the
method.


I thought you probably knew, but others who looked might not have noticed.

Riki


--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: lyx2lyx bug in 2.x -> 1.6.x

2023-01-06 Thread Jürgen Spitzmüller
Am Freitag, dem 06.01.2023 um 13:51 -0500 schrieb Richard Kimberly
Heck:
> And not that it matters, but git blame makes it look like I'm the one
> who forgot this. I'm not.

I know. A closer look at the logs revealed tat you just fixed up the
method.

-- 
Jürgen
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: lyx2lyx bug in 2.x -> 1.6.x

2023-01-06 Thread Richard Kimberly Heck

On 1/6/23 13:39, Richard Kimberly Heck wrote:

On 1/6/23 08:41, Jürgen Spitzmüller wrote:

Am Freitag, dem 06.01.2023 um 13:03 +0100 schrieb Jürgen Spitzmüller:

A revert routine is missing that removes the newpage inset before
such bibtex insets (in the formats before, a clear(double)page is
part of the code the bibtex insert generates.

Added at d89a48483e3906.


Thanks.

Cherry picked it for stable.


And not that it matters, but git blame makes it look like I'm the one 
who forgot this. I'm not.


Riki


--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: lyx2lyx bug in 2.x -> 1.6.x

2023-01-06 Thread Richard Kimberly Heck

On 1/6/23 08:41, Jürgen Spitzmüller wrote:

Am Freitag, dem 06.01.2023 um 13:03 +0100 schrieb Jürgen Spitzmüller:

A revert routine is missing that removes the newpage inset before
such bibtex insets (in the formats before, a clear(double)page is
part of the code the bibtex insert generates.

Added at d89a48483e3906.


Thanks.

Cherry picked it for stable.

Riki


--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: lyx2lyx bug in 2.x -> 1.6.x

2023-01-06 Thread Jürgen Spitzmüller
Am Freitag, dem 06.01.2023 um 13:03 +0100 schrieb Jürgen Spitzmüller:
> A revert routine is missing that removes the newpage inset before
> such bibtex insets (in the formats before, a clear(double)page is
> part of the code the bibtex insert generates.

Added at d89a48483e3906.

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: lyx2lyx bug in 2.x -> 1.6.x

2023-01-06 Thread Jürgen Spitzmüller
Am Donnerstag, dem 05.01.2023 um 23:45 -0500 schrieb Scott Kostyshak:
> If convert_bibtex_clearpage(document) in lyx_2_0.py is commented out,
> then the issue goes away (just to give an idea of where the bug is).

A revert routine is missing that removes the newpage inset before such
bibtex insets (in the formats before, a clear(double)page is part of
the code the bibtex insert generates.

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel