Re: New Warnings on Master

2018-12-30 Thread Richard Kimberly Heck 
On 12/30/18 2:35 AM, Jürgen Spitzmüller wrote:
> Am Samstag, den 29.12.2018, 13:13 -0500 schrieb Richard Kimberly Heck:
>> frontends/qt4/GuiToolbar.cpp (449): Unknown dynamic menu type: paste
>> frontends/qt4/GuiToolbar.cpp (449): Unknown dynamic menu type:
>> textstyle-apply
> Are you sure your tree is properly updated? The line numbers given
> here, anyway, don't match current master (where this warning is at line
> 518). Also, I don't know why you get them. Both "paste" and "textstyle-
> apply" are in DynamicMenuButton::isMenuType()

Should have tried building in a fresh directory. It's fine.

Riki

Re: New Warnings on Master

2018-12-29 Thread Jürgen Spitzmüller 
Am Samstag, den 29.12.2018, 13:13 -0500 schrieb Richard Kimberly Heck:
> frontends/qt4/GuiToolbar.cpp (449): Unknown dynamic menu type: paste
> frontends/qt4/GuiToolbar.cpp (449): Unknown dynamic menu type:
> textstyle-apply

Are you sure your tree is properly updated? The line numbers given
here, anyway, don't match current master (where this warning is at line
518). Also, I don't know why you get them. Both "paste" and "textstyle-
apply" are in DynamicMenuButton::isMenuType()

Jürgen


signature.asc
Description: This is a digitally signed message part

New Warnings on Master

2018-12-29 Thread Richard Kimberly Heck 
frontends/qt4/GuiToolbar.cpp (449): Unknown dynamic menu type: paste
frontends/qt4/GuiToolbar.cpp (449): Unknown dynamic menu type:
textstyle-apply

Re: New warnings in master

2017-04-21 Thread Jean-Marc Lasgouttes 

Le 21/04/2017 à 18:12, Guenter Milde a écrit :

This is a result of the addition of tooltips for some special chars (where
the symbol in the GUI is a bit ambiguous...).
No tooltips for the values above is the intended behaviour.

What would be the correct way to silence the warnings?


The lazy solution is to add a
  default:
break;
statement at the end of the switch.

The better solution is to add cases to enumerate all the cases that do 
not need a tooltip. This way you get a warning when adding a new element 
if you did not decide whether a tooltip was needed.


JMarc

Re: New warnings in master

2017-04-21 Thread Guenter Milde 
On 2017-04-20, Guillaume MM wrote:
> ../../src/insets/InsetSpecialChar.cpp: In member function ‘virtual 
> lyx::docstring lyx::InsetSpecialChar::toolTip(const lyx::BufferView&, 
> int, int) const’:
> ../../src/insets/InsetSpecialChar.cpp:92:9: warning: enumeration value 
> ‘LDOTS’ not handled in switch [-Wswitch]
>switch (kind_) {
>   ^
> ../../src/insets/InsetSpecialChar.cpp:92:9: warning: enumeration value 
> ‘MENU_SEPARATOR’ not handled in switch [-Wswitch]
> ../../src/insets/InsetSpecialChar.cpp:92:9: warning: enumeration value 
> ‘PHRASE_LYX’ not handled in switch [-Wswitch]
> ../../src/insets/InsetSpecialChar.cpp:92:9: warning: enumeration value 
> ‘PHRASE_TEX’ not handled in switch [-Wswitch]
> ../../src/insets/InsetSpecialChar.cpp:92:9: warning: enumeration value 
> ‘PHRASE_LATEX2E’ not handled in switch [-Wswitch]
> ../../src/insets/InsetSpecialChar.cpp:92:9: warning: enumeration value 
> ‘PHRASE_LATEX’ not handled in switch [-Wswitch]

This is a result of the addition of tooltips for some special chars (where
the symbol in the GUI is a bit ambiguous...).
No tooltips for the values above is the intended behaviour.

What would be the correct way to silence the warnings?

Günter

New warnings in master

2017-04-20 Thread Guillaume MM 
../../src/insets/InsetSpecialChar.cpp: In member function ‘virtual 
lyx::docstring lyx::InsetSpecialChar::toolTip(const lyx::BufferView&, 
int, int) const’:
../../src/insets/InsetSpecialChar.cpp:92:9: warning: enumeration value 
‘LDOTS’ not handled in switch [-Wswitch]

  switch (kind_) {
 ^
../../src/insets/InsetSpecialChar.cpp:92:9: warning: enumeration value 
‘MENU_SEPARATOR’ not handled in switch [-Wswitch]
../../src/insets/InsetSpecialChar.cpp:92:9: warning: enumeration value 
‘PHRASE_LYX’ not handled in switch [-Wswitch]
../../src/insets/InsetSpecialChar.cpp:92:9: warning: enumeration value 
‘PHRASE_TEX’ not handled in switch [-Wswitch]
../../src/insets/InsetSpecialChar.cpp:92:9: warning: enumeration value 
‘PHRASE_LATEX2E’ not handled in switch [-Wswitch]
../../src/insets/InsetSpecialChar.cpp:92:9: warning: enumeration value 
‘PHRASE_LATEX’ not handled in switch [-Wswitch]


Guillaume

Re: new warnings in master

2016-10-27 Thread Uwe Stöhr 

Am 27.10.2016 um 00:11 schrieb Jean-Marc Lasgouttes:


Thanks, Confirmed that they are now gone.


Sorry, I have overseen this one:

D:\LyXGit\Master\src\RowPainter.cpp(656): warning C4244: 'argument': 
conversion from 'double' to 'int', possible loss of data 
[D:\LyXGit\Master\compile-2015\src\LyX.vcxproj]


regards Uwe

Re: new warnings in master

2016-10-26 Thread Jean-Marc Lasgouttes 
Thanks, Uwe.

Jmarc

Le 27 octobre 2016 00:03:40 GMT+02:00, "Uwe Stöhr"  a écrit :
>Am 26.10.2016 um 10:53 schrieb Jean-Marc Lasgouttes:
>
>> Thanks Uwe, they should be gone now. Please confirm.
>
>Thanks, Confirmed that they are now gone.
>
>regards Uwe

Re: new warnings in master

2016-10-26 Thread Uwe Stöhr 

Am 26.10.2016 um 10:53 schrieb Jean-Marc Lasgouttes:


Thanks Uwe, they should be gone now. Please confirm.


Thanks, Confirmed that they are now gone.

regards Uwe

Re: new warnings in master

2016-10-26 Thread Jean-Marc Lasgouttes 

Le 25/10/2016 à 23:32, Uwe Stöhr a écrit :

Hi JMarc,

these warnings have been introduced today:


Thanks Uwe, they should be gone now. Please confirm.

JMarc



  RowPainter.cpp
D:\LyXGit\Master\src\RowPainter.cpp(621): warning C4244: 'initializing':
conversion from 'double' to 'int', possible loss of data
[D:\LyXGit\Master\compile-2015\src\LyX.vcxproj]
D:\LyXGit\Master\src\RowPainter.cpp(632): warning C4244: 'argument':
conversion from 'double' to 'int', possible loss of data
[D:\LyXGit\Master\compile-2015\src\LyX.vcxproj]
D:\LyXGit\Master\src\RowPainter.cpp(636): warning C4244: 'initializing':
conversion from 'double' to 'int', possible loss of data
[D:\LyXGit\Master\compile-2015\src\LyX.vcxproj]
D:\LyXGit\Master\src\RowPainter.cpp(637): warning C4244: 'initializing':
conversion from 'double' to 'int', possible loss of data
[D:\LyXGit\Master\compile-2015\src\LyX.vcxproj]
D:\LyXGit\Master\src\RowPainter.cpp(643): warning C4244: '+=':
conversion from 'double' to 'int', possible loss of data
[D:\LyXGit\Master\compile-2015\src\LyX.vcxproj]

Could you please have a look?

thanks and regards
Uwe

new warnings in master

2016-10-25 Thread Uwe Stöhr 

Hi JMarc,

these warnings have been introduced today:

  RowPainter.cpp
D:\LyXGit\Master\src\RowPainter.cpp(621): warning C4244: 'initializing': 
conversion from 'double' to 'int', possible loss of data 
[D:\LyXGit\Master\compile-2015\src\LyX.vcxproj]
D:\LyXGit\Master\src\RowPainter.cpp(632): warning C4244: 'argument': 
conversion from 'double' to 'int', possible loss of data 
[D:\LyXGit\Master\compile-2015\src\LyX.vcxproj]
D:\LyXGit\Master\src\RowPainter.cpp(636): warning C4244: 'initializing': 
conversion from 'double' to 'int', possible loss of data 
[D:\LyXGit\Master\compile-2015\src\LyX.vcxproj]
D:\LyXGit\Master\src\RowPainter.cpp(637): warning C4244: 'initializing': 
conversion from 'double' to 'int', possible loss of data 
[D:\LyXGit\Master\compile-2015\src\LyX.vcxproj]
D:\LyXGit\Master\src\RowPainter.cpp(643): warning C4244: '+=': 
conversion from 'double' to 'int', possible loss of data 
[D:\LyXGit\Master\compile-2015\src\LyX.vcxproj]


Could you please have a look?

thanks and regards
Uwe