Re: [Mailman-Developers] How do I turn on/off moderation of subscription requests?
On Mar 23, 2015, at 12:17 PM, Aurelien Bompard wrote: But there's something else: the SubscriptionWorkflow class does not seem to be used anywhere except in the current unit test. Am I missing something ? Nope. It needs to be hooked up. The branch wasn't merged because it was incomplete. Cheers, -Barry pgpmizCpuLOu5.pgp Description: OpenPGP digital signature ___ Mailman-Developers mailing list Mailman-Developers@python.org https://mail.python.org/mailman/listinfo/mailman-developers Mailman FAQ: http://wiki.list.org/x/AgA3 Searchable Archives: http://www.mail-archive.com/mailman-developers%40python.org/ Unsubscribe: https://mail.python.org/mailman/options/mailman-developers/archive%40jab.org Security Policy: http://wiki.list.org/x/QIA9
Re: [Mailman-Developers] How do I turn on/off moderation of subscription requests?
Oops. Looks like I'd forgotten to push them. They should now be available in lp:~barry/mailman/subpolicy Got it. OK, the SubscriptionWorkflow seems correct in implementation but it has almost no tests, so I'll write some. But there's something else: the SubscriptionWorkflow class does not seem to be used anywhere except in the current unit test. Am I missing something ? Aurélien ___ Mailman-Developers mailing list Mailman-Developers@python.org https://mail.python.org/mailman/listinfo/mailman-developers Mailman FAQ: http://wiki.list.org/x/AgA3 Searchable Archives: http://www.mail-archive.com/mailman-developers%40python.org/ Unsubscribe: https://mail.python.org/mailman/options/mailman-developers/archive%40jab.org Security Policy: http://wiki.list.org/x/QIA9
Re: [Mailman-Developers] How do I turn on/off moderation of subscription requests?
Nope. It needs to be hooked up. The branch wasn't merged because it was incomplete. Oh, and the _send_confirmation method is also not implemented. Could you briefly explain how does the confirmation system work? (or point me to the doc, I didn't find it) Thanks Aurélien ___ Mailman-Developers mailing list Mailman-Developers@python.org https://mail.python.org/mailman/listinfo/mailman-developers Mailman FAQ: http://wiki.list.org/x/AgA3 Searchable Archives: http://www.mail-archive.com/mailman-developers%40python.org/ Unsubscribe: https://mail.python.org/mailman/options/mailman-developers/archive%40jab.org Security Policy: http://wiki.list.org/x/QIA9
Re: [Mailman-Developers] How do I turn on/off moderation of subscription requests?
Nope. It needs to be hooked up. The branch wasn't merged because it was incomplete. Ah alright, I'm just adding some tests but it would probably be better you did the hooking up... (or I'll need a good amount of guidance) Thanks Aurélien ___ Mailman-Developers mailing list Mailman-Developers@python.org https://mail.python.org/mailman/listinfo/mailman-developers Mailman FAQ: http://wiki.list.org/x/AgA3 Searchable Archives: http://www.mail-archive.com/mailman-developers%40python.org/ Unsubscribe: https://mail.python.org/mailman/options/mailman-developers/archive%40jab.org Security Policy: http://wiki.list.org/x/QIA9
Re: [Mailman-Developers] How do I turn on/off moderation of subscription requests?
Have a look at the workflow illustrated in my crappy Dia file, which I think is an accurate representation of how the policy should work. Hmm, could you point me to this Dia file please, I can't find it. Thanks! Aurélien ___ Mailman-Developers mailing list Mailman-Developers@python.org https://mail.python.org/mailman/listinfo/mailman-developers Mailman FAQ: http://wiki.list.org/x/AgA3 Searchable Archives: http://www.mail-archive.com/mailman-developers%40python.org/ Unsubscribe: https://mail.python.org/mailman/options/mailman-developers/archive%40jab.org Security Policy: http://wiki.list.org/x/QIA9
Re: [Mailman-Developers] How do I turn on/off moderation of subscription requests?
On Mar 21, 2015, at 10:50 AM, Aurelien Bompard wrote: Hmm, could you point me to this Dia file please, I can't find it. Thanks! Oops. Looks like I'd forgotten to push them. They should now be available in lp:~barry/mailman/subpolicy Cheers, -Barry pgpUyR2fuW394.pgp Description: OpenPGP digital signature ___ Mailman-Developers mailing list Mailman-Developers@python.org https://mail.python.org/mailman/listinfo/mailman-developers Mailman FAQ: http://wiki.list.org/x/AgA3 Searchable Archives: http://www.mail-archive.com/mailman-developers%40python.org/ Unsubscribe: https://mail.python.org/mailman/options/mailman-developers/archive%40jab.org Security Policy: http://wiki.list.org/x/QIA9
Re: [Mailman-Developers] How do I turn on/off moderation of subscription requests?
Do you think I can help you work on that? Or would you prefer doing the initial branch resurrection? Anything I need to know before I start? Alright, I resurrected your branch to the best of my understanding. I hope it's more Lazarus than Reanimator. https://code.launchpad.net/~abompard/mailman/subpolicy All tests pass, but there's still a missing part: the new attribute in the MailingList table must still be actually written as a column, and an Alembic migration script must be generated. I'm going to do that in the next hours (or maybe on Monday), but in the meantime this branch only contains your former code, with minor adaptations. Could you check it out? Thanks! Aurélien ___ Mailman-Developers mailing list Mailman-Developers@python.org https://mail.python.org/mailman/listinfo/mailman-developers Mailman FAQ: http://wiki.list.org/x/AgA3 Searchable Archives: http://www.mail-archive.com/mailman-developers%40python.org/ Unsubscribe: https://mail.python.org/mailman/options/mailman-developers/archive%40jab.org Security Policy: http://wiki.list.org/x/QIA9
Re: [Mailman-Developers] How do I turn on/off moderation of subscription requests?
On Mar 20, 2015, at 04:39 PM, Aurelien Bompard wrote: Alright, I resurrected your branch to the best of my understanding. I hope it's more Lazarus than Reanimator. https://code.launchpad.net/~abompard/mailman/subpolicy All tests pass, but there's still a missing part: the new attribute in the MailingList table must still be actually written as a column, and an Alembic migration script must be generated. I'm going to do that in the next hours (or maybe on Monday), but in the meantime this branch only contains your former code, with minor adaptations. Could you check it out? Wow, that's awesome Aurelien, thanks! I'll grab the branch and start taking a look. The question is, is this the right approach for implementing the subscription policy? Have a look at the workflow illustrated in my crappy Dia file, which I think is an accurate representation of how the policy should work. I have my uncertainties about the implementation. Maybe a fresh look would help. Cheers, -Barry pgpFUvxHxLTKP.pgp Description: OpenPGP digital signature ___ Mailman-Developers mailing list Mailman-Developers@python.org https://mail.python.org/mailman/listinfo/mailman-developers Mailman FAQ: http://wiki.list.org/x/AgA3 Searchable Archives: http://www.mail-archive.com/mailman-developers%40python.org/ Unsubscribe: https://mail.python.org/mailman/options/mailman-developers/archive%40jab.org Security Policy: http://wiki.list.org/x/QIA9
Re: [Mailman-Developers] How do I turn on/off moderation of subscription requests?
@barry - after digging around further I found Aurelien had the same question a
while back
http://comments.gmane.org/gmane.mail.mailman.devel/19301
I also found a message from you in Dec 2014 (can’t find it now after a few
minutes digging….ugh) saying that currently it’s not possible to create lists
via the REST API that require moderator approval to subscribe. I think it
refered to the subpolicy branch
https://code.launchpad.net/~barry/mailman/subpolicy
Currently if I subscribe a new user to a list via the REST API I don’t see
their subscription come up as a held request in:
GET 3.0/lists/{VAR}/requests
POST 3.0/lists/{VAR}/requests/{VAR}
PATCH 3.0/lists/{VAR}/requests/{VAR}
I think this makes sense assuming the subpolicy functionality is not yet
implemented.
Am I on the right track in understanding that its not possible right now to
create a list and hold and moderate subscription requests (via REST)?
thanks
as
On 6 Mar 2015, at 8:39 am, Andrew Stuart andrew.stu...@supercoders.com.au
wrote:
I want to be able to turn off and on the need for moderator to approve
subscription requests.
Would someone mind please pointing out where this is configured?
thanks
as
___
Mailman-Developers mailing list
Mailman-Developers@python.org
https://mail.python.org/mailman/listinfo/mailman-developers
Mailman FAQ: http://wiki.list.org/x/AgA3
Searchable Archives:
http://www.mail-archive.com/mailman-developers%40python.org/
Unsubscribe:
https://mail.python.org/mailman/options/mailman-developers/andrew.stuart%40supercoders.com.au
Security Policy: http://wiki.list.org/x/QIA9
___
Mailman-Developers mailing list
Mailman-Developers@python.org
https://mail.python.org/mailman/listinfo/mailman-developers
Mailman FAQ: http://wiki.list.org/x/AgA3
Searchable Archives:
http://www.mail-archive.com/mailman-developers%40python.org/
Unsubscribe:
https://mail.python.org/mailman/options/mailman-developers/archive%40jab.org
Security Policy: http://wiki.list.org/x/QIA9
