Re: [PATCH] aclocal.m4: Enable configure to detect the presence ofterminfo database on OpenBSD
On Fri, 31 Jan 2003, Pavel Roskin wrote: > > I admit that I didn't knew how S-Lang interfaces with the terminfo database > > before I browsed through the code today. However, IMHO, what is > > incompatible here is the S-Lang library itself - there are a couple of > > routines which deal with the terminfo database and if S-Lang used them > > instead of emulating them everything would be fine. > > Are those functions in the curses library? You can ask in the S-Lang > mailing list, but I think it will be easier to reimplement those functions > rather than link to -lcurses. S-Lang used to depend on -lcurses in the > past on some UNIX systems, but this dependency was later eliminated. Yep! I figured that out by myself. I've started a patch but it seems like it'll be taking some time before I can complete it. I'll notify you if I eventually finish it up. ___ Mc-devel mailing list [EMAIL PROTECTED] http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [PATCH] aclocal.m4: Enable configure to detect the presence ofterminfo database on OpenBSD
Hello! > > I don't understand what exactly your patch supposed to fix. What is the > > problem? Have you tested your patch? Does the problem go away? > > Yes, the problem goes away. If it's not clear the problem is that > configure doesn't detect the presence of terminfo database on OpenBSD thus > thinking that terminfo is not available at all and this is not true. OK, then it's not a problem, because configure does the right thing. > I admit that I didn't knew how S-Lang interfaces with the terminfo database > before I browsed through the code today. However, IMHO, what is > incompatible here is the S-Lang library itself - there are a couple of > routines which deal with the terminfo database and if S-Lang used them > instead of emulating them everything would be fine. Are those functions in the curses library? You can ask in the S-Lang mailing list, but I think it will be easier to reimplement those functions rather than link to -lcurses. S-Lang used to depend on -lcurses in the past on some UNIX systems, but this dependency was later eliminated. -- Regards, Pavel Roskin ___ Mc-devel mailing list [EMAIL PROTECTED] http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [PATCH] aclocal.m4: Enable configure to detect the presence ofterminfo database on OpenBSD
On Thu, 30 Jan 2003, Pavel Roskin wrote: > Hello! > > > Here is another simple patch to improve configure's behaviour on OpenBSD. > > I don't understand what exactly your patch supposed to fix. What is the > problem? Have you tested your patch? Does the problem go away? Yes, the problem goes away. If it's not clear the problem is that configure doesn't detect the presence of terminfo database on OpenBSD thus thinking that terminfo is not available at all and this is not true. Now, as I comes to testing the patch - yes I did and it worked. However reading your post I decided to verify again. This time I used gdb so I can be 100% sure - it turns out that the test I did was faked, not intentionally of course. The varibale TERMCAP was set in my .profile file and I didn't notice it. This and the following code in _SLtt_tigetent doomed my test: /* If we are on a termcap based system, use termcap */ if (0 == tcap_getent (term, ti)) return ti; Please, read below... > > [..] > > terminfo(5) on OpenBSD says: > > /usr/share/terminfo.db file containing terminal descrip- > > tions on OpenBSD > > OK, but your patch is for the MC_WITH_MCSLANG macro, which is only called > when using the included S-Lang library. S-Lang doesn't understand > terminfo in a file. > It seems to me that your patch would force mc to use terminfo on a system > where terminfo is only available in an incompatible format. Yes, you're right. I admit that I didn't knew how S-Lang interfaces with the terminfo database before I browsed through the code today. However, IMHO, what is incompatible here is the S-Lang library itself - there are a couple of routines which deal with the terminfo database and if S-Lang used them instead of emulating them everything would be fine. Thanks, for catching this! ___ Mc-devel mailing list [EMAIL PROTECTED] http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [PATCH] aclocal.m4: Enable configure to detect the presence ofterminfo database on OpenBSD
Hello! > Here is another simple patch to improve configure's behaviour on OpenBSD. I don't understand what exactly your patch supposed to fix. What is the problem? Have you tested your patch? Does the problem go away? > [..] > terminfo(5) on OpenBSD says: > /usr/share/terminfo.db file containing terminal descrip- > tions on OpenBSD OK, but your patch is for the MC_WITH_MCSLANG macro, which is only called when using the included S-Lang library. S-Lang doesn't understand terminfo in a file. It seems to me that your patch would force mc to use terminfo on a system where terminfo is only available in an incompatible format. -- Regards, Pavel Roskin ___ Mc-devel mailing list [EMAIL PROTECTED] http://mail.gnome.org/mailman/listinfo/mc-devel
[PATCH] aclocal.m4: Enable configure to detect the presence ofterminfo database on OpenBSD
Hello, Here is another simple patch to improve configure's behaviour on OpenBSD. [..] terminfo(5) on OpenBSD says: /usr/share/terminfo.db file containing terminal descrip- tions on OpenBSD [..] It appears that on OpenBSD 3.2 (i386) the rigth file to look for is /usr/share/misc/terminfo.db . Thanks! --- aclocal.m4 2003-01-29 18:33:51.0 +0100 +++ aclocal.m4.OpenBSD.patch2 2003-01-29 18:33:43.0 +0100 @@ -792,6 +792,19 @@ AC_DEFUN([MC_WITH_MCSLANG], [ use_terminfo=yes fi done + # terminfo(5) on OpenBSD say: + # /usr/share/terminfo.db file containing terminal descrip- + # tions on OpenBSD + # + # It appears that on OpenBSD 3.2 (i386) the rigth file to look + # for is /usr/share/misc/terminfo.db . + # + for tifile in "/usr/share/terminfo.db" \ + "/usr/share/misc/terminfo.db" ; do + if test -f "$tifile" ; then + use_terminfo=yes + fi + done fi # If there is no terminfo, use termcap
