[Mesa-dev] [PATCH] mesa: Make sure we have the talloc cflags when using the talloc headers
Signed-off-by: Thomas Hellstrom thellst...@vmware.com --- src/mesa/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mesa/Makefile b/src/mesa/Makefile index c41c38c..7a6936e 100644 --- a/src/mesa/Makefile +++ b/src/mesa/Makefile @@ -34,7 +34,7 @@ ES1_CPPFLAGS := -DFEATURE_ES1=1 $(DEFINES) ES2_CPPFLAGS := -DFEATURE_ES2=1 $(DEFINES) # append include dirs -MESA_CPPFLAGS += $(INCLUDE_DIRS) +MESA_CPPFLAGS += $(INCLUDE_DIRS) $(TALLOC_CFLAGS) ES1_CPPFLAGS += -I$(TOP)/src/mapi/es1api $(INCLUDE_DIRS) ES2_CPPFLAGS += -I$(TOP)/src/mapi/es2api $(INCLUDE_DIRS) -- 1.6.2.5 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Disappearing patches
On Tue, Oct 19, 2010 at 13:31:35 +0200, Thomas Hellstrom wrote: Hi! I've been trying to send a patch to mesa-dev a couple of times using git send-email, but the message never makes it to the list. Am I the only one having trouble with this? It did make it to the list, both times, as far as I can tell. http://lists.freedesktop.org/pipermail/mesa-dev/2010-October/003575.html http://lists.freedesktop.org/pipermail/mesa-dev/2010-October/003619.html Cheers, Julien ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Disappearing patches
On 10/19/2010 01:55 PM, Julien Cristau wrote: On Tue, Oct 19, 2010 at 13:31:35 +0200, Thomas Hellstrom wrote: Hi! I've been trying to send a patch to mesa-dev a couple of times using git send-email, but the message never makes it to the list. Am I the only one having trouble with this? It did make it to the list, both times, as far as I can tell. http://lists.freedesktop.org/pipermail/mesa-dev/2010-October/003575.html http://lists.freedesktop.org/pipermail/mesa-dev/2010-October/003619.html Cheers, Julien Hmm, Thanks, You're obviously right. I wonder whether it might be the VMware spam filter automatically classifying my patches as crap when the list sends them back... /Thomas ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Disappearing patches
On Tue, Oct 19, 2010 at 14:15:44 +0200, Thomas Hellstrom wrote: On 10/19/2010 01:55 PM, Julien Cristau wrote: On Tue, Oct 19, 2010 at 13:31:35 +0200, Thomas Hellstrom wrote: Hi! I've been trying to send a patch to mesa-dev a couple of times using git send-email, but the message never makes it to the list. Am I the only one having trouble with this? It did make it to the list, both times, as far as I can tell. http://lists.freedesktop.org/pipermail/mesa-dev/2010-October/003575.html http://lists.freedesktop.org/pipermail/mesa-dev/2010-October/003619.html Cheers, Julien Hmm, Thanks, You're obviously right. I wonder whether it might be the VMware spam filter automatically classifying my patches as crap when the list sends them back... It could be mailman deciding that since you're the sender you don't want them through the list? IIRC there's an option for that in the subscription preferences. Cheers, Julien ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Disappearing patches
On Tue, Oct 19, 2010 at 5:24 AM, Julien Cristau jcris...@debian.org wrote: On Tue, Oct 19, 2010 at 14:15:44 +0200, Thomas Hellstrom wrote: On 10/19/2010 01:55 PM, Julien Cristau wrote: On Tue, Oct 19, 2010 at 13:31:35 +0200, Thomas Hellstrom wrote: Hi! I've been trying to send a patch to mesa-dev a couple of times using git send-email, but the message never makes it to the list. Am I the only one having trouble with this? It did make it to the list, both times, as far as I can tell. http://lists.freedesktop.org/pipermail/mesa-dev/2010-October/003575.html http://lists.freedesktop.org/pipermail/mesa-dev/2010-October/003619.html Cheers, Julien Hmm, Thanks, You're obviously right. I wonder whether it might be the VMware spam filter automatically classifying my patches as crap when the list sends them back... It could be mailman deciding that since you're the sender you don't want them through the list? IIRC there's an option for that in the subscription preferences. Yeah, it's under the heading Receive your own posts to the list? There's also something about receiving a confirmation email that would be a big hammer to check if your posts are getting through. -- Dan ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 30993] New: getFramebufferAttachmentParameteriv wrongly generates error
https://bugs.freedesktop.org/show_bug.cgi?id=30993 Summary: getFramebufferAttachmentParameteriv wrongly generates error Product: Mesa Version: unspecified Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: Mesa core AssignedTo: mesa-dev@lists.freedesktop.org ReportedBy: z...@google.com when the value of GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE is GL_NONE, querying pname GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME should return zero. Currently GL_INVALID_ENUM is generated. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 30993] getFramebufferAttachmentParameteriv wrongly generates error
https://bugs.freedesktop.org/show_bug.cgi?id=30993 --- Comment #1 from Brian Paul bri...@vmware.com 2010-10-19 16:09:15 PDT --- Created an attachment (id=39558) View: https://bugs.freedesktop.org/attachment.cgi?id=39558 Review: https://bugs.freedesktop.org/review?bug=30993attachment=39558 proposed fix/patch Can you test the attached patch? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 30993] getFramebufferAttachmentParameteriv wrongly generates error
https://bugs.freedesktop.org/show_bug.cgi?id=30993 Ian Romanick i...@freedesktop.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||NOTABUG --- Comment #2 from Ian Romanick i...@freedesktop.org 2010-10-19 16:35:01 PDT --- Mesa is correct in generating GL_INVALID_ENUM when the object type is not one of GL_TEXTURE or GL_RENDERBUFFER. The GL_ARB_framebuffer_objects spec says: If the value of FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE is RENDERBUFFER, then ... If the value of FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE is TEXTURE, then ... Otherwise, an INVALID_ENUM error is generated. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 30993] getFramebufferAttachmentParameteriv wrongly generates error
https://bugs.freedesktop.org/show_bug.cgi?id=30993 --- Comment #3 from Brian Paul bri...@vmware.com 2010-10-19 16:38:49 PDT --- I looked at the GL_ARB_fbo spec too, but the GL 3.3 spec says (page 276): If the value of FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE is NONE, no framebuffer is bound to target. In this case querying pname FRAMEBUFFER_- ATTACHMENT_OBJECT_NAME will return zero, and all other queries will generate an INVALID_OPERATION error. Though I guess since we don't yet support GL 3.3 the code is OK as-is. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 30993] getFramebufferAttachmentParameteriv wrongly generates error
https://bugs.freedesktop.org/show_bug.cgi?id=30993 Ian Romanick i...@freedesktop.org changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|NOTABUG | --- Comment #4 from Ian Romanick i...@freedesktop.org 2010-10-19 17:03:00 PDT --- (In reply to comment #3) I looked at the GL_ARB_fbo spec too, but the GL 3.3 spec says (page 276): If the value of FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE is NONE, no framebuffer is bound to target. In this case querying pname FRAMEBUFFER_- ATTACHMENT_OBJECT_NAME will return zero, and all other queries will generate an INVALID_OPERATION error. Though I guess since we don't yet support GL 3.3 the code is OK as-is. ARG! The same language is in the 3.0 spec, and GL_ARB_framebuffer_objects is supposed to match 3.0. It seems we've found a spec bug. I've submitted a bug against the GL_ARB_framebuffer_objects spec. I've also added piglit test fbo-getframebufferattachmentparameter-01 the reproduces this bug and another similar bug. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
