Re: [Mesa-dev] freedreno CI day 1

2019-09-13 Thread Eric Anholt
Eric Anholt  writes:

> [ Unknown signature status ]
> I pushed the branch enabling freedreno CI today.  Now all the MRs will
> get pre-merge testing with GLES3.1 on A630, and GLES2 on A307.
>
> See .gitlab-ci/README.md for more info on how it works.  Also, as a
> reminder, if you want to get something tested before generating your MR,
> you can either edit .gitlab-ci.yml to change .ci-run-policy, or push the
> branch to your repo with a name starting with "ci-".  Secondary note: If
> you make an MR from a branch starting with "ci-", it will have two
> pipelines run every time you update it :(
>
> Today's surprises:
>
> - layout_binding.ssbo.fragment_binding_array is unstable
>
> I did one test to see if a patch I had on hand would fix it, and it
> didn't, so I pushed through a patch disabling that test from CI so you
> all wouldn't see those failures.
>
> - EXT4 FS corruption
>
> A few unfortunate events came together for this one: I had the kernel
> boot args mounting / rw out of habit from back in my NFS-root days, and
> there's no initrd to fsck /, and also I have harshly power-cycled them
> all in the process of setting things up.  This adds up to "there's minor
> corruption on / that may impact test runs."  Watch out for mysterious
> docker errors.  If this occurs at a bothersome rate, feel free to push a
> disable of freedreno CI until I can fix it, though it doesn't look too
> bad yet.  I'll be fixing those boot args and making sure that we've got
> clean filesystems on all boards tomorrow.

I've now enabled fsck on all the boards and we should be back in
business.  Looks like I can do this kind of change (bringing each board
down in turn) without interrupting overall CI availability, which seems
like a pretty good test.


signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 108541] Convert x86 assembly stub to PIC to fix linking with lld

2019-09-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108541

--- Comment #3 from ytht@gmail.com ---
FYI, I create a merge request on behalf of Jonathan Gray:

https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1974

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [ANNOUNCE] Mesa 19.1.7 release candidate

2019-09-13 Thread Juan A. Suarez Romero
Hello list,

The candidate for the Mesa 19.1.7 is now available. Currently we have:
 - 30 queued
 - 0 nominated (outstanding)
 - and 0 rejected patch


The current queue consist as usual on fixes for different parts.

Take a look at section "Mesa stable queue" for more information


Testing reports/general approval

Any testing reports (or general approval of the state of the branch) will be
greatly appreciated.

The plan is to have 19.1.7 this Tuesday (17th September), around or shortly 
after
10:00 GMT.

If you have any questions or suggestions - be that about the current patch queue
or otherwise, please go ahead.


Trivial merge conflicts
---
commit 2959de1f92018919c42f2c445fadfc4a01a699e7 (HEAD -> 19.1, 
origin/staging/19.1, staging/19.1)
Author: Samuel Pitoiset 

radv: fix allocating number of user sgprs if streamout is used

(cherry picked from commit 8137df3a46abc6aa6ad0c7179d042e76ca2b2299)


commit 01d452de585560868359729ca459437298789485
Author: Jason Ekstrand 

nir: Don't infinitely recurse in lower_ssa_defs_to_regs_block

(cherry picked from commit 517142252f0c63189293c7176efbf490b7ae95ea)


commit 2977a3e0e1a5f0950001e12402c9936e5d38ab9e
Author: Eric Engestrom 

anv: add support for driconf

(cherry picked from commit 4dcb1fff19383ae451f3228e55d3fc987a7ab46d)


commit 5fcb149a461c3025d643df7aa0713b1d64ab0a6f
Author: Eric Engestrom 

egl: fix deadlock in malloc error path

(cherry picked from commit 43d470404c47d86d1fab93d1345e09375bcf4fb6)


Cheers,
J.A.


Mesa stable queue
-

Nominated (0)
==

Queued (30)
===
Caio Marcelo de Oliveira Filho (1):
  glsl/nir: Avoid overflow when setting max_uniform_location

Connor Abbott (1):
  radv: Call nir_propagate_invariant()

Danylo Piliaiev (1):
  tgsi_to_nir: Translate TGSI_INTERPOLATE_COLOR as INTERP_MODE_NONE

Eric Engestrom (10):
  ttn: fix 64-bit shift on 32-bit `1`
  egl: fix deadlock in malloc error path
  util/os_file: fix double-close()
  anv: fix format string in error message
  nir: fix memleak in error path
  anv: add support for driconf
  wsi: add minImageCount override
  anv: add support for vk_x11_override_min_image_count
  amd: move adaptive sync to performance section, as it is defined in 
xmlpool
  radv: add support for vk_x11_override_min_image_count

Erik Faye-Lund (2):
  gallium/auxiliary/indices: consistently apply start only to input
  util: fix SSE-version needed for double opcodes

Hal Gentz (1):
  glx: Fix SEGV due to dereferencing a NULL ptr from XCB-GLX.

Jason Ekstrand (7):
  Revert "intel/fs: Move the scalar-region conversion to the generator."
  anv: Bump maxComputeWorkgroupSize
  nir: Don't infinitely recurse in lower_ssa_defs_to_regs_block
  nir: Add a block_is_unreachable helper
  nir/repair_ssa: Repair dominance for unreachable blocks
  nir/repair_ssa: Insert deref casts when needed
  nir/dead_cf: Repair SSA if the pass makes progress

Kenneth Graunke (1):
  gallium: Fix util_format_get_depth_only

Lionel Landwerlin (1):
  vulkan/overlay: bounce image back to present layout

Mauro Rossi (3):
  android: radv: fix necessary dependecies
  android: amd/common: fix missing include path
  android: anv: libmesa_vulkan_common: add libmesa_util static dependency

Samuel Pitoiset (1):
  radv: fix allocating number of user sgprs if streamout is used

Sergii Romantsov (1):
  intel/dri: finish proper glthread


Rejected (0)
=


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] glx: set the custom logger across all DRI impls.

2019-09-13 Thread Emil Velikov
From: Emil Velikov 

Earlier commit refactored common code into the loader, yet did not set
the custom logger (one that honours LIBGL_DEBUG).

Thus LIBGL_DEBUG=verbose was working only with DRI3.

Fixes: d971a4230d5 ("loader: Factor out the common driver opening logic from 
each loader.")
Cc: Eric Anholt 
Cc: Eric Engestrom 
Signed-off-by: Emil Velikov 
---
 src/glx/dri2_glx.c  | 2 ++
 src/glx/dri3_glx.c  | 4 ++--
 src/glx/dri_glx.c   | 2 ++
 src/glx/drisw_glx.c | 2 ++
 4 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c
index d6a543c8da0..3105e01983b 100644
--- a/src/glx/dri2_glx.c
+++ b/src/glx/dri2_glx.c
@@ -1425,6 +1425,8 @@ dri2CreateDisplay(Display * dpy)
struct dri2_display *pdp;
int eventBase, errorBase, i;
 
+   loader_set_logger(dri_message);
+
if (!DRI2QueryExtension(dpy, , ))
   return NULL;
 
diff --git a/src/glx/dri3_glx.c b/src/glx/dri3_glx.c
index a5cf0e3bf32..b700871fefc 100644
--- a/src/glx/dri3_glx.c
+++ b/src/glx/dri3_glx.c
@@ -1061,6 +1061,8 @@ dri3_create_display(Display * dpy)
xcb_generic_error_t  *error;
const xcb_query_extension_reply_t*extension;
 
+   loader_set_logger(dri_message);
+
xcb_prefetch_extension_data(c, _dri3_id);
xcb_prefetch_extension_data(c, _present_id);
 
@@ -1105,8 +1107,6 @@ dri3_create_display(Display * dpy)
pdp->base.destroyDisplay = dri3_destroy_display;
pdp->base.createScreen = dri3_create_screen;
 
-   loader_set_logger(dri_message);
-
pdp->loader_extensions = loader_extensions;
 
return >base;
diff --git a/src/glx/dri_glx.c b/src/glx/dri_glx.c
index 6e9412d3fb1..ae7b5a736d2 100644
--- a/src/glx/dri_glx.c
+++ b/src/glx/dri_glx.c
@@ -987,6 +987,8 @@ driCreateDisplay(Display * dpy)
int eventBase, errorBase;
int major, minor, patch;
 
+   loader_set_logger(dri_message);
+
if (!XF86DRIQueryExtension(dpy, , )) {
   return NULL;
}
diff --git a/src/glx/drisw_glx.c b/src/glx/drisw_glx.c
index f38dbbca2df..2efee2aa841 100644
--- a/src/glx/drisw_glx.c
+++ b/src/glx/drisw_glx.c
@@ -973,6 +973,8 @@ driswCreateDisplay(Display * dpy)
 {
struct drisw_display *pdpyp;
 
+   loader_set_logger(dri_message);
+
pdpyp = malloc(sizeof *pdpyp);
if (pdpyp == NULL)
   return NULL;
-- 
2.23.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 111683] SPIR-V shader causes display freeze

2019-09-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111683

Bug ID: 111683
   Summary: SPIR-V shader causes display freeze
   Product: Mesa
   Version: unspecified
  Hardware: Other
OS: All
Status: NEW
  Severity: not set
  Priority: not set
 Component: Drivers/Vulkan/radeon
  Assignee: mesa-dev@lists.freedesktop.org
  Reporter: a...@google.com
QA Contact: mesa-dev@lists.freedesktop.org

Created attachment 145346
  --> https://bugs.freedesktop.org/attachment.cgi?id=145346=edit
Amber test that exposes the problem

Doing:

amber -d killer.amber

causes my machine to lock up (the display freezes, then goes into a pretty cool
and crazy scramble of colours).

Build: Mesa 19.2.0-devel (git-2eace10c62) (Debug)
Device: Radeon RX Vega

I expect this is related to https://bugs.freedesktop.org/show_bug.cgi?id=47
- that was a highly reduced shader.  I have included the unreduced shader in
the hope that the issue is less likely to be sensitive to small changes in
shader compilation.

I have tried enabling amdgpu.gpu_recovery=1 but this doesn't seem to help.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 111681] Shared Memeory leakage in XCreateDrawable

2019-09-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111681

andreasgottschl...@outlook.de changed:

   What|Removed |Added

   Priority|not set |high

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 111681] Shared Memeory leakage in XCreateDrawable

2019-09-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111681

Bug ID: 111681
   Summary: Shared Memeory leakage in XCreateDrawable
   Product: Mesa
   Version: 19.1
  Hardware: x86 (IA32)
OS: Linux (All)
Status: NEW
  Severity: major
  Priority: not set
 Component: GLX
  Assignee: mesa-dev@lists.freedesktop.org
  Reporter: andreasgottschl...@outlook.de
QA Contact: mesa-dev@lists.freedesktop.org

Created attachment 145344
  --> https://bugs.freedesktop.org/attachment.cgi?id=145344=edit
Solving the shared memory leakge problem

In rc/glx/drisw_glx.c
XCreateDrawable(struct drisw_drawable * pdp, int shmid, Display * dpy)

it will be checked at entering function if there is an image already defined
and if so it will get destroyed. Unfortunately this marks the Shared Memory
only as "dest" ( "Mark the segment to be destroyed. The segment will actually
be destroyed only after the last process detaches it.")
But after this call the XShmDetachCall is missing and so shared memory will sum
up until the program is finished

I tested attached patch it works.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev