Re: [Mesa-dev] [PATCH] winsys/amdgpu: avoid double simple_mtx_unlock()

2019-11-28 Thread Marek Olšák 
Pushed, thanks!

Marek

On Thu, Nov 28, 2019 at 12:56 AM Jonathan Gray  wrote:

> pthread_mutex_unlock() when unlocked is documented by posix as
> being undefined behaviour.  On OpenBSD pthread_mutex_unlock() will call
> abort(3) if this happens.
>
> This occurs in amdgpu_winsys_create() after
> cb446dc0fa5c68f681108f4613560543aa4cf553
> winsys/amdgpu: Add amdgpu_screen_winsys
>
> Signed-off-by: Jonathan Gray 
> Cc: 19.2 19.3 
> ---
>  src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c
> b/src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c
> index a89432d8594..2fe227c9213 100644
> --- a/src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c
> +++ b/src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c
> @@ -326,7 +326,6 @@ amdgpu_winsys_create(int fd, const struct
> pipe_screen_config *config,
> aws = util_hash_table_get(dev_tab, dev);
> if (aws) {
>pipe_reference(NULL, >reference);
> -  simple_mtx_unlock(_tab_mutex);
>
>/* Release the device handle, because we don't need it anymore.
> * This function is returning an existing winsys instance, which
> --
> 2.24.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Hardware assisted (VDPAU) decoding of MPEG-2 causes GPU lockup on Radeon HD6320

2019-11-28 Thread Christian König 

Hi Will,

well that's the very first APU generation and unfortunately nobody is 
working on that old hardware any more.


MPEG2 is known to not be fully supported by that chipset in general. So 
the best approach is probably to not use hardware acceleration for MPEG2 
clips in general.


Regards,
Christian.

Am 27.11.19 um 18:35 schrieb Will DeBerry:

Hi all,

I am reaching out hoping to get some assistance with resolving a 
bug/crash that we see with the GPU when using VDPAU hardware 
acceleration on Ubuntu 16.04. This is specific to the r600 drivers 
interacting with VDPAU when trying to playback certain mpeg2 content.


*GPU in question per lscpi: *
00:01.0 VGA compatible controller: Advanced Micro Devices, Inc. 
[AMD/ATI] Wrestler [Radeon HD 6320]


We are highly invested in this GPU and would love to get this 
addressed as soon as possible and are also willing to sponsor this 
work if needed.


*Steps to Recreate:*

 1. Launch VLC with VDPAU hardware acceleration and deinterlacing enabled
 2. Play the attached piece of known bad content
 3. Wait for GPU lockup

Per dmesg, the GPU thread gets locked up within the kernel and thus 
breaks all GUI related activities until the PC is rebooted.


*Mesa Version Tested:*
18.0.5-0ubuntu0~16.04.1
18.2.8-2~bpo9+1

Let me know if you have any questions or are interested in discussing 
this further.


Thanks,

--

*Will DeBerry*

Manager, Client Devices

GetWellNetwork

o: 240.482.4237 | m: 813.330.0121 | getwellnetwork.com 



___



Join us for GetConnected 2020! REGISTER TODAY 






___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] Hardware assisted (VDPAU) decoding of MPEG-2 causes GPU lockup on Radeon HD6320

2019-11-28 Thread Will DeBerry 
Hi all,

I am reaching out hoping to get some assistance with resolving a bug/crash
that we see with the GPU when using VDPAU hardware acceleration on Ubuntu
16.04. This is specific to the r600 drivers interacting with VDPAU when
trying to playback certain mpeg2 content.

*GPU in question per lscpi: *
00:01.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI]
Wrestler [Radeon HD 6320]

We are highly invested in this GPU and would love to get this addressed as
soon as possible and are also willing to sponsor this work if needed.

*Steps to Recreate:*

   1. Launch VLC with VDPAU hardware acceleration and deinterlacing enabled
   2. Play the attached piece of known bad content
   3. Wait for GPU lockup

Per dmesg, the GPU thread gets locked up within the kernel and thus breaks
all GUI related activities until the PC is rebooted.

*Mesa Version Tested:*
18.0.5-0ubuntu0~16.04.1
18.2.8-2~bpo9+1

Let me know if you have any questions or are interested in discussing this
further.

Thanks,

-- 

*Will DeBerry*

Manager, Client Devices

GetWellNetwork

o: 240.482.4237 | m: 813.330.0121 | getwellnetwork.com


___

Join us for GetConnected 2020!  REGISTER TODAY

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev