Re: [Mesa-dev] configure fails to find llvm since recent llvm commit.

2017-07-04 Thread Rafael Avila de Espindola
Emil Velikov <emil.l.veli...@gmail.com> writes:

> On 4 July 2017 at 16:04, Rafael Avila de Espindola
> <rafael.espind...@gmail.com> wrote:
>> Emil Velikov <emil.l.veli...@gmail.com> writes:
>>
>>> So the version is FOOgit-$SHA while the DSO uses, FOOsvn. At the same
>>> time at least 3.9.0/3.9.1 has broken llvm-config --libnames/libfiles,
>>> so we cannot rely on that.
>>> Doesn't seem like LLVM is giving us something robust to work with here.
>>>
>>> LLVM users/devs (Rafael), I would suggest up-streaming a patch which
>>> changes that toggle default value, for now.
>>> As LLVM does a few releases where it has a reliable way of determining
>>> the library name users can switch to it.
>>>
>>> How does this sound?
>>
>> I am not sure I understand why having the hash in the version causes
>> problems.
>>
> Because llvm-config --libnames/libfiles is unreliable ;-( Hence we use
> llvm-config --version to get the DSO name.

OK, looks like that is the real bug that needs to be fixed.

Is there a bug report?

Cheers,
Rafael
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] configure fails to find llvm since recent llvm commit.

2017-07-04 Thread Rafael Avila de Espindola
Emil Velikov  writes:

> So the version is FOOgit-$SHA while the DSO uses, FOOsvn. At the same
> time at least 3.9.0/3.9.1 has broken llvm-config --libnames/libfiles,
> so we cannot rely on that.
> Doesn't seem like LLVM is giving us something robust to work with here.
>
> LLVM users/devs (Rafael), I would suggest up-streaming a patch which
> changes that toggle default value, for now.
> As LLVM does a few releases where it has a reliable way of determining
> the library name users can switch to it.
>
> How does this sound?

I am not sure I understand why having the hash in the version causes
problems.

Can you send an email to llvm-...@lists.llvm.org about it?

Cheers,
Rafael
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] configure fails to find llvm since recent llvm commit.

2017-07-03 Thread Rafael Avila de Espindola
What check is configure doing?

Is the llvm build a clean one? What is the value of LLVM_APPEND_VC_REV?

Cheers,
Rafael


Andy Furniss  writes:

> Don't know if mesa needs changing or it's an llvm needs fixing issue, 
> but since llvm commit
>
> commit 78fbc18aed8024139cb87c5db69ab5b43dc615d6
> Author: Rafael Espindola 
> Date:   Fri Jun 30 18:48:33 2017 +
>
>  Completely disable git/svn version checking if not needed.
>
>  Working with git on a branch I find it really annoying that committing
>  a change causes ninja to think that stuff needs to be rebuilt.
>
>  With this change at least nothing in llvm needs to be rebuild when
>  something is committed.
>
>  git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@306858 
> 91177308-0d34-0410-b5e6-96231b3b80d8
>
> configuring mesa bails after failing to find llvm shared libs (and gives 
> outdated suggestion). Shared libs are installed.
>
> checking for AMDGPU... yes
> configure: error: Could not find llvm shared libraries:
>  Please make sure you have built llvm with the --enable-shared 
> option
>  and that your llvm libraries are installed in /usr/lib
>  If you have installed your llvm libraries to a different 
> directory you
>  can use the --with-llvm-prefix= configure flag to specify this 
> directory.
>  NOTE: Mesa is attempting to use llvm shared libraries by default.
>  If you do not want to build with llvm shared libraries and 
> instead want to
>  use llvm static libraries then add --disable-llvm-shared-libs 
> to your configure
>  invocation and rebuild.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev